Skip to contentSkip to conversation

2.6.23 git current compile error on UP

DISCUSSION Dave Hansen 2 participants 2 messages Nov 8, 2007 KVM

lore
Share & tools
lore
#0 lore raw

drivers/kvm/kvm_main.c: In function `kvm_flush_remote_tlbs':
drivers/kvm/kvm_main.c:220: error: implicit declaration of function `smp_call_function_mask' make[2]: *** [drivers/kvm/kvm_main.o] Error 1
make[1]: *** [drivers/kvm] Error 2

http://sr71.net/~dave/linux/config-kvm-up

Looks like that function calls smp_call_function_mask() which is never defined for UP. Nobody else uses it that way, so I'm not sure what the right fix is. I'm not even sure kvm_flush_remote_tlbs() is safe with its raw_smp_processor_id() use. Is there a reason it can't get preempted?

-- Dave

#1 lore raw
Quoted 5 lines · Dave Hansen

drivers/kvm/kvm_main.c: In function `kvm_flush_remote_tlbs':
drivers/kvm/kvm_main.c:220: error: implicit declaration of function `smp_call_function_mask' make[2]: *** [drivers/kvm/kvm_main.o] Error 1
make[1]: *** [drivers/kvm] Error 2

Quoted 7 lines

http://sr71.net/~dave/linux/config-kvm-up

Looks like that function calls smp_call_function_mask() which is never defined for UP. Nobody else uses it that way, so I'm not sure what the right fix is. I'm not even sure kvm_flush_remote_tlbs() is safe with its raw_smp_processor_id() use. Is there a reason it can't get preempted?

Avi has already posted a patch to correct this.

http://lkml.org/lkml/2007/10/24/95

Laurent

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/

_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel