Skip to contentSkip to conversation

drivers/video/s1d13xxxfb.c as module with dbg

PATCH In review Stanislav Brabec 4 participants 4 messages Nov 10, 2007 – Nov 13, 2007 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/video/s1d13xxxfb.c as module with dbg

Attached patch fixes two compilation problems of s1d13xxxfb.c:
- Fixes outdated dbg() message to fix compilation error with debugging enabled.
- Do not read kernel command line options when compiled as module.

drivers/video/s1d13xxxfb.c +4 -1
@@ -540,7 +540,7 @@
 	int ret = 0;
 	u8 revision;
 
-	dbg("probe called: device is %p\n", dev);
+	dbg("probe called: device is %p\n", pdev);
 
 	printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
 
@@ -753,8 +753,11 @@
 static int __init
 s1d13xxxfb_init(void)
 {
+
+#ifndef MODULE
 	if (fb_get_options("s1d13xxxfb", NULL))
 		return -ENODEV;
+#endif
 
 	return platform_driver_register(&s1d13xxxfb_driver);
 }

________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx

#1 lore raw
Quoted 35 lines · Stanislav Brabec

Attached patch fixes two compilation problems of s1d13xxxfb.c:
- Fixes outdated dbg() message to fix compilation error with debugging enabled.
- Do not read kernel command line options when compiled as module.

drivers/video/s1d13xxxfb.c 2007-11-02 16:48:34.000000000 +0100 renamed from drivers/video/s1d13xxxfb.c 2007-10-09 22:31:38.000000000 +0200 +4 -1
@@ -540,7 +540,7 @@
        int ret = 0;
        u8 revision;
 
-       dbg("probe called: device is %p\n", dev);
+       dbg("probe called: device is %p\n", pdev);
 
        printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
 
@@ -753,8 +753,11 @@
 static int __init
 s1d13xxxfb_init(void)
 {
+
+#ifndef MODULE
        if (fb_get_options("s1d13xxxfb", NULL))
                return -ENODEV;
+#endif
 
        return platform_driver_register(&s1d13xxxfb_driver);
 }

________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx

Quoted 6 lines

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

we also need to look at splitting out the "chip revision", which is currently hard set, as I have had very good results with this driver and chip S1D13506, which is functionally similar but without the external clocking and without teh internal ram.
We also have some build dependancies related to "CONFIG_FB_S1D13XXX"
and ics1523 , this chip is not used on the full range of S1D13XXX and causes errors in the build , for chips such as S1D13506. potentially we could re-use most of the code, but would need a way to pass in S1D_CHIP_REV and one or 2 other chip specific data items.

Steve

#2 lore raw
Quoted 4 lines · dave chung

we also need to look at splitting out the "chip revision", which is currently hard set, as I have had very good results with this driver and chip S1D13506, which is functionally similar but without the external clocking and without teh internal ram.

Well I wrote the initial driver mostly as a rather quick hack. I didn't have access to other hw from the s1d13 family (other than the
806) at that time, and could only guess that supporting them shouldn't be too complicated. Nowadays I don't even have access to the 806 itself anymore, so I'm afraid I won't be of much help.

HTH

T-Bone

Signature · 2 lines
Thibaut VARENE
http://www.parisc-linux.org/~varenet/
#3 lore raw
In reply to dave chung
Quoted 36 lines · On Sun, 11 Nov 2007 07:29:35 +0800 "dave chung" <[email protected]> wrote:
Quoted 35 lines · Stanislav Brabec

Attached patch fixes two compilation problems of s1d13xxxfb.c:
- Fixes outdated dbg() message to fix compilation error with debugging enabled.
- Do not read kernel command line options when compiled as module.

drivers/video/s1d13xxxfb.c 2007-11-02 16:48:34.000000000 +0100 renamed from drivers/video/s1d13xxxfb.c 2007-10-09 22:31:38.000000000 +0200 +4 -1
@@ -540,7 +540,7 @@
        int ret = 0;
        u8 revision;
 
-       dbg("probe called: device is %p\n", dev);
+       dbg("probe called: device is %p\n", pdev);
 
        printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
 
@@ -753,8 +753,11 @@
 static int __init
 s1d13xxxfb_init(void)
 {
+
+#ifndef MODULE
        if (fb_get_options("s1d13xxxfb", NULL))
                return -ENODEV;
+#endif
 
        return platform_driver_register(&s1d13xxxfb_driver);
 }

________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx

Quoted 16 lines
Quoted 6 lines

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

we also need to look at splitting out the "chip revision", which is currently hard set, as I have had very good results with this driver and chip S1D13506, which is functionally similar but without the external clocking and without teh internal ram.
We also have some build dependancies related to "CONFIG_FB_S1D13XXX"
and ics1523 , this chip is not used on the full range of S1D13XXX and causes errors in the build , for chips such as S1D13506. potentially we could re-use most of the code, but would need a way to pass in S1D_CHIP_REV and one or 2 other chip specific data items.

Im all for that. Got 2 platforms (Mobilepro 900c & HP Jornada 720) with both uses S1D13... based chipsets. The driver should make more room for similiar versions.

Quoted 7 lines

Steve
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/