Skip to contentSkip to conversation

zfcp: fix dismissal of error recovery actions

PATCH New Martin Peschke 1 participant 1 message Nov 15, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 zfcp: fix dismissal of error recovery actions

zfcp_erp_action_dismiss() used to ignore any actions in the ready list. This is a bug. Any action superseded by a stronger action needs to be dismissed. This patch changes zfcp_erp_action_dismiss() so that it dismisses actions regardless of their list affiliation. The ERP thread is able to handle this. It is important to kick the erp thread only for actions in the running list, though, as an imbalance of wakeup signals would confuse the erp thread otherwise.

---
 drivers/s390/scsi/zfcp_erp.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletion(-)
drivers/s390/scsi/zfcp_erp.c +3 -1
@@ -977,7 +977,9 @@ static void zfcp_erp_action_dismiss(stru
 	debug_text_event(adapter->erp_dbf, 2, "a_adis");
 	debug_event(adapter->erp_dbf, 2, &erp_action->action, sizeof (int));
 
-	zfcp_erp_async_handler_nolock(erp_action, ZFCP_STATUS_ERP_DISMISSED);
+	erp_action->status |= ZFCP_STATUS_ERP_DISMISSED;
+	if (zfcp_erp_action_exists(erp_action) == ZFCP_ERP_ACTION_RUNNING)
+		zfcp_erp_action_ready(erp_action);
 }
 
 int