Skip to contentSkip to conversation

gfs2: tidy up error message

PATCH In review David Teigland 3 participants 3 messages Nov 15, 2007 GFS2 file system

lore
Share & tools
lore

David Teigland

author
#0 lore raw

PATCH 1/1 gfs2: tidy up error message

Print error with log_error() to be consistent with others.

Signed-off-by David Teigland <[email protected]>
---
 fs/gfs2/locking/dlm/mount.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
fs/gfs2/locking/dlm/mount.c +1 -2
index ab30102..f2efff4 100644
@@ -68,8 +68,7 @@ static int make_args(struct gdlm_ls *ls, char *data_arg, int *nodir)
 	strncpy(data, data_arg, 255);
 
 	if (!strlen(data)) {
-		printk(KERN_ERR
-		       "DLM/GFS2/GFS ERROR: (u)mount helpers are not installed!\n");
+		log_error("no mount options, (u)mount helpers not installed");
 		return -EINVAL;
 	}
Signature · 1 line
1.5.2.1
#1 lore raw

PATCH 1/1 gfs2: tidy up error message

Signed-off-by Fabio M. Di Nitto <[email protected]>
Quoted 21 lines · David Teigland

Print error with log_error() to be consistent with others.

Signed-off-by David Teigland <[email protected]>
---
 fs/gfs2/locking/dlm/mount.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
fs/gfs2/locking/dlm/mount.c +1 -2
index ab30102..f2efff4 100644
@@ -68,8 +68,7 @@ static int make_args(struct gdlm_ls *ls, char *data_arg, int *nodir)
 	strncpy(data, data_arg, 255);
 
 	if (!strlen(data)) {
-		printk(KERN_ERR
-		       "DLM/GFS2/GFS ERROR: (u)mount helpers are not installed!\n");
+		log_error("no mount options, (u)mount helpers not installed");
 		return -EINVAL;
 	}
Signature · 1 line
I'm going to make him an offer he can't refuse.
#2 lore raw
In reply to David Teigland

Hi,

Now in the -nmw git tree. Thanks,

Steve.

Quoted 21 lines · David Teigland

Print error with log_error() to be consistent with others.

Signed-off-by David Teigland <[email protected]>
---
 fs/gfs2/locking/dlm/mount.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
fs/gfs2/locking/dlm/mount.c +1 -2
index ab30102..f2efff4 100644
@@ -68,8 +68,7 @@ static int make_args(struct gdlm_ls *ls, char *data_arg, int *nodir)
 	strncpy(data, data_arg, 255);
 
 	if (!strlen(data)) {
-		printk(KERN_ERR
-		       "DLM/GFS2/GFS ERROR: (u)mount helpers are not installed!\n");
+		log_error("no mount options, (u)mount helpers not installed");
 		return -EINVAL;
 	}