Skip to contentSkip to conversation

cfi: make cfi_staa_erase_varsize static to shut up sparse

PATCH In review Andre Haupt 2 participants 2 messages Nov 16, 2007 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cfi: make cfi_staa_erase_varsize static to shut up sparse

should this be static?

From: Andre Haupt <[email protected]>

---
 drivers/mtd/chips/cfi_cmdset_0020.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/chips/cfi_cmdset_0020.c +1 -1
index b344ff8..07a3dd4 100644
@@ -893,7 +893,7 @@ retry:
 	return ret;
 }
 
-int cfi_staa_erase_varsize(struct mtd_info *mtd, struct erase_info *instr)
+static int cfi_staa_erase_varsize(struct mtd_info *mtd, struct erase_info *instr)
 {	struct map_info *map = mtd->priv;
 	struct cfi_private *cfi = map->fldrv_priv;
 	unsigned long adr, len;
Signature · 1 line
1.4.4.4
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Andre Haupt

should this be static?

Looks like it.

Quoted 2 lines

From: Andre Haupt <[email protected]>

Quoted 20 lines
---
 drivers/mtd/chips/cfi_cmdset_0020.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/chips/cfi_cmdset_0020.c +1 -1
index b344ff8..07a3dd4 100644
@@ -893,7 +893,7 @@ retry:
 	return ret;
 }
 
-int cfi_staa_erase_varsize(struct mtd_info *mtd, struct erase_info *instr)
+static int cfi_staa_erase_varsize(struct mtd_info *mtd, struct erase_info *instr)
 {	struct map_info *map = mtd->priv;
 	struct cfi_private *cfi = map->fldrv_priv;
 	unsigned long adr, len;
Signature · 1 line
1.4.4.4

Jörn

Signature · 2 lines
The strong give up and move away, while the weak give up and stay.
-- unknown