Skip to contentSkip to conversation

MMC/SDIO sub-system: block mode versus byte mode

DISCUSSION Dean Jenkins 2 participants 4 messages Nov 22, 2007

lore
Share & tools
lore
#0 lore raw

Hi Pierre,

I've been checking my SDIO CMD53 data transfers and I notice the following:

block size = 256 bytes for my SDIO card.

transfers of 256 bytes uses byte mode ( I expected block mode ) transfers of 512 bytes uses block mode ( because blocks = 2 )

Quoted 1 line

From the SD spec a single block transfer seems to be valid.

I notice the function mmc_io_rw_extended() in sdio_ops.c seems to select byte mode when the transfer size is 512 or less when the blocks parameter variable is 1. In fact blocks is never 0.

Therefore is this a feature or a bug that prevents 256 bytes being sent in block mode when it is a single complete 1 block of data ?

If it is a bug then I suggest the sdio_io_rw_ext_helper() in sdio_io.c be able to select byte mode by setting blocks to 0 and then blocks can be set to 1 to select block mode for a single block.

Have I missed something ?

Technically, there is a bug in sdio_io_rw_ext_helper() in sdio_io.c

211 while (remainder > func->cur_blksize) {

should be, = missing

211 while (remainder >= func->cur_blksize) {

however the resulting call to mmc_io_rw_extended() is the same as blocks = 1 for both the "block mode" while loop (with the "fix") and the "byte mode" while loop (without the "fix"). The "byte mode" while loop has a hard coded value of 1 for the blocks parameter. So the bug is masked. As I said above, I think the "byte mode" should use a value of 0 for the blocks parameter.

What do you think ?

Regards,
Dean.

Signature · 4 lines
Dean Jenkins
Embedded Software Engineer
MontaVista Software (UK)
Professional Services Division
#1 lore raw
Quoted 5 lines · On Thu, 22 Nov 2007 10:41:43 +0000 Dean Jenkins <[email protected]> wrote:

Hi Pierre,

I've been checking my SDIO CMD53 data transfers and I notice the following:

Quoted 7 lines

block size = 256 bytes for my SDIO card.

transfers of 256 bytes uses byte mode ( I expected block mode ) transfers of 512 bytes uses block mode ( because blocks = 2 )

From the SD spec a single block transfer seems to be valid.

Both are valid, which is the source of the problem. The API was designed under the assumption that hardware actually followed the register interface and didn't distinguish between byte and block transfers. Unfortunately, it seems to be quite common that they do. Your situation is a problematic corner case.

Quoted 5 lines

If it is a bug then I suggest the sdio_io_rw_ext_helper() in sdio_io.c be able to select byte mode by setting blocks to 0 and then blocks can be set to 1 to select block mode for a single block.

I'm afraid I don't follow. Do you want to add another parameter? Even if you do, sdio_io_rw_ext_helper() is an internal API. Changing it won't make things better for the function drivers.

Quoted 9 lines

Technically, there is a bug in sdio_io_rw_ext_helper() in sdio_io.c

211 while (remainder > func->cur_blksize) {

should be, = missing

211 while (remainder >= func->cur_blksize) {

Unless some hardware is quirky in the opposite way and needs to be able to do byte transfer of 256 bytes. Proper cards won't care either way, but as you can see, we can't support both types of buggy cards.

Quoted 7 lines

however the resulting call to mmc_io_rw_extended() is the same as blocks = 1 for both the "block mode" while loop (with the "fix") and the "byte mode" while loop (without the "fix"). The "byte mode" while loop has a hard coded value of 1 for the blocks parameter. So the bug is masked. As I said above, I think the "byte mode" should use a value of 0 for the blocks parameter.

Ah. mmc_io_rw_extended() is indeed broken in that it can't do single block requests. That should be fixed.

However, it still won't affect what your function driver can do as mmc_io_rw_extended() is a bunch of layers down.

I guess I'll have to consider adding a more low-level API. The big problem with such a call would be that it can fail requests because the host or card cannot satisfy them. So a function driver using such an API would have to use a much more defensive programming (which can incur a performance hit).

Rgds

Signature · 5 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
#2 lore raw

Hi Pierre,

Thanks for information.

My card does support 256 byte transfers in byte mode but I was expecting block mode to be used as block mode is supported by the card. Indeed, sdio_io_rw_ext_helper() checks for support of block mode before using byte mode. eg. block mode is preferred over byte mode in the design of sdio_io_rw_ext_helper().

Yes, I do think single block transfers is broken :(

Both sdio_io_rw_ext_helper() and mmc_io_rw_extended() are broken for single block transfers.

Will you be doing a fix or how does a fix get proposed ?

Thanks,

Regards,
Dean.

Quoted 53 lines · Pierre Ossman
Quoted 5 lines · On Thu, 22 Nov 2007 10:41:43 +0000 Dean Jenkins <djenkins@...> wrote:

Hi Pierre,

I've been checking my SDIO CMD53 data transfers and I notice the following:

Quoted 7 lines

block size = 256 bytes for my SDIO card.

transfers of 256 bytes uses byte mode ( I expected block mode ) transfers of 512 bytes uses block mode ( because blocks = 2 )

From the SD spec a single block transfer seems to be valid.

Both are valid, which is the source of the problem. The API was designed under the assumption that hardware actually followed the register interface and didn't distinguish between byte and block transfers. Unfortunately, it seems to be quite common that they do. Your situation is a problematic corner case.

Quoted 5 lines

If it is a bug then I suggest the sdio_io_rw_ext_helper() in sdio_io.c be able to select byte mode by setting blocks to 0 and then blocks can be set to 1 to select block mode for a single block.

I'm afraid I don't follow. Do you want to add another parameter? Even if you do, sdio_io_rw_ext_helper() is an internal API. Changing it won't make things better for the function drivers.

Quoted 9 lines

Technically, there is a bug in sdio_io_rw_ext_helper() in sdio_io.c

211 while (remainder > func->cur_blksize) {

should be, = missing

211 while (remainder >= func->cur_blksize) {

Unless some hardware is quirky in the opposite way and needs to be able to do byte transfer of 256 bytes. Proper cards won't care either way, but as you can see, we can't support both types of buggy cards.

Quoted 7 lines

however the resulting call to mmc_io_rw_extended() is the same as blocks = 1 for both the "block mode" while loop (with the "fix") and the "byte mode" while loop (without the "fix"). The "byte mode" while loop has a hard coded value of 1 for the blocks parameter. So the bug is masked. As I said above, I think the "byte mode" should use a value of 0 for the blocks parameter.

Ah. mmc_io_rw_extended() is indeed broken in that it can't do single block requests. That should be fixed.

However, it still won't affect what your function driver can do as mmc_io_rw_extended() is a bunch of layers down.

I guess I'll have to consider adding a more low-level API. The big problem with such a call would be that it can fail requests because the host or card cannot satisfy them. So a function driver using such an API would have to use a much more defensive programming (which can incur a performance hit).

Rgds

Signature · 4 lines
Dean Jenkins
Embedded Software Engineer
MontaVista Software (UK)
Professional Services Division
#3 lore raw
Quoted 9 lines · On Thu, 22 Nov 2007 12:15:11 +0000 Dean Jenkins <[email protected]> wrote:

Hi Pierre,

Thanks for information.

My card does support 256 byte transfers in byte mode but I was expecting block mode to be used as block mode is supported by the card. Indeed, sdio_io_rw_ext_helper() checks for support of block mode before using byte mode. eg. block mode is preferred over byte mode in the design of sdio_io_rw_ext_helper().

Not really, no. What it preferred is a low number of transfers. Hence we try to shuffle as much data as possible using blocks first.

Quoted 8 lines

Yes, I do think single block transfers is broken :(

Both sdio_io_rw_ext_helper() and mmc_io_rw_extended() are broken for single block transfers.

Will you be doing a fix or how does a fix get proposed ?

I agree that mmc_io_rw_extended() is broken, but I do not think sdio_io_rw_ext_helper() is. I'll be doing a fix eventually, but it probably won't get that high on my todo list as it will only be useful together with some new API. Since your card was content with byte transfers, it shouldn't be that much need for a rush.

Rgds

Signature · 5 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org