ACPI patches for rc3 - part 2
Subsystems (4)
Len Brown
reviewerTwo urgent patches to get upstream before rc4...
Len Brown
reviewerPATCH 1/2 ACPI: Delete the IRQ operation in throttling controll via PTC
From: Zhao Yakui <[email protected]>
The IRQ operation(enable/disable) should be avoided when throttling is controlled via PTC method. It is replaced by the migration of task.
This fixes an oops on T61 -- a regression due tof79f06ab9f86 b/c FixedHW support tried to read remote MSR with interrupts disabled.
--- drivers/acpi/processor_throttling.c | 36 +++++++++++++++++++++++++++------- 1 files changed, 28 insertions(+), 8 deletions(-)
drivers/acpi/processor_throttling.c +28 -8
@@ -29,6 +29,7 @@#include <linux/kernel.h> #include <linux/module.h> #include <linux/init.h> +#include <linux/sched.h> #include <linux/cpufreq.h> #include <linux/proc_fs.h> #include <linux/seq_file.h>
@@ -413,7 +414,7 @@ static int acpi_throttling_rdmsr(struct acpi_processor *pr, }else { msr_low =0 ; msr_high =0 ; -rdmsr_on_cpu (cpu,MSR_IA32_THERM_CONTROL , +rdmsr_safe (MSR_IA32_THERM_CONTROL , (u32 *)&msr_low , (u32 *) &msr_high); msr = (msr_high <<32 ) | msr_low; *value = (acpi_integer ) msr;
@@ -438,7 +439,7 @@ static int acpi_throttling_wrmsr(struct acpi_processor *pr, acpi_integer value) "HARDWARE addr space,NOT supported yet\n"); }else { msr = value; -wrmsr_on_cpu (cpu,MSR_IA32_THERM_CONTROL , +wrmsr_safe (MSR_IA32_THERM_CONTROL , msr &0xffffffff , msr >>32 ); ret =0 ; }
@@ -572,21 +573,32 @@ static int acpi_processor_get_throttling_ptc(struct acpi_processor *pr)return -ENODEV ; pr->throttling.state =0 ; -local_irq_disable (); + value =0 ; ret =acpi_read_throttling_status (pr, &value);if (ret >=0 ) { state =acpi_get_throttling_state (pr, value); pr->throttling.state = state; } -local_irq_enable ();return 0 ; }static int acpi_processor_get_throttling (struct acpi_processor *pr) { -return pr->throttling.acpi_processor_get_throttling (pr); +cpumask_t saved_mask; +int ret; + +/* +* Migrate task to the cpu pointed by pr. +*/ + saved_mask = current->cpus_allowed; +set_cpus_allowed (current,cpumask_of_cpu (pr->id)); + ret = pr->throttling.acpi_processor_get_throttling (pr); +/* restore the previous state */ +set_cpus_allowed (current, saved_mask); + +return ret; }static int acpi_processor_get_fadt_info (struct acpi_processor *pr)
@@ -717,21 +729,29 @@ static int acpi_processor_set_throttling_ptc(struct acpi_processor *pr,if (state < pr->throttling_platform_limit)return -EPERM ; -local_irq_disable (); value =0 ; ret =acpi_get_throttling_value (pr, state, &value);if (ret >=0 ) {acpi_write_throttling_state (pr, value); pr->throttling.state = state; } -local_irq_enable ();return 0 ; }int acpi_processor_set_throttling (struct acpi_processor *pr,int state) { -return pr->throttling.acpi_processor_set_throttling (pr, state); +cpumask_t saved_mask; +int ret; +/* +* Migrate task to the cpu pointed by pr. +*/ + saved_mask = current->cpus_allowed; +set_cpus_allowed (current,cpumask_of_cpu (pr->id)); + ret = pr->throttling.acpi_processor_set_throttling (pr, state); +/* restore the previous state */ +set_cpus_allowed (current, saved_mask); +return ret; }int acpi_processor_get_throttling_info (struct acpi_processor *pr)
Signature · 1 line
1.5.3.7.949.g2221a6
Len Brown
reviewerPATCH 2/2 ACPICA: fix acpi-cpufreq boot crash due to _PSD return-by-reference
In reply to Len BrownFrom: Bob Moore <[email protected]>
Changed resolution of named references in packages
Fixed a problem with the Package operator where all named references were created as object references and left otherwise unresolved. According to the ACPI specification, a Package can only contain Data Objects or references to control methods. The implication is that named references to Data Objects (Integer, Buffer, String, Package, BufferField, Field) should be resolved immediately upon package creation. This is the approach taken with this change. References to all other named objects (Methods, Devices, Scopes, etc.) are all now properly created as reference objects.
http://bugzilla.kernel.org/show_bug.cgi?id=5328
http://bugzilla.kernel.org/show_bug.cgi?id=9429
--- drivers/acpi/dispatcher/dsobject.c | 91 +++++++++++++++++++++++++++++++++-- 1 files changed, 85 insertions(+), 6 deletions(-)
drivers/acpi/dispatcher/dsobject.c +85 -6
@@ -137,6 +137,71 @@ acpi_ds_build_internal_object(struct acpi_walk_state *walk_state,return_ACPI_STATUS (status); } } + +/* Special object resolution for elements of a package */ + +if ((op->common.parent->common.aml_opcode ==AML_PACKAGE_OP ) || + (op->common.parent->common.aml_opcode == +AML_VAR_PACKAGE_OP )) { +/* +* Attempt to resolve the node to a value before we insert it into +* the package. If this is a reference to a common data type, +* resolve it immediately. According to the ACPI spec, package +* elements can only be "data objects" or method references. +* Attempt to resolve to an Integer, Buffer, String or Package. +* If cannot, return the named reference (for things like Devices, +* Methods, etc.) Buffer Fields and Fields will resolve to simple +* objects (int/buf/str/pkg). +* +* NOTE: References to things like Devices, Methods, Mutexes, etc. +* will remain as named references. This behavior is not described +* in the ACPI spec, but it appears to be an oversight. +*/ + obj_desc = (union acpi_operand_object *)op->common.node; + + status = +acpi_ex_resolve_node_to_value (ACPI_CAST_INDIRECT_PTR + (struct + acpi_namespace_node, + &obj_desc), + walk_state); +if (ACPI_FAILURE (status)) { +return_ACPI_STATUS (status); + } + +switch (op->common.node->type) { +/* +* For these types, we need the actual node, not the subobject. +* However, the subobject got an extra reference count above. +*/ +case ACPI_TYPE_MUTEX : +case ACPI_TYPE_METHOD : +case ACPI_TYPE_POWER : +case ACPI_TYPE_PROCESSOR : +case ACPI_TYPE_EVENT : +case ACPI_TYPE_REGION : +case ACPI_TYPE_DEVICE : +case ACPI_TYPE_THERMAL : + + obj_desc = + (union acpi_operand_object *)op->common. + node; +break ; + +default : +break ; + } + +/* +* If above resolved to an operand object, we are done. Otherwise, +* we have a NS node, we must create the package entry as a named +* reference. +*/ +if (ACPI_GET_DESCRIPTOR_TYPE (obj_desc) != +ACPI_DESC_TYPE_NAMED ) { + goto exit; + } + } }/* Create and init a new internal ACPI object */
@@ -156,6 +221,7 @@ acpi_ds_build_internal_object(struct acpi_walk_state *walk_state,return_ACPI_STATUS (status); } + exit: *obj_desc_ptr = obj_desc;return_ACPI_STATUS (AE_OK ); }
@@ -356,12 +422,25 @@ acpi_ds_build_internal_package_obj(struct acpi_walk_state *walk_state, arg = arg->common.next; for (i = 0; arg && (i < element_count); i++) { if (arg->common.aml_opcode == AML_INT_RETURN_VALUE_OP) { - - /* This package element is already built, just get it */ - - obj_desc->package.elements[i] = - ACPI_CAST_PTR(union acpi_operand_object, - arg->common.node); + if (arg->common.node->type == ACPI_TYPE_METHOD) { + /* + * A method reference "looks" to the parser to be a method + * invocation, so we special case it here + */ + arg->common.aml_opcode = AML_INT_NAMEPATH_OP; + status = + acpi_ds_build_internal_object(walk_state, + arg, + &obj_desc-> + package. + elements[i]); + } else { + /* This package element is already built, just get it */ + + obj_desc->package.elements[i] = + ACPI_CAST_PTR(union acpi_operand_object, + arg->common.node); + } } else { status = acpi_ds_build_internal_object(walk_state, arg, &obj_desc->
Signature · 1 line
1.5.3.7.949.g2221a6
Quoted 1 line · Len Brown
Two urgent patches to get upstream before rc4...
I have two more urgent patches, related to suspend. Both of them fix recent regressions.
Please push upstream.
Greetings,
Rafael
PATCH 1/2 HWMON: coretemp, suspend fix
From: Rafael J. Wysocki <[email protected]>
It's not permitted to unregister a device after devices have been suspended. It causes deadlocks to appear on systems with coretemp hwmon loaded. To avoid this, we can make coretemp_cpu_callback() do nothing if the _FROZEN bit is set in action.
Also, in other cases it's generally too late to unregister the coretemp device if the CPU is already dead, so it should be unregistered on CPU_DOWN_PREPARE.
--- drivers/hwmon/coretemp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/hwmon/coretemp.c +2 -3
@@ -337,11 +337,10 @@ static int coretemp_cpu_callback(structswitch (action) {case CPU_ONLINE : -case CPU_ONLINE_FROZEN : +case CPU_DOWN_FAILED :coretemp_device_add (cpu);break ; -case CPU_DEAD : -case CPU_DEAD_FROZEN : +case CPU_DOWN_PREPARE :coretemp_device_remove (cpu);break ; }
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] HWMON: coretemp, suspend fix
Applied to suspend branch.
thanks,
-Len
Quoted 38 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
It's not permitted to unregister a device after devices have been suspended. It causes deadlocks to appear on systems with coretemp hwmon loaded. To avoid this, we can makecoretemp_cpu_callback()do nothing if the_FROZENbit is set in action.
Also, in other cases it's generally too late to unregister the coretemp device if the CPU is already dead, so it should be unregistered onCPU_DOWN_PREPARE.Signed-off-by Rafael J. Wysocki <[email protected]>Acked-by Mark M. Hoffman <[email protected]>Cc Jiri Slaby <[email protected]>Cc Andrew Morton <[email protected]>--- drivers/hwmon/coretemp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)Index:
linux-2.6/drivers/hwmon/coretemp.c
===================================================================drivers/hwmon/coretemp.c +2
-3@@ -337,11 +337,10 @@ static int coretemp_cpu_callback(structswitch (action) {case CPU_ONLINE : -case CPU_ONLINE_FROZEN : +case CPU_DOWN_FAILED :coretemp_device_add (cpu);break ; -case CPU_DEAD : -case CPU_DEAD_FROZEN : +case CPU_DOWN_PREPARE :coretemp_device_remove (cpu);break ; }
Re: [PATCH 1/2] HWMON: coretemp, suspend fix
In reply to Rafael J. WysockiApplied to suspend branch.
thanks,
-Len
Quoted 28 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
It's not permitted to unregister a device after devices have been suspended. It causes deadlocks to appear on systems with coretemp hwmon loaded. To avoid this, we can makecoretemp_cpu_callback()do nothing if the_FROZENbit is set in action.
Also, in other cases it's generally too late to unregister the coretemp device if the CPU is already dead, so it should be unregistered onCPU_DOWN_PREPARE.Signed-off-by Rafael J. Wysocki <[email protected]>Acked-by Mark M. Hoffman <[email protected]>Cc Jiri Slaby <[email protected]>Cc Andrew Morton <[email protected]>--- drivers/hwmon/coretemp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)Index:
linux-2.6/drivers/hwmon/coretemp.c
===================================================================drivers/hwmon/coretemp.c +0
-0@@ -337,11 +337,10 @@ static int coretemp_cpu_callback(structswitch (action) {case CPU_ONLINE :
drivers/hwmon/coretemp.c static int coretemp_cpu_callback(struct · line 346
Quoted 10 lines
drivers/hwmon/coretemp.c +2
-3-case CPU_ONLINE_FROZEN : +case CPU_DOWN_FAILED :coretemp_device_add (cpu);break ; -case CPU_DEAD : -case CPU_DEAD_FROZEN : +case CPU_DOWN_PREPARE :coretemp_device_remove (cpu);break ; }
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] HWMON: coretemp, suspend fix
Quoted 1 line · Len Brown
Applied to suspend branch.
Thanks!
BTW, the 4 topmost non-merge commits from the suspend branch are supposed to go to Linus ASAP. Any chance to push them upstream?
Rafael
Quoted 41 lines · Rafael J. Wysocki
Quoted 38 lines
From: Rafael J. Wysocki <[email protected]>
It's not permitted to unregister a device after devices have been suspended. It causes deadlocks to appear on systems with coretemp hwmon loaded. To avoid this, we can makecoretemp_cpu_callback()do nothing if the_FROZENbit is set in action.
Also, in other cases it's generally too late to unregister the coretemp device if the CPU is already dead, so it should be unregistered onCPU_DOWN_PREPARE.Signed-off-by Rafael J. Wysocki <[email protected]>Acked-by Mark M. Hoffman <[email protected]>Cc Jiri Slaby <[email protected]>Cc Andrew Morton <[email protected]>--- drivers/hwmon/coretemp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)Index:
linux-2.6/drivers/hwmon/coretemp.c
===================================================================drivers/hwmon/coretemp.c +2
-3@@ -337,11 +337,10 @@ static int coretemp_cpu_callback(structswitch (action) {case CPU_ONLINE : -case CPU_ONLINE_FROZEN : +case CPU_DOWN_FAILED :coretemp_device_add (cpu);break ; -case CPU_DEAD : -case CPU_DEAD_FROZEN : +case CPU_DOWN_PREPARE :coretemp_device_remove (cpu);break ; }
Signature · 5 lines
"Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] HWMON: coretemp, suspend fix
In reply to Len BrownQuoted 1 line · Len Brown
Applied to suspend branch.
Thanks!
BTW, the 4 topmost non-merge commits from the suspend branch are supposed to go to Linus ASAP. Any chance to push them upstream?
Rafael
Quoted 41 lines · Rafael J. Wysocki
Quoted 38 lines
From: Rafael J. Wysocki <[email protected]>
It's not permitted to unregister a device after devices have been suspended. It causes deadlocks to appear on systems with coretemp hwmon loaded. To avoid this, we can makecoretemp_cpu_callback()do nothing if the_FROZENbit is set in action.
Also, in other cases it's generally too late to unregister the coretemp device if the CPU is already dead, so it should be unregistered onCPU_DOWN_PREPARE.Signed-off-by Rafael J. Wysocki <[email protected]>Acked-by Mark M. Hoffman <[email protected]>Cc Jiri Slaby <[email protected]>Cc Andrew Morton <[email protected]>--- drivers/hwmon/coretemp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)Index:
linux-2.6/drivers/hwmon/coretemp.c
===================================================================drivers/hwmon/coretemp.c +2
-3@@ -337,11 +337,10 @@ static int coretemp_cpu_callback(structswitch (action) {case CPU_ONLINE : -case CPU_ONLINE_FROZEN : +case CPU_DOWN_FAILED :coretemp_device_add (cpu);break ; -case CPU_DEAD : -case CPU_DEAD_FROZEN : +case CPU_DOWN_PREPARE :coretemp_device_remove (cpu);break ; }
Signature · 1 line
"Premature optimization is the root of all evil." - Donald Knuth
PATCH 1/2 HWMON: coretemp, suspend fix
In reply to Rafael J. WysockiFrom: Rafael J. Wysocki <[email protected]>
It's not permitted to unregister a device after devices have been suspended. It causes deadlocks to appear on systems with coretemp hwmon loaded. To avoid this, we can make coretemp_cpu_callback() do nothing if the _FROZEN bit is set in action.
Also, in other cases it's generally too late to unregister the coretemp device if the CPU is already dead, so it should be unregistered on CPU_DOWN_PREPARE.
--- drivers/hwmon/coretemp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/hwmon/coretemp.c +2 -3
@@ -337,11 +337,10 @@ static int coretemp_cpu_callback(structswitch (action) {case CPU_ONLINE : -case CPU_ONLINE_FROZEN : +case CPU_DOWN_FAILED :coretemp_device_add (cpu);break ; -case CPU_DEAD : -case CPU_DEAD_FROZEN : +case CPU_DOWN_PREPARE :coretemp_device_remove (cpu);break ; }
PATCH 2/2 Freezer: Fix JFFS2 garbage collector freezing issue
In reply to Rafael J. WysockiFrom: Rafael J. Wysocki <[email protected]>
Fix breakage caused by commit d5d8c5976d6adeddb8208c240460411e2198b393 "freezer: do not send signals to kernel threads" in jffs2_garbage_collect_thread() that assumed it would be sent signals by the freezer.
--- fs/jffs2/background.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
fs/jffs2/background.c +5 -3
@@ -103,15 +103,17 @@ static int jffs2_garbage_collect_thread(get there first. */ yield (); +/* If system suspend is in progress, go to the refrigerator and +start again when the suspend is done */ +if (try_to_freeze ()) + goto again; +/* Put_super will send a SIGKILL and then wait on the sem. */ while (signal_pending (current)) {siginfo_t info;unsigned long signr; -if (try_to_freeze ()) - goto again; - signr =dequeue_signal_lock (current, ¤t->blocked, &info);switch (signr) {
Re: [PATCH 2/2] Freezer: Fix JFFS2 garbage collector freezing issue
Quoted 6 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
Fix breakage caused by commit
d5d8c5976d6adeddb8208c240460411e2198b393"freezer: do not send signals to kernel threads" injffs2_garbage_collect_thread()that assumed it would be sent signals by the freezer.
Scratch this one. I'll send an updated version.
The other one is fine, though.
Thanks,
Rafael
Quoted 36 lines
Signed-off-by Rafael J. Wysocki <[email protected]>Cc Pete MacKay <[email protected]>Cc Andrew Morton <[email protected]>--- fs/jffs2/background.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)Index:
linux-2.6/fs/jffs2/background.c
===================================================================fs/jffs2/background.c +5
-4@@ -103,15 +103,17 @@ static int jffs2_garbage_collect_thread(get there first. */ yield (); +/* If system suspend is in progress, go to the refrigerator and +start again when the suspend is done */ +if (try_to_freeze ()) + goto again; +/* Put_super will send a SIGKILL and then wait on the sem. */ while (signal_pending (current)) {siginfo_t info;unsigned long signr; -if (try_to_freeze ()) - goto again; - signr =dequeue_signal_lock (current, ¤t->blocked, &info);switch (signr) { -To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] Freezer: Fix JFFS2 garbage collector freezing issue
In reply to Rafael J. WysockiQuoted 6 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
Fix breakage caused by commit
d5d8c5976d6adeddb8208c240460411e2198b393"freezer: do not send signals to kernel threads" injffs2_garbage_collect_thread()that assumed it would be sent signals by the freezer.
Scratch this one. I'll send an updated version.
The other one is fine, though.
Thanks,
Rafael
Quoted 36 lines
Signed-off-by Rafael J. Wysocki <[email protected]>Cc Pete MacKay <[email protected]>Cc Andrew Morton <[email protected]>--- fs/jffs2/background.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)Index:
linux-2.6/fs/jffs2/background.c
===================================================================fs/jffs2/background.c +5
-4@@ -103,15 +103,17 @@ static int jffs2_garbage_collect_thread(get there first. */ yield (); +/* If system suspend is in progress, go to the refrigerator and +start again when the suspend is done */ +if (try_to_freeze ()) + goto again; +/* Put_super will send a SIGKILL and then wait on the sem. */ while (signal_pending (current)) {siginfo_t info;unsigned long signr; -if (try_to_freeze ()) - goto again; - signr =dequeue_signal_lock (current, ¤t->blocked, &info);switch (signr) { -To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 2/2 Freezer: Fix JFFS2 garbage collector freezing issue
In reply to Rafael J. WysockiFrom: Rafael J. Wysocki <[email protected]>
Fix breakage caused by commit d5d8c5976d6adeddb8208c240460411e2198b393 "freezer: do not send signals to kernel threads" in jffs2_garbage_collect_thread() that assumed it would be sent signals by the freezer.
--- fs/jffs2/background.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
fs/jffs2/background.c +5 -3
@@ -103,15 +103,17 @@ static int jffs2_garbage_collect_thread(get there first. */ yield (); +/* If system suspend is in progress, go to the refrigerator and +start again when the suspend is done */ +if (try_to_freeze ()) + goto again; +/* Put_super will send a SIGKILL and then wait on the sem. */ while (signal_pending (current)) {siginfo_t info;unsigned long signr; -if (try_to_freeze ()) - goto again; - signr =dequeue_signal_lock (current, ¤t->blocked, &info);switch (signr) {