cassini driver skb->truesize bug
Subsystems (2)
Hello,
we got the following message:
SKB BUG: Invalid truesize (376) len=514, sizeof(sk_buff)=248
It only occurs on larger traffic (at speed 100 Mbps: always), but not when downloading a small web page.
In cas_rx_process_pkt() the the skb's truesize is only set via skb_put()
but it is not used if there are fragments, also skb->len is increased by
the fragment's size, but the truesize member is unchanged. I compared it to the implementation in e1000 where all of the len, datalen and trusize members are increased.
If I modify the code to add the fragment's size to the truesize member, the driver allocates all available memory after a while.
Regards,
Attila
Some more investigation revealed that the cassini driver leaks the data portion of all RXed packets, this makes the driver completely unusable.
We've tested the following combinations:
* 2.6.17 (patched, but no cassini related patches)
* 2.6.22 Ubuntu Gutsy.
It still worked in 2.6.12 where we originally backported the driver from 2.6.14.
The sk_buff count in slabinfo stays normal, so the skbs are properly freed. I'm suspicious about all this cas_page_t wrappers.
Is there a maintainer for this driver? All our previous questions went unanswered.
Quoted 24 lines · Laszlo Attila Toth
Hello,
we got the following message:
SKB BUG: Invalid truesize (376) len=514, sizeof(sk_buff)=248It only occurs on larger traffic (at speed 100 Mbps: always), but not when downloading a small web page.
In
cas_rx_process_pkt()the the skb's truesize is only set viaskb_put()but it is not used if there are fragments, alsoskb->lenis increased by the fragment's size, but the truesize member is unchanged. I compared it to the implementation in e1000 where all of the len, datalen and trusize members are increased.If I modify the code to add the fragment's size to the truesize member, the driver allocates all available memory after a while.
Regards,
Attila
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 1 line
Bazsi
David Miller
maintainerFrom: Balazs Scheidler <[email protected]>
Date: Wed, 05 Dec 2007 11:23:46 +0100
Quoted 2 lines
Is there a maintainer for this driver? All our previous questions went unanswered.
There is a rewrite pending and I have some cards arriving soon in the mail.
Meanwhile, either find a way to diagnose and fix this problem yourself or use a different network card.
Thanks.
Hi,
Quoted 7 lines · Balazs Scheidler
Some more investigation revealed that the cassini driver leaks the data portion of all RXed packets, this makes the driver completely unusable.
We've tested the following combinations:
* 2.6.17 (patched, but no cassini related patches)
* 2.6.22 Ubuntu Gutsy.
Quoted 5 lines
It still worked in 2.6.12 where we originally backported the driver from 2.6.14.
The
sk_buffcount in slabinfo stays normal, so the skbs are properly freed. I'm suspicious about all thiscas_page_twrappers.
Commit fa4f0774d7c6cccb4d1fda76b91dd8eddcb2dd6a?
I don't really see how the buffer count for a page used as a fragment gets decreased when the skb is freed.
Signature · 1 line
KOVACS Krisztian