Move functions and make them static
PATCH 9/10 Move functions and make them static
Hi,
This patch doesn't change any code, it just moves it around. Function gfs2_meta_inval is moved from meta_io.c to glops.c and function gfs2_attach_bufdata is moved from meta_io,c to trans.c. Both functions are then declared static.
Regards,
Bob Peterson
Red Hat GFS
Signed-off-by Bob Peterson <[email protected]>
--
.../fs/gfs2/glops.c | 23 +++++++- .../fs/gfs2/meta_io.c | 59 +------------------- .../fs/gfs2/meta_io.h | 6 +-- .../fs/gfs2/trans.c | 38 ++++++++++++- 4 files changed, 61 insertions(+), 65 deletions(-)
gfs2-2.6.git.patch9/fs/gfs2/glops.c renamed from gfs2-2.6.git.patch8/fs/gfs2/glops.c +22 -1
@@ -1,6 +1,6 @@/* * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. -* Copyright (C) 2004-2006 Red Hat, Inc. All rights reserved. +* Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved. * * This copyrighted material is made available to anyone wishing to use, * modify, copy, or redistribute it subject to the terms and conditions
@@ -114,6 +114,27 @@ static void meta_go_sync(struct gfs2_glock *gl) }/** +* gfs2_meta_inval - Invalidate all buffers associated with a glock +* @gl: the glock +* +*/ + +static void gfs2_meta_inval (struct gfs2_glock *gl) +{ +struct gfs2_sbd *sdp = gl->gl_sbd; +struct inode *aspace = gl->gl_aspace; +struct address_space *mapping = gl->gl_aspace->i_mapping; + +gfs2_assert_withdraw (sdp, !atomic_read (&gl->gl_ail_count)); + +atomic_inc (&aspace->i_writecount); +truncate_inode_pages (mapping,0 ); +atomic_dec (&aspace->i_writecount); + +gfs2_assert_withdraw (sdp, !mapping->nrpages); +} + +/** * meta_go_inval - invalidate the metadata for this glock * @gl: the glock * @flags:
gfs2-2.6.git.patch9/fs/gfs2/meta_io.c renamed from gfs2-2.6.git.patch8/fs/gfs2/meta_io.c +1 -58
76 lines not on this page · raw message
gfs2-2.6.git.patch9/fs/gfs2/meta_io.h renamed from gfs2-2.6.git.patch8/fs/gfs2/meta_io.h +1 -5
@@ -1,6 +1,6 @@/* * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. -* Copyright (C) 2004-2006 Red Hat, Inc. All rights reserved. +* Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved. * * This copyrighted material is made available to anyone wishing to use, * modify, copy, or redistribute it subject to the terms and conditions
@@ -40,7 +40,6 @@ static inline void gfs2_buffer_copy_tail(struct buffer_head *to_bh,struct inode *gfs2_aspace_get (struct gfs2_sbd *sdp);void gfs2_aspace_put (struct inode *aspace); -void gfs2_meta_inval (struct gfs2_glock *gl);void gfs2_meta_sync (struct gfs2_glock *gl);struct buffer_head *gfs2_meta_new (struct gfs2_glock *gl,u64 blkno);
@@ -48,9 +47,6 @@ int gfs2_meta_read(struct gfs2_glock *gl, u64 blkno, int flags, struct buffer_head **bhp);int gfs2_meta_wait (struct gfs2_sbd *sdp,struct buffer_head *bh); -void gfs2_attach_bufdata (struct gfs2_glock *gl,struct buffer_head *bh, -int meta); -void gfs2_remove_from_journal (struct buffer_head *bh,struct gfs2_trans *tr,int meta);
gfs2-2.6.git.patch9/fs/gfs2/trans.c renamed from gfs2-2.6.git.patch8/fs/gfs2/trans.c +37 -1
@@ -1,6 +1,6 @@/* * Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. -* Copyright (C) 2004-2006 Red Hat, Inc. All rights reserved. +* Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved. * * This copyrighted material is made available to anyone wishing to use, * modify, copy, or redistribute it subject to the terms and conditions
@@ -131,6 +131,42 @@ void gfs2_trans_end(struct gfs2_sbd *sdp) }/** +* gfs2_attach_bufdata - attach a struct gfs2_bufdata structure to a buffer +* @gl: the glock the buffer belongs to +* @bh: The buffer to be attached to +* @meta: Flag to indicate whether its metadata or not +*/ + +static void gfs2_attach_bufdata (struct gfs2_glock *gl,struct buffer_head *bh, +int meta) +{ +struct gfs2_bufdata *bd; + +if (meta) +lock_page (bh->b_page); + +if (bh->b_private) { +if (meta) +unlock_page (bh->b_page); +return ; + } + + bd =kmem_cache_zalloc (gfs2_bufdata_cachep,GFP_NOFS | __GFP_NOFAIL), + bd->bd_bh = bh; + bd->bd_gl = gl; + +INIT_LIST_HEAD (&bd->bd_list_tr); +if (meta) +lops_init_le (&bd->bd_le, &gfs2_buf_lops); +else +lops_init_le (&bd->bd_le, &gfs2_databuf_lops); + bh->b_private = bd; + +if (meta) +unlock_page (bh->b_page); +} + +/** * gfs2_trans_add_bh - Add a to-be-modified buffer to the current transaction * @gl: the glock the buffer belongs to * @bh: The buffer to add