Skip to contentSkip to conversation

MAINTAINERS: remove Adam Fritzler, update his email address in other sources

PATCH In review Joe Perches 6 participants 10 messages Dec 18, 2007 – Dec 22, 2007

Subsystems (3)
Networking Network drivers SCSI
lore
Share & tools
lore

Joe Perches

author
#0 lore raw

PATCH 1/1 MAINTAINERS: remove Adam Fritzler, update his email address in other sources

Adam isn't a maintainer anymore.
His old email address bounces.
Update to new email address.

Quoted 3 lines · Joe Perches
Quoted 3 lines

You seem to have an old email address in the
linux-kernel MAINTAINERS file.
Should it be deleted or changed?

Quoted 4 lines · Adam Fritzler

I am no longer actively involved. If you can mark me as a former point of contact, that's fine, or you can just delete the entry. My name is still in the source, but with the old address. It'd great if the address in source was updated.

Signed-off-by Joe Perches <[email protected]>
---
 MAINTAINERS                      |    7 -------
 drivers/net/eexpress.c           |    2 +-
 drivers/net/tokenring/abyss.c    |    2 +-
 drivers/net/tokenring/abyss.h    |    2 +-
 drivers/net/tokenring/madgemc.c  |    2 +-
 drivers/net/tokenring/madgemc.h  |    2 +-
 drivers/net/tokenring/proteon.c  |    2 +-
 drivers/net/tokenring/skisa.c    |    2 +-
 drivers/net/tokenring/tms380tr.c |    2 +-
 drivers/net/tokenring/tms380tr.h |    2 +-
 drivers/net/tokenring/tmspci.c   |    2 +-
 drivers/scsi/aha1542.c           |    2 +-
 12 files changed, 11 insertions(+), 18 deletions(-)
MAINTAINERS +0 -7
index 9507b42..690f172 100644
@@ -3758,13 +3758,6 @@ W:	http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/
 T:	git kernel.org:/pub/scm/linux/kernel/git/bunk/trivial.git
 S:	Maintained
 
-TMS380 TOKEN-RING NETWORK DRIVER
-P:	Adam Fritzler
-M:	[email protected]
-L:	[email protected]
-W:	http://www.auk.cx/tms380tr/
-S:	Maintained
-
 TULIP NETWORK DRIVER
 L:	[email protected]
 W:	http://sourceforge.net/projects/tulip/
drivers/net/eexpress.c +1 -1
index 70509ed..46c3c99 100644
@@ -9,7 +9,7 @@
  * Many modifications, and currently maintained, by
  *  Philip Blundell <[email protected]>
  * Added the Compaq LTE  Alan Cox <[email protected]>
- * Added MCA support Adam Fritzler <[email protected]>
+ * Added MCA support Adam Fritzler <[email protected]>
  *
  * Note - this driver is experimental still - it has problems on faster
  * machines. Someone needs to sit down and go through it line by line with
drivers/net/tokenring/abyss.c +1 -1
index 124cfd4..be60792 100644
@@ -10,7 +10,7 @@
  *      - Madge Smart 16/4 PCI Mk2
  *
  *  Maintainer(s):
- *    AF	Adam Fritzler		[email protected]
+ *    AF	Adam Fritzler		[email protected]
  *
  *  Modification History:
  *	30-Dec-99	AF	Split off from the tms380tr driver.
drivers/net/tokenring/abyss.h +1 -1
index 0ee6e4f..93376e1 100644
@@ -2,7 +2,7 @@
  * abyss.h: Header for the abyss tms380tr module
  *
  * Authors:
- * - Adam Fritzler <[email protected]>
+ * - Adam Fritzler <[email protected]>
  */
 
 #ifndef __LINUX_MADGETR_H
drivers/net/tokenring/madgemc.c +1 -1
index 5a41513..b7c819f 100644
@@ -11,7 +11,7 @@
  *	- Madge Smart 16/4 Ringnode MC32 (??)
  *
  *  Maintainer(s):
- *    AF	Adam Fritzler		[email protected]
+ *    AF	Adam Fritzler		[email protected]
  *
  *  Modification History:
  *	16-Jan-00	AF	Created
drivers/net/tokenring/madgemc.h +1 -1
index 2dd8222..b368e59 100644
@@ -2,7 +2,7 @@
  * madgemc.h: Header for the madgemc tms380tr module
  *
  * Authors:
- * - Adam Fritzler <[email protected]>
+ * - Adam Fritzler <[email protected]>
  */
 
 #ifndef __LINUX_MADGEMC_H
drivers/net/tokenring/proteon.c +1 -1
index ca6b659..8fece14 100644
@@ -12,7 +12,7 @@
  *	- Proteon 1392, 1392+
  *
  *  Maintainer(s):
- *    AF        Adam Fritzler           [email protected]
+ *    AF        Adam Fritzler           [email protected]
  *    JF	Jochen Friedrich	[email protected]
  *
  *  Modification History:
drivers/net/tokenring/skisa.c +1 -1
index 32e8d5a..74eae3c 100644
@@ -13,7 +13,7 @@
  *	- SysKonnect TR4/16(+) ISA	(SK-4190)
  *
  *  Maintainer(s):
- *    AF        Adam Fritzler           [email protected]
+ *    AF        Adam Fritzler           [email protected]
  *    JF	Jochen Friedrich	[email protected]
  *
  *  Modification History:
drivers/net/tokenring/tms380tr.c +1 -1
index d5fa36d..5daec2b 100644
@@ -30,7 +30,7 @@
  *  Maintainer(s):
  *    JS	Jay Schulist		[email protected]
  *    CG	Christoph Goos		[email protected]
- *    AF	Adam Fritzler		[email protected]
+ *    AF	Adam Fritzler		[email protected]
  *    MLP       Mike Phillips           [email protected]
  *    JF	Jochen Friedrich	[email protected]
  *
drivers/net/tokenring/tms380tr.h +1 -1
index 7daf74e..7697b17 100644
@@ -3,7 +3,7 @@
  *
  * Authors:
  * - Christoph Goos <[email protected]>
- * - Adam Fritzler <[email protected]>
+ * - Adam Fritzler <[email protected]>
  */
 
 #ifndef __LINUX_TMS380TR_H
drivers/net/tokenring/tmspci.c +1 -1
index 1c18f78..a24153c 100644
@@ -14,7 +14,7 @@
  *      - 3Com 3C339 Token Link Velocity
  *
  *  Maintainer(s):
- *    AF	Adam Fritzler		[email protected]
+ *    AF	Adam Fritzler		[email protected]
  *
  *  Modification History:
  *	30-Dec-99	AF	Split off from the tms380tr driver.
drivers/scsi/aha1542.c +1 -1
index bbcc2c5..3aa978b 100644
@@ -21,7 +21,7 @@
  *  Modified by Chris Faulhaber <[email protected]>
  *        Added module command-line options
  *        19-Jul-99
- *  Modified by Adam Fritzler <[email protected]>
+ *  Modified by Adam Fritzler <[email protected]>
  *        Added proper detection of the AHA-1640 (MCA version of AHA-1540)
  */
#1 lore raw
Quoted 17 lines · On Mon, 17 Dec 2007 20:12:06 -0800 Joe Perches <[email protected]> wrote:

Adam isn't a maintainer anymore.
His old email address bounces.
Update to new email address.

Quoted 3 lines · Joe Perches
Quoted 3 lines

You seem to have an old email address in the
linux-kernel MAINTAINERS file.
Should it be deleted or changed?

Quoted 4 lines · Adam Fritzler

I am no longer actively involved. If you can mark me as a former point of contact, that's fine, or you can just delete the entry. My name is still in the source, but with the old address. It'd great if the address in source was updated.

...

MAINTAINERS +0 -1
-TMS380 TOKEN-RING NETWORK DRIVER

MAINTAINERS W: http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/

Quoted 10 lines
MAINTAINERS +1 -6
-P:	Adam Fritzler
-M:	[email protected]
-L:	[email protected]
-W:	http://www.auk.cx/tms380tr/
-S:	Maintained
 
...
 
- * Added MCA support Adam Fritzler <[email protected]>
+ * Added MCA support Adam Fritzler <[email protected]>

This is fairly pointless - it'll just break again when Adam moves again.

Every problem can be solved with another layer of...

Please: just replace all instances with plain old "Adam Fritzler" and then ensure that the lookup key "Adam Fritzler" has an accurate (and non-duplicated anywhere else!) entry in MAINTAINERS or CREDITS or whatever.

btw, I cheerfully skipped all your spelling-fixes patches. Some will have stuck via subsystem maintainers but I have a secret "no spelling fixes unless they're end-user-visible" policy. That means I'll take spelling fixes only if they're in printks or in Documentation/*. This is a little defense mechanism to avoid getting buried in micropatches.

I'd suggest that you find out if Adrian is still running the trivial tree and if so, patchbomb him.

author
#2 lore raw
Quoted 3 lines · Andrew Morton

Please: just replace all instances with plain old "Adam Fritzler" and then ensure that the lookup key "Adam Fritzler" has an accurate (and non-duplicated anywhere else!) entry in MAINTAINERS or CREDITS or whatever.

Sure. See new patch below

Quoted 1 line

btw, I cheerfully skipped all your spelling-fixes patches.

No worries. I was just avoiding doing useful stuff.

Quoted 3 lines

Some will have
stuck via subsystem maintainers but I have a secret "no spelling fixes unless they're end-user-visible" policy.

I think there were 15-20 printks in that lot.
Do you want them separately?

Quoted 2 lines

I'd suggest that you find out if Adrian is still running the trivial tree and if so, patchbomb him.

OK. Adrian? Do you want the spelling fixes?

Back to Adam Fritzler...

Signed-off-by Joe Perches <[email protected]>
---
 CREDITS                          |    3 +++
 MAINTAINERS                      |    7 -------
 drivers/net/eexpress.c           |    2 +-
 drivers/net/tokenring/abyss.c    |    2 +-
 drivers/net/tokenring/abyss.h    |    2 +-
 drivers/net/tokenring/madgemc.c  |    2 +-
 drivers/net/tokenring/madgemc.h  |    2 +-
 drivers/net/tokenring/proteon.c  |    2 +-
 drivers/net/tokenring/skisa.c    |    2 +-
 drivers/net/tokenring/tms380tr.c |    2 +-
 drivers/net/tokenring/tms380tr.h |    2 +-
 drivers/net/tokenring/tmspci.c   |    2 +-
 drivers/scsi/aha1542.c           |    2 +-
 13 files changed, 14 insertions(+), 18 deletions(-)
CREDITS +3 -0
index ee909f2..449ec7f 100644
@@ -1124,6 +1124,9 @@ S: 1150 Ringwood Court
 S: San Jose, California 95131
 S: USA
 
+N: Adam Fritzler
+E: [email protected]
+
 N: Fernando Fuganti
 E: [email protected]
 E: [email protected]
MAINTAINERS +0 -7
index 9507b42..690f172 100644
@@ -3758,13 +3758,6 @@ W:	http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/
 T:	git kernel.org:/pub/scm/linux/kernel/git/bunk/trivial.git
 S:	Maintained
 
-TMS380 TOKEN-RING NETWORK DRIVER
-P:	Adam Fritzler
-M:	[email protected]
-L:	[email protected]
-W:	http://www.auk.cx/tms380tr/
-S:	Maintained
-
 TULIP NETWORK DRIVER
 L:	[email protected]
 W:	http://sourceforge.net/projects/tulip/
drivers/net/eexpress.c +1 -1
index 70509ed..283fc8f 100644
@@ -9,7 +9,7 @@
  * Many modifications, and currently maintained, by
  *  Philip Blundell <[email protected]>
  * Added the Compaq LTE  Alan Cox <[email protected]>
- * Added MCA support Adam Fritzler <[email protected]>
+ * Added MCA support Adam Fritzler
  *
  * Note - this driver is experimental still - it has problems on faster
  * machines. Someone needs to sit down and go through it line by line with
drivers/net/tokenring/abyss.c +1 -1
index 124cfd4..7a7de04 100644
@@ -10,7 +10,7 @@
  *      - Madge Smart 16/4 PCI Mk2
  *
  *  Maintainer(s):
- *    AF	Adam Fritzler		[email protected]
+ *    AF	Adam Fritzler
  *
  *  Modification History:
  *	30-Dec-99	AF	Split off from the tms380tr driver.
drivers/net/tokenring/abyss.h +1 -1
index 0ee6e4f..b0a473b 100644
@@ -2,7 +2,7 @@
  * abyss.h: Header for the abyss tms380tr module
  *
  * Authors:
- * - Adam Fritzler <[email protected]>
+ * - Adam Fritzler
  */
 
 #ifndef __LINUX_MADGETR_H
drivers/net/tokenring/madgemc.c +1 -1
index 5a41513..c9c5a2b 100644
@@ -11,7 +11,7 @@
  *	- Madge Smart 16/4 Ringnode MC32 (??)
  *
  *  Maintainer(s):
- *    AF	Adam Fritzler		[email protected]
+ *    AF	Adam Fritzler
  *
  *  Modification History:
  *	16-Jan-00	AF	Created
drivers/net/tokenring/madgemc.h +1 -1
index 2dd8222..fe88e27 100644
@@ -2,7 +2,7 @@
  * madgemc.h: Header for the madgemc tms380tr module
  *
  * Authors:
- * - Adam Fritzler <[email protected]>
+ * - Adam Fritzler
  */
 
 #ifndef __LINUX_MADGEMC_H
drivers/net/tokenring/proteon.c +1 -1
index ca6b659..00ea945 100644
@@ -12,7 +12,7 @@
  *	- Proteon 1392, 1392+
  *
  *  Maintainer(s):
- *    AF        Adam Fritzler           [email protected]
+ *    AF        Adam Fritzler
  *    JF	Jochen Friedrich	[email protected]
  *
  *  Modification History:
drivers/net/tokenring/skisa.c +1 -1
index 32e8d5a..41b6999 100644
@@ -13,7 +13,7 @@
  *	- SysKonnect TR4/16(+) ISA	(SK-4190)
  *
  *  Maintainer(s):
- *    AF        Adam Fritzler           [email protected]
+ *    AF        Adam Fritzler
  *    JF	Jochen Friedrich	[email protected]
  *
  *  Modification History:
drivers/net/tokenring/tms380tr.c +1 -1
index d5fa36d..d07c452 100644
@@ -30,7 +30,7 @@
  *  Maintainer(s):
  *    JS	Jay Schulist		[email protected]
  *    CG	Christoph Goos		[email protected]
- *    AF	Adam Fritzler		[email protected]
+ *    AF	Adam Fritzler
  *    MLP       Mike Phillips           [email protected]
  *    JF	Jochen Friedrich	[email protected]
  *
drivers/net/tokenring/tms380tr.h +1 -1
index 7daf74e..7af76d7 100644
@@ -3,7 +3,7 @@
  *
  * Authors:
  * - Christoph Goos <[email protected]>
- * - Adam Fritzler <[email protected]>
+ * - Adam Fritzler
  */
 
 #ifndef __LINUX_TMS380TR_H
drivers/net/tokenring/tmspci.c +1 -1
index 1c18f78..5f0ee88 100644
@@ -14,7 +14,7 @@
  *      - 3Com 3C339 Token Link Velocity
  *
  *  Maintainer(s):
- *    AF	Adam Fritzler		[email protected]
+ *    AF	Adam Fritzler
  *
  *  Modification History:
  *	30-Dec-99	AF	Split off from the tms380tr driver.
drivers/scsi/aha1542.c +1 -1
index bbcc2c5..db202ea 100644
@@ -21,7 +21,7 @@
  *  Modified by Chris Faulhaber <[email protected]>
  *        Added module command-line options
  *        19-Jul-99
- *  Modified by Adam Fritzler <[email protected]>
+ *  Modified by Adam Fritzler
  *        Added proper detection of the AHA-1640 (MCA version of AHA-1540)
  */
#3 lore raw
Quoted 5 lines · Joe Perches
MAINTAINERS +0 -0
index 9507b42..690f172 100644

MAINTAINERS W: http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/ · line 3766

Quoted 9 lines
MAINTAINERS +0 -6
@@ -3758,13 +3758,6 @@ W:	http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/
 T:	git kernel.org:/pub/scm/linux/kernel/git/bunk/trivial.git
 S:	Maintained
 
-TMS380 TOKEN-RING NETWORK DRIVER
-P:	Adam Fritzler
-M:	[email protected]
-L:	[email protected]
-W:	http://www.auk.cx/tms380tr/
-S:	Maintained

That's pretty unfriendly. Presumably the linux-tr list is still active and would still help people with that driver. So how about:

TMS380 TOKEN-RING NETWORK DRIVER

-P:   Adam Fritzler
-M:   [email protected]
 L:   [email protected]

?W:?
-S: Maintained
+S: Orphan

(Dunno what to do about W:)

Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
author
#4 lore raw
Quoted 9 lines · Matthew Wilcox
Quoted 8 lines · Joe Perches
MAINTAINERS +0 -0
index 9507b42..690f172 100644
@@ -3758,13 +3758,6 @@ W:	http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/
 T:	git kernel.org:/pub/scm/linux/kernel/git/bunk/trivial.git
 S:	Maintained
Quoted 9 lines

MAINTAINERS W: http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/ · line 3766

Quoted 6 lines
MAINTAINERS +0 -6
-TMS380 TOKEN-RING NETWORK DRIVER
-P:	Adam Fritzler
-M:	[email protected]
-L:	[email protected]
-W:	http://www.auk.cx/tms380tr/
-S:	Maintained

That's pretty unfriendly. Presumably the linux-tr list is still active and would still help people with that driver. So how about:

The linux-tr list is at least broken, more likely dead. Subscribe requests to [email protected] bounce.

from: http://www.linuxtr.net/index.html

There is a known problem with the mailing list at the moment. If you have a query you can contact me directly at [email protected].

#5 lore raw
In reply to Joe Perches
Quoted 23 lines · On Mon, 17 Dec 2007 20:48:03 -0800 Joe Perches <[email protected]> wrote:

Back to Adam Fritzler...

...

CREDITS +3 -0
index ee909f2..449ec7f 100644
@@ -1124,6 +1124,9 @@ S: 1150 Ringwood Court
 S: San Jose, California 95131
 S: USA
 
+N: Adam Fritzler
+E: [email protected]
+
 N: Fernando Fuganti
 E: [email protected]
 E: [email protected]
MAINTAINERS +0 -0
index 9507b42..690f172 100644

MAINTAINERS W: http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/ · line 3766

Quoted 9 lines
MAINTAINERS +0 -6
@@ -3758,13 +3758,6 @@ W:	http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/
 T:	git kernel.org:/pub/scm/linux/kernel/git/bunk/trivial.git
 S:	Maintained
 
-TMS380 TOKEN-RING NETWORK DRIVER
-P:	Adam Fritzler
-M:	[email protected]
-L:	[email protected]
-W:	http://www.auk.cx/tms380tr/
-S:	Maintained

What was the rationale for removing Adam from MAINTAINERS?

That should have been in the non-existent changelog. Please always reissue a complete changelog when resending any patch.

hm, linux-tr.net seems to be defunct. So I guess that orphaning TMS380 is appropriate, if Adam has left us. Has he?

#6 lore raw
Quoted 37 lines · Andrew Morton
Quoted 23 lines · On Mon, 17 Dec 2007 20:48:03 -0800 Joe Perches <[email protected]> wrote:

Back to Adam Fritzler...

...

CREDITS +3 -0
index ee909f2..449ec7f 100644
@@ -1124,6 +1124,9 @@ S: 1150 Ringwood Court
 S: San Jose, California 95131
 S: USA
 
+N: Adam Fritzler
+E: [email protected]
+
 N: Fernando Fuganti
 E: [email protected]
 E: [email protected]
MAINTAINERS +0 -0
index 9507b42..690f172 100644

MAINTAINERS W: http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/ · line 3766

Quoted 9 lines
MAINTAINERS +0 -6
@@ -3758,13 +3758,6 @@ W:	http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/
 T:	git kernel.org:/pub/scm/linux/kernel/git/bunk/trivial.git
 S:	Maintained
 
-TMS380 TOKEN-RING NETWORK DRIVER
-P:	Adam Fritzler
-M:	[email protected]
-L:	[email protected]
-W:	http://www.auk.cx/tms380tr/
-S:	Maintained

What was the rationale for removing Adam from MAINTAINERS?

Quoted 5 lines

That should have been in the non-existent changelog. Please always reissue a complete changelog when resending any patch.

hm, linux-tr.net seems to be defunct. So I guess that orphaning TMS380 is appropriate, if Adam has left us. Has he?

I don't know that specific answer, but in terms of general policy...

I wouldn't apply this patch until they have been in Documentation/people-removal-schedule.txt for a year or so ;-) More seriously, its not like MAINTAINERS is a mission critical correctness target -- so I think we can do a better job than just yanking people from the file like this.

Jeff

author
#7 lore raw
Quoted 1 line · Jeff Garzik
Quoted 1 line

What was the rationale for removing Adam from MAINTAINERS?

I sent him a patch to that address and it bounced. I sent him a note asking if he was still a maintainer to his new address and he replied:

http://www.gossamer-threads.com/lists/linux/kernel/855361

Quoted 3 lines · Joe Perches
Quoted 3 lines

You seem to have an old email address in the
linux-kernel MAINTAINERS file.
Should it be deleted or changed?

Quoted 4 lines · Adam Fritzler

I am no longer actively involved. If you can mark me as a former point of contact, that's fine, or you can just delete the entry. My name is still in the source, but with the old address. It'd great if the address in source was updated.

cheers, Joe

#8 lore raw
In reply to Andrew Morton
Quoted 3 lines · Andrew Morton

...
I'd suggest that you find out if Adrian is still running the trivial tree and if so, patchbomb him.

I do.

Simply Cc [email protected] for trivial patches and they might magically appear in Linus' tree during the next merge window. :)

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#9 lore raw
In reply to Andrew Morton
Quoted 9 lines · On Mon, 17 Dec 2007 20:28:00 -0800 Andrew Morton <[email protected]>…

btw, I cheerfully skipped all your spelling-fixes patches. Some will have stuck via subsystem maintainers but I have a secret "no spelling fixes unless they're end-user-visible" policy. That means I'll take spelling fixes only if they're in printks or in Documentation/*. This is a little defense mechanism to avoid getting buried in micropatches.

for something more productive.. add an aspell/ispell hook to checkpatch.pl ;-)

Signature · 3 lines
If you want to reach me at my work email, use [email protected]
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org