Skip to contentSkip to conversation

Input: tell mousedev to handle remote console virtual mice using absolute coordinates

RFC PATCH Superseded Micah Parrish 2 participants 2 messages Dec 20, 2007 – Jan 9, 2008 Input drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 Input: tell mousedev to handle remote console virtual mice using absolute coordinates

Devices like the HP Integrated Remote Console Virtual Mouse, which are standard equipment on all Proliant and Integrity servers, produce absolute coordinates instead of relative coordinates. This is done to synchronize the position of the mouse cursor on the client desktop with the mouse cursor position on the server. Mousedev is not designed to pass those absolute events directly to X, but it can translate them into relative movements. It currently does this for tablet like devices and touchpads. This patch merely tells it to also include a device with ABS_X, ABS_Y, and mouse buttons in its list of devices to process input for.

This patch enables the mouse pointer to move when using the remote console. Without this patch, the cursor will not move.

---
I understand that Dell DRAC and Sun Andromeda are or contain a similar device, one which produces absolute X,Y coordinates and ordinary mouse clicks. This patch may also enable these but I have no access to these systems.

 mousedev.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/input/mousedev.c +8 -1
index e1c1da0..2dc1b12 100644
@@ -1028,7 +1028,12 @@ static const struct input_device_id mousedev_ids[] = {
                                BIT_MASK(ABS_PRESSURE) |
                                BIT_MASK(ABS_TOOL_WIDTH) },
        },      /* A touchpad */
-
+       {
+               .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
+                        INPUT_DEVICE_ID_MATCH_KEYBIT |
+                        INPUT_DEVICE_ID_MATCH_ABSBIT,
+               .evbit = { BIT(EV_KEY) | BIT(EV_ABS) | BIT(EV_SYN) },
+               .keybit = { [LONG(BTN_LEFT)] = BIT(BTN_LEFT) },
+               .absbit = { BIT(ABS_X) | BIT(ABS_Y) },
+       },      /* Mouselike device with absolute X and Y but ordinary clicks */
        { },    /* Terminating entry */

};

#1 lore raw

Hi Dmitry,

* Micah Parrish <[email protected]>:

Quoted 11 lines

Devices like the HP Integrated Remote Console Virtual Mouse, which are standard equipment on all Proliant and Integrity servers, produce absolute coordinates instead of relative coordinates. This is done to synchronize the position of the mouse cursor on the client desktop with the mouse cursor position on the server. Mousedev is not designed to pass those absolute events directly to X, but it can translate them into relative movements. It currently does this for tablet like devices and touchpads. This patch merely tells it to also include a device with ABS_X, ABS_Y, and mouse buttons in its list of devices to process input for.

Quoted 2 lines

This patch enables the mouse pointer to move when using the remote console. Without this patch, the cursor will not move.

We're looking to get this patch accepted into a distro, which is of course easier if it is first accepted upstream.

Is there anything we can do to help explain this patch further to enable acceptance?

Thanks.

/ac