[Bluez-devel] patch removing one extra memset

Pavel Semerad

author

2008-01-07 23:09 UTC #0 lore raw

Helo,

I have found one mistake in audio/ctl_bluetooth.c . When initializing this plugin, 'data' is allocated and memset-ed to 0. Then socket is created and assigned to 'data'. And then there is another memset, which sets this socket back to zero.
Patch removing this extra memset is attached:

--- ./audio/ctl_bluetooth.c.ps 2007-12-08 20:04:39.000000000 +0100
+++ ./audio/ctl_bluetooth.c 2008-01-07 23:41:23.000000000 +0100
@ -327,8 +327,6 @@ SND_CTL_PLUGIN_DEFINE_FUNC(bluetooth)

        if (err < 0)
                goto error;

- memset(data, 0, sizeof(*data));
-

        data->ext.version = SND_CTL_EXT_VERSION;
        data->ext.card_idx = -1;

Pavel Semerad

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Brad Midgley

2008-01-07 23:47 UTC #1 lore raw

Pavel

Quoted 3 lines

I have found one mistake in audio/ctl_bluetooth.c . When initializing this plugin, 'data' is allocated and memset-ed to 0. Then socket is created and assigned to 'data'. And then there is another memset

ok, fixed. I also saw the first memset happened before the test to see if the malloc worked.

Signature · 11 lines

Brad

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Alok

2008-01-08 15:23 UTC #2 lore raw

PATCH 1/1 HFP method "SetupCall" + audio-api.txt update

Hi Johan/Fredric,

Here is a patch for adding the SetupCall method , used for call setup on hfp. Also adding a patch to update the audio-api.txt file for the same.

Let me know if anything needs to be changed.

-Alok.

Index: audio/audio-api.txt
===================================================================
RCS file: /cvsroot/bluez/utils/audio/audio-api.txt,v retrieving revision 1.25

audio-api.txt +11 -0

diff -u -5 -p -r1.25 audio-api.txt
@@ -181,10 +181,17 @@ Methods		void Connect()
 
 		void SetMicrophoneGain(uint16 gain)
 
 			Changes the current speaker gain if possible.
 
+                void SetupCall(string value)
+
+                        Sets up an call with the connected HFP.
+                        value can be incoming, outgoing
+                        or remote to indicate incoming call, outgoing
+                        call and remote party alerted respectively.                                                                   
+
 Signals		void AnswerRequested()
 
 			Sent when the answer button is pressed on the headset
 
 		void Connected()

@@ -209,10 +216,14 @@ Signals		void AnswerRequested()
 
 		void MicrophoneGainChanged(uint16 gain)
 
 			The microphone gain changed.
 
+                void TerminateCall()
+
+                        Sent when an ongoing call is terminated.                
+
 
 org.bluez.audio.Gateway interface
 =================================
 
 [not yet implemented]

Index: audio/headset.c
===================================================================
RCS file: /cvsroot/bluez/utils/audio/headset.c,v
retrieving revision 1.153

headset.c +51 -0

71 lines not on this page · raw message

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Marcel Holtmann

maintainer

2008-01-08 18:28 UTC #3 lore raw

Re: [Bluez-devel] [PATCH] HFP method "SetupCall" + audio-api.txt update

Hi Alok,

Quoted 4 lines

Here is a patch for adding the SetupCall method , used for call setup on hfp. Also adding a patch to update the audio-api.txt file for the same.
Let me know if anything needs to be changed.

the signal should be "CallTerminated" or its description is wrong. A name like "TerminateCall" would be a name for a method.

Regards

Marcel

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Johan Hedberg

2008-01-09 03:06 UTC #4 lore raw

Re: [Bluez-devel] [PATCH] HFP method "SetupCall" + audio-api.txt update

Hi Marcel,

Quoted 9 lines · Marcel Holtmann

Quoted 6 lines
Here is a patch for adding the SetupCall method , used for call setup on
hfp. Also adding a patch to update the audio-api.txt file for the same.
Let me know if anything needs to be changed.
the signal should be "CallTerminated" or its description is wrong. A name like "TerminateCall" would be a name for a method.

The CVS now has the correct name for the signal ("CallTerminated").

Johan

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel