Remove #undef DEBUG from MPC83xx board header files

PATCH New Timur Tabi 4 participants 8 messages Jan 9, 2008 – Jan 12, 2008

Share & tools

Timur Tabi

author

2008-01-09 16:16 UTC #0 lore raw

PATCH 1/1 Remove #undef DEBUG from MPC83xx board header files

Remove the "#undef DEBUG" line from all Freescale 83xx board header files. The inclusion of this line makes it impossible to enable debug code in other source files, because "#define DEBUG" typically needs to be defined before any header files are included.

Signed-off-by Timur Tabi <[email protected]>

---
 include/configs/MPC8323ERDB.h |    2 --
 include/configs/MPC832XEMDS.h |    2 --
 include/configs/MPC8349EMDS.h |    2 --
 include/configs/MPC8360EMDS.h |    2 --
 include/configs/MPC837XEMDS.h |    2 --
 5 files changed, 0 insertions(+), 10 deletions(-)

include/configs/MPC8323ERDB.h +0 -2

index 564de02..1dd1cfa 100644
@@ -9,8 +9,6 @@
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
-#undef DEBUG
-
 /*
  * High Level Configuration Options
  */

include/configs/MPC832XEMDS.h +0 -2

index a48b311..88a3ed3 100644
@@ -20,8 +20,6 @@
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
-#undef DEBUG
-
 /*
  * High Level Configuration Options
  */

include/configs/MPC8349EMDS.h +0 -2

index 03409bb..b8c3153 100644
@@ -29,8 +29,6 @@
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
-#undef DEBUG
-
 /*
  * High Level Configuration Options
  */

include/configs/MPC8360EMDS.h +0 -2

index fedb8a9..edd6673 100644
@@ -22,8 +22,6 @@
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
-#undef DEBUG
-
 /*
  * High Level Configuration Options
  */

include/configs/MPC837XEMDS.h +0 -2

index 0958e6b..e3595c7 100644
@@ -21,8 +21,6 @@
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
-#undef DEBUG
-
 /*
  * High Level Configuration Options
  */

Signature · 1 line

1.5.2.4

Kim Phillips

2008-01-11 03:30 UTC #1 lore raw

PATCH 1/1 Remove #undef DEBUG from MPC83xx board header files

Quoted 5 lines · On Wed, 9 Jan 2008 10:16:32 -0600 Timur Tabi <[email protected]> wrote:

Remove the "#undef DEBUG" line from all Freescale 83xx board header files. The inclusion of this line makes it impossible to enable debug code in other source files, because "#define DEBUG" typically needs to be defined before any header files are included.

Quoted 8 lines

Signed-off-by Timur Tabi <[email protected]>

---
 include/configs/MPC8323ERDB.h |    2 --
 include/configs/MPC832XEMDS.h |    2 --
 include/configs/MPC8349EMDS.h |    2 --
 include/configs/MPC8360EMDS.h |    2 --
 include/configs/MPC837XEMDS.h |    2 --
 5 files changed, 0 insertions(+), 10 deletions(-)

hmm..what about the rest of the boards that do this?:

include/configs/AP1000.h:#undef DEBUG
include/configs/BAB7xx.h:#undef DEBUG
include/configs/EB+MCF-EV123.h:#undef DEBUG
include/configs/ELPPC.h:#undef DEBUG
include/configs/IPHASE4539.h:#undef DEBUG /* General debug */
include/configs/M5235EVB.h:#undef DEBUG
include/configs/M5271EVB.h:#undef DEBUG
include/configs/M5329EVB.h:#undef DEBUG
include/configs/M54455EVB.h:#undef DEBUG
include/configs/MPC8360ERDK.h:#undef DEBUG
include/configs/MPC8540EVAL.h:#undef DEBUG
include/configs/MVBLUE.h:#undef DEBUG

include/configs/QS823.h:#undef DEBUG                            /* debug output code */
include/configs/QS850.h:#undef DEBUG                            /* debug output code */
include/configs/QS860T.h:#undef DEBUG                           /* debug output code */

include/configs/Rattler.h:#undef DEBUG
include/configs/ads5121.h:#undef DEBUG
include/configs/assabet.h:#undef DEBUG
include/configs/ep8248.h:#undef DEBUG
include/configs/ep82xxm.h:#undef DEBUG
include/configs/gw8260.h:#undef DEBUG /* General debug */
include/configs/mpc7448hpc2.h:#undef DEBUG
include/configs/ms7722se.h:#undef DEBUG
include/configs/ms7750se.h:#undef DEBUG
include/configs/sacsng.h:#undef DEBUG /* General debug */
include/configs/sbc8260.h:#undef DEBUG /* General debug */
include/configs/sbc8349.h:#undef DEBUG

Kim

Liu Dave

2008-01-11 03:34 UTC #2 lore raw

PATCH 1/1 Remove #undef DEBUG from MPC83xx boardheader files

I suggest keep the debug option - #undef DEBUG.

Sometimes, if we need debug, it is easy to open the debug mode with the switch.

Thanks
Dave

Quoted 81 lines

-----Original Message-----
From: u-boot-users-bounces at lists.sourceforge.net [mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf Of Phillips Kim
Sent: 2008?1?11? 11:30 AM
To: Tabi Timur
Cc: u-boot-users at lists.sourceforge.net
Subject: Re: [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xx boardheader files
Quoted 1 line · On Wed, 9 Jan 2008 10:16:32 -0600 Timur Tabi <[email protected]> wrote:
Remove the "#undef DEBUG" line from all Freescale 83xx
board header files.
Quoted 1 line
The inclusion of this line makes it impossible to enable
debug code in
Quoted 1 line
other source files, because "#define DEBUG" typically needs
to be defined
Quoted 10 lines
before any header files are included.
Signed-off-by Timur Tabi <[email protected]>
---
 include/configs/MPC8323ERDB.h |    2 --
 include/configs/MPC832XEMDS.h |    2 --
 include/configs/MPC8349EMDS.h |    2 --
 include/configs/MPC8360EMDS.h |    2 --
 include/configs/MPC837XEMDS.h |    2 --
 5 files changed, 0 insertions(+), 10 deletions(-)
hmm..what about the rest of the boards that do this?:
include/configs/AP1000.h:#undef DEBUG include/configs/BAB7xx.h:#undef DEBUG include/configs/EB+MCF-EV123.h:#undef DEBUG include/configs/ELPPC.h:#undef DEBUG include/configs/IPHASE4539.h:#undef DEBUG
          /* General debug */
include/configs/M5235EVB.h:#undef DEBUG include/configs/M5271EVB.h:#undef DEBUG include/configs/M5329EVB.h:#undef DEBUG include/configs/M54455EVB.h:#undef DEBUG include/configs/MPC8360ERDK.h:#undef DEBUG include/configs/MPC8540EVAL.h:#undef DEBUG include/configs/MVBLUE.h:#undef DEBUG include/configs/QS823.h:#undef DEBUG
/* debug output code */
include/configs/QS850.h:#undef DEBUG
/* debug output code */
include/configs/QS860T.h:#undef DEBUG
/* debug output code */
include/configs/Rattler.h:#undef DEBUG include/configs/ads5121.h:#undef DEBUG include/configs/assabet.h:#undef DEBUG include/configs/ep8248.h:#undef DEBUG include/configs/ep82xxm.h:#undef DEBUG
include/configs/gw8260.h:#undef DEBUG /*
General debug */ include/configs/mpc7448hpc2.h:#undef DEBUG include/configs/ms7722se.h:#undef DEBUG include/configs/ms7750se.h:#undef DEBUG
include/configs/sacsng.h:#undef DEBUG /*
General debug */
include/configs/sbc8260.h:#undef DEBUG /*
General debug */ include/configs/sbc8349.h:#undef DEBUG
Kim
--------------------------------------------------------------
-----------
Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.n
et/marketplace
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Timur Tabi

author

2008-01-11 15:05 UTC #3 lore raw

PATCH 1/1 Remove #undef DEBUG from MPC83xx boardheader files

Quoted 4 lines · Liu Dave

I suggest keep the debug option - #undef DEBUG.
Sometimes, if we need debug, it is easy to open the debug mode with the switch.

I don't see how. The "#undef DEBUG" will override any #define DEBUG or -DDEBUG that you specify. The "#undef DEBUG" makes it impossible to use the debug() call or anything else like it.

Signature · 2 lines

Timur Tabi
Linux kernel developer at Freescale

Liu Dave

2008-01-12 02:06 UTC #4 lore raw

PATCH 1/1 Remove #undef DEBUG from MPC83xx boardheader files

Quoted 5 lines

I don't see how. The "#undef DEBUG" will override any #define DEBUG or -DDEBUG
that you specify. The "#undef DEBUG" makes it impossible to use the debug()
call or anything else like it.

Yes, the DEBUG is global, sometime it is my need.

Wolfgang Denk

2008-01-11 19:32 UTC #5 lore raw

PATCH 1/1 Remove #undef DEBUG from MPC83xx boardheader files

In reply to Liu Dave

Quoted 1 line · In message <58A20A281BAF1047B4EAE68DE5C0BDC2C0E189@zch01exm21.fsl.freescale.net…

I suggest keep the debug option - #undef DEBUG.

DEBUG is not defined by default, so this statement is redundant at best, harmful in some cases (when you try to enable debug globally).

Quoted 2 lines

Sometimes, if we need debug, it is easy to open the debug mode with the switch.

But you don't need the #undef DEBUG for that.

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Don't try to outweird me, three-eyes. I get stranger things than you
free with my breakfast cereal."
           - Zaphod Beeblebrox in  "Hitchhiker's Guide to the Galaxy"

Liu Dave

2008-01-12 02:16 UTC #6 lore raw

PATCH 1/1 Remove #undef DEBUG from MPC83xxboardheader files

Quoted 10 lines

Quoted 1 line
I suggest keep the debug option - #undef DEBUG.
DEBUG is not defined by default, so this statement is redundant at best, harmful in some cases (when you try to enable debug globally).
Quoted 2 lines
Sometimes, if we need debug, it is easy to open the debug mode with the switch.
But you don't need the #undef DEBUG for that.

Ok. Let us remove them.

Regards,
Dave

Timur Tabi

author

2008-01-11 15:06 UTC #7 lore raw

PATCH 1/1 Remove #undef DEBUG from MPC83xx board header files

In reply to Kim Phillips

Quoted 1 line · Kim Phillips

hmm..what about the rest of the boards that do this?:

Well, the 8360ERDK files weren't there when I submitted this patch. As for th rest, well, they're not Freescale files.

Signature · 2 lines

Timur Tabi
Linux kernel developer at Freescale