Skip to contentSkip to conversation

portability: configure top level dependencies per architecture

PATCH Applied Christian Ehrhardt 2 participants 2 messages Jan 10, 2008 – Jan 13, 2008 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 portability: configure top level dependencies per architecture

This includes the comments from Avi to "[PATCH] portability: add top level config-$arch files v2". Putting the arch dependencies into if's saves us 4 config-$arch files which are not essential to fix the current issue. Since this is copy&paste from Avis response to v2 I added him to the From list

changes to v2:
- remove config-$arch files
- put arch dep in if's checking the arch to add more dependencies to a target directly in the top level Makefile

---

Subject: [PATCH] portability: configure top level dependencies per architecture
From: Christian Ehrhardt <[email protected]>
From: Avi Kivity avi-atKUWr5tajBWk0Htik3J/[email protected]

This allows per arch configuration for the top level Makefile of kvm-userspace e.g. allowing to disable extboot for non x86 or disabling kvmctl build until ported to an architecture.

 Makefile |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)
Makefile +8 -2
@@ -7,14 +7,20 @@ rpmrelease = devel
 
 .PHONY: kernel user libkvm qemu bios vgabios extboot clean
 
-all: $(if $(WANT_MODULE), kernel) user libkvm qemu
+all: libkvm qemu
+ifneq '$(filter $(ARCH), x86_64 i386 ia64)' ''
+    all: $(if $(WANT_MODULE), kernel) user
+endif
 
 kcmd = $(if $(WANT_MODULE),,@\#)
 
 qemu kernel user libkvm:
 	$(MAKE) -C $@
 
-qemu: libkvm extboot
+qemu: libkvm
+ifneq '$(filter $(ARCH), i386 x86_64)' ''
+    qemu: extboot
+endif
 user: libkvm
 
 bios:

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

A message that is not in the archive (sent off-list or not yet received): 11999816351360-git-send-email-ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org

Applied
#2 lore raw
Quoted 11 lines · Christian Ehrhardt

This includes the comments from Avi to "[PATCH] portability: add top level config-$arch files v2". Putting the arch dependencies into if's saves us 4 config-$arch files which are not essential to fix the current issue. Since this is copy&paste from Avis response to v2 I added him to the From list

changes to v2:
- remove config-$arch files
- put arch dep in if's checking the arch to add more dependencies to a target directly in the top level Makefile

Applied, thanks.

Signature · 8 lines
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace