Skip to contentSkip to conversation

make nbd working in 2.5.x

PATCH Petr Vandrovec 2 participants 2 messages Mar 5, 2003

lore
Share & tools
lore
#0 lore raw
Quoted 30 lines · Jens Axboe
Quoted 9 lines · Petr Vandrovec

On 3 Mar 03 at 19:39, Pavel Machek wrote:

I think that at the beginning of 2.5.x series there was some thinking about removing end_that_request* completely from the API. As it never happened, and __end_that_request_first()/end_that_request_last() has definitely better quality (like that it does not ignore req->waiting...) than opencoded nbd loop, I prefer using end_that_request* over opencoding bio traversal.

Quoted 3 lines

If you want, then just replace blk_put_request() with __blk_put_request(), instead of first change. But I personally will not trust such code, as next time something in bio changes nbd will miss this change again.

I agree with the change, there's no reason for nbd to implement its own end_request handling. I was the one to do the bio conversion, doing XXX drivers at one time...

A small correction to your patch, you need not hold queue_lock when calling end_that_request_first() (which is the costly part of ending a request), so

    if (!end_that_request_first(req, uptodate, req->nr_sectors)) {
        unsigned long flags;

        spin_lock_irqsave(q->queue_lock, flags);
        end_that_request_last(req);
        spin_unlock_irqrestore(q->queue_lock, flags);
    }
Quoted 2 lines

would be enough. That depends on the driver having pulled the request off the list in the first place, which nbd has.

But it also finishes whole request at once, so probably with:

if (!end_that_request_first(...)) {
...
} else {
BUG();
}

I had patch for 2.5.3 which finished request partially after each chunk (usually 1500 bytes) received from server, but it did not make any difference in performance at that time (probably because of the way nbd server works and speed of network between server and client). I'll try it now again...
Petr Vandrovec [email protected]

#1 lore raw
Quoted 34 lines · Petr Vandrovec
Quoted 30 lines · Jens Axboe
Quoted 9 lines · Petr Vandrovec

On 3 Mar 03 at 19:39, Pavel Machek wrote:

I think that at the beginning of 2.5.x series there was some thinking about removing end_that_request* completely from the API. As it never happened, and __end_that_request_first()/end_that_request_last() has definitely better quality (like that it does not ignore req->waiting...) than opencoded nbd loop, I prefer using end_that_request* over opencoding bio traversal.

Quoted 3 lines

If you want, then just replace blk_put_request() with __blk_put_request(), instead of first change. But I personally will not trust such code, as next time something in bio changes nbd will miss this change again.

I agree with the change, there's no reason for nbd to implement its own end_request handling. I was the one to do the bio conversion, doing XXX drivers at one time...

A small correction to your patch, you need not hold queue_lock when calling end_that_request_first() (which is the costly part of ending a request), so

    if (!end_that_request_first(req, uptodate, req->nr_sectors)) {
        unsigned long flags;

        spin_lock_irqsave(q->queue_lock, flags);
        end_that_request_last(req);
        spin_unlock_irqrestore(q->queue_lock, flags);
    }
Quoted 2 lines

would be enough. That depends on the driver having pulled the request off the list in the first place, which nbd has.

Quoted 7 lines

But it also finishes whole request at once, so probably with:

if (!end_that_request_first(...)) { 
   ...
} else {

BUG();
}

Sure

Quoted 5 lines

I had patch for 2.5.3 which finished request partially after each chunk (usually 1500 bytes) received from server, but it did not make any difference in performance at that time (probably because of the way nbd server works and speed of network between server and client). I'll try it now again...

Yes that might still make sense, especially now since we actually pass down partially completed chunks. But the bio end_io must support it, or you will see now difference at all. And I don't think any of them do :). Linus played with adding it to the multi-page fs helpers, but I think he abandoned it. Should make larger read-aheads on slow media (floppy) work a lot nicer, though.

Signature · 1 line
Jens Axboe