RDMA/vmw_pvrdma: Disable device before releasing PCI region
A message that is not in the archive (sent off-list or not yet received): [email protected]
Adit Ranadive
Acked-byQuoted 18 lines · On 2/3/20 10:36 AM, "Yuval Shaia yuval.shaia.ml"@gmail.com wrote:
From: Yuval Shaia <[email protected]>
From
Documentation/PCI/pci.tx.txt:
Drivers should callpci_release_region()after callingpci_disable_device()in order to prevent two devices colliding on the same address range.Signed-off-by Yuval Shaia <[email protected]>--- drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c +0
-0
drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c static void pvrdma_pci_remove(struct pci_dev *pdev) · line 1144
Quoted 9 lines
drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c +1
-1@@ -1137,8 +1137,8 @@ static void pvrdma_pci_remove(struct pci_dev *pdev)ib_dealloc_device (&dev->ib_dev);/* Free pci resources */ -pci_release_regions (pdev);pci_disable_device (pdev); +pci_release_regions (pdev);pci_set_drvdata (pdev,NULL ); }
Looks fine to me. Please add a Fixes tag and cc stable.
Acked-by Adit Ranadive <[email protected]>