drm/amd: Replace ttm_bo_reference with ttm_bo_get
Subsystems (2)
PATCH 1/2 drm/amd: Replace ttm_bo_reference with ttm_bo_get
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +1 -1
@@ -823,7 +823,7 @@ struct amdgpu_bo *amdgpu_bo_ref(struct amdgpu_bo *bo)if (bo ==NULL )return NULL ; -ttm_bo_reference (&bo->tbo); +ttm_bo_get (&bo->tbo);return bo; }
Signature · 6 lines
2.18.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 2/2 Replace ttm_bo_unref with ttm_bo_put
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put.
A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. This is not necessary in most cases and sometimes even worked around by the calling code. A call to ttm_bo_put only releases the reference without clearing the pointer.
The current behaviour of cleaning the pointer is kept in the calling code, but should be removed if not required in a later patch.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +2 -3
@@ -841,9 +841,8 @@ void amdgpu_bo_unref(struct amdgpu_bo **bo)return ; tbo = &((*bo)->tbo); -ttm_bo_unref (&tbo); -if (tbo ==NULL ) - *bo =NULL ; +ttm_bo_put (tbo); + *bo =NULL ; }/**
Signature · 6 lines
2.18.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
A message that is not in the archive (sent off-list or not yet received): [email protected]
Am 31.07.2018 um 08:11 schrieb Thomas Zimmermann:
Quoted 5 lines
The function
ttm_bo_getacquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function_getand_put.Signed-off-by Thomas Zimmermann <[email protected]>
amdgpu patches should actually have the prefix "drm/amdgpu", but not a major issue. I'm going to clean that up before pushing.
Apart from that this series as well as the radeon series are Reviewed-by: Christian König <[email protected]> and I will pick them up for upstreaming later today.
Thanks for the help,
Christian.
Quoted 9 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c struct amdgpu_bo *amdgpu_bo_ref(struct amdgpu_bo *bo) · line 829
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +1
-1@@ -823,7 +823,7 @@ struct amdgpu_bo *amdgpu_bo_ref(struct amdgpu_bo *bo)if (bo ==NULL )return NULL ; -ttm_bo_reference (&bo->tbo); +ttm_bo_get (&bo->tbo);return bo; }
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx