dt-bindings: adc: add AD7173
Subsystems (4)
PATCH v7 1/2 dt-bindings: adc: add AD7173
The AD7173 family offer a complete integrated Sigma-Delta ADC solution which can be used in high precision, low noise single channel applications or higher speed multiplexed applications. The Sigma-Delta ADC is intended primarily for measurement of signals close to DC but also delivers outstanding performance with input bandwidths out to ~10kHz.
--- .../bindings/iio/adc/adi,ad7173.yaml | 170 ++++++++++++++++++ 1 file changed, 170 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml new file +170 -0
@@ -0,0 +1,170 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2023 Analog Devices Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/adi,ad7173.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AD7173 ADC + +maintainers: + - Ceclan Dumitru <[email protected]> + +description: | + Bindings for the Analog Devices AD717X ADC's. Datasheets for supported chips: + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7172-2.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7173-8.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7175-2.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7176-2.pdf + +properties: + compatible: + enum: + - adi,ad7172-2 + - adi,ad7173-8 + - adi,ad7175-2 + - adi,ad7176-2 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + spi-max-frequency: + maximum: 20000000 + + refin-supply: + description: external reference supply, can be used as reference for conversion. + + refin2-supply: + description: external reference supply, can be used as reference for conversion. + + avdd-supply: + description: avdd supply, can be used as reference for conversion. + + required: + - compatible + - reg + - interrupts + +patternProperties: + "^channel@[0-9a-f]$": + type: object + $ref: adc.yaml + unevaluatedProperties: false + + properties: + reg: + minimum: 0 + maximum: 15 + + diff-channels: + items: + minimum: 0 + maximum: 31 + + adi,reference-select: + description: | + Select the reference source to use when converting on + the specific channel. Valid values are: + refin : REFIN(+)/REFIN(−). + refin2 : REFIN2(+)/REFIN2(−) + refout-avss: REFOUT/AVSS (Internal reference) + avdd : AVDD + + External reference refin2 only available on ad7173-8. + If not specified, internal reference used. + enum: + - refin + - refin2 + - refout-avss + - avdd + default: refout-avss + + required: + - reg + - diff-channels + +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + + - if: + properties: + compatible: + not: + contains: + const: adi,ad7173-8 + then: + properties: + refin2-supply: false + patternProperties: + "^channel@[0-9a-f]$": + properties: + adi,reference-select: + enum: + - refin + - refout-avss + - avdd + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + + spi { + #address-cells = <1>; + #size-cells = <0>; + + adc@0 { + compatible = "adi,ad7173-8"; + reg = <0>; + + #address-cells = <1>; + #size-cells = <0>; + + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; + interrupt-parent = <&gpio>; + spi-max-frequency = <5000000>; + + refin-supply = <&dummy_regulator>; + + channel@0 { + reg = <0>; + bipolar; + diff-channels = <0 1>; + adi,reference-select = "refin"; + }; + + channel@1 { + reg = <1>; + diff-channels = <2 3>; + }; + + channel@2 { + reg = <2>; + bipolar; + diff-channels = <4 5>; + }; + + channel@3 { + reg = <3>; + bipolar; + diff-channels = <6 7>; + }; + + channel@4 { + reg = <4>; + diff-channels = <8 9>; + adi,reference-select = "avdd"; + }; + }; + };
Signature · 1 line
2.42.0
PATCH v7 2/2 iio: adc: ad7173: add AD7173 driver
The AD7173 family offer a complete integrated Sigma-Delta ADC solution which can be used in high precision, low noise single channel applications or higher speed multiplexed applications. The Sigma-Delta ADC is intended primarily for measurement of signals close to DC but also delivers outstanding performance with input bandwidths out to ~10kHz.
--- drivers/iio/adc/Kconfig | 17 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/ad7173.c | 967 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 985 insertions(+) create mode 100644 drivers/iio/adc/ad7173.c
drivers/iio/adc/Kconfig +17 -0
@@ -54,6 +54,23 @@ config AD7124 To compile this driver as a module, choose M here: the module will be called ad7124. +config AD7173 + tristate "Analog Devices AD7173 driver" + depends on SPI_MASTER + select AD_SIGMA_DELTA + select GPIO_REGMAP if GPIOLIB + select REGMAP_SPI if GPIOLIB + help + Say yes here to build support for Analog Devices AD7173 and similar ADC + Currently supported models: + - AD7172-2, + - AD7173-8, + - AD7175-2, + - AD7176-2 + + To compile this driver as a module, choose M here: the module will be + called ad7173. + config AD7192 tristate "Analog Devices AD7190 AD7192 AD7193 AD7195 ADC driver" depends on SPI
drivers/iio/adc/Makefile +1 -0
@@ -9,6 +9,7 @@ obj-$(CONFIG_AD_SIGMA_DELTA) += ad_sigma_delta.o obj-$(CONFIG_AD4130) += ad4130.o obj-$(CONFIG_AD7091R5) += ad7091r5.o ad7091r-base.o obj-$(CONFIG_AD7124) += ad7124.o +obj-$(CONFIG_AD7173) += ad7173.o obj-$(CONFIG_AD7192) += ad7192.o obj-$(CONFIG_AD7266) += ad7266.o obj-$(CONFIG_AD7280) += ad7280a.o
drivers/iio/adc/ad7173.c new file +967 -0
967 lines not on this page · raw message
Signature · 1 line
2.42.0
Re: [PATCH v7 2/2] iio: adc: ad7173: add AD7173 driver
Quoted 6 lines · Dumitru Ceclan
The AD7173 family offer a complete integrated Sigma-Delta ADC solution which can be used in high precision, low noise single channel applications or higher speed multiplexed applications. The Sigma-Delta ADC is intended primarily for measurement of signals close to DC but also delivers outstanding performance with input bandwidths out to ~10kHz.
V6 -> V7
- format Kconfig supported models using '-'
- include types.h instead of stddef.h
- change device_info->num_gpios type to u8
- reorder fields in ad7173_state, place ad_sigma_delta
- reorder fields in ad7173_device_info, group by type
- add default case in read_raw()
- rename ad7173_debug() to ad7173_debug_reg_access()
- remove explicit u8 cast
- remove return 0; for offset in read_raw()
- add '\n' to error messages
- reorder probe variables -> reversed xmas tree
- remove redundant inner commas in of_match and id_table
- simplify selected reference code by setting default value and
ignoring fwnode_property_read_string() error
- use match_string() for finding selected reference
- err on no channels specified
- add missing fwnode_handle_put(child) on err return branches
- remove spi_set_drvdata() from probe
- remove offset variable from find_live_config(), not used
- add comment showing a generic LRU implementation might be used if one
will exist
- MISC: add blank line to chanel_config struct, trailing comma
ref_sel_str[],
remove blank line in update_scan_mode(), add spaces around '/'
Re: [PATCH v7 2/2] iio: adc: ad7173: add AD7173 driver
In reply to Dumitru CeclanQuoted 6 lines · Dumitru Ceclan
The AD7173 family offer a complete integrated Sigma-Delta ADC solution which can be used in high precision, low noise single channel applications or higher speed multiplexed applications. The Sigma-Delta ADC is intended primarily for measurement of signals close to DC but also delivers outstanding performance with input bandwidths out to ~10kHz.
...
drivers/iio/adc/Kconfig config AD7124 · line 69
Quoted 13 lines
drivers/iio/adc/Kconfig +13
-0+config AD7173 + tristate "Analog Devices AD7173 driver" + depends on SPI_MASTER + select AD_SIGMA_DELTA + select GPIO_REGMAP if GPIOLIB + select REGMAP_SPI if GPIOLIB + help + Say yes here to build support for Analog Devices AD7173 and similar ADC + Currently supported models: + - AD7172-2, + - AD7173-8, + - AD7175-2, + - AD7176-2
Drop commas (sorry if I was not clear enough).
drivers/iio/adc/ad7173.c line 14
Quoted 9 lines
drivers/iio/adc/ad7173.c new file +8
-0+#include <linux/array_size.h> +#include <linux/bitfield.h> +#include <linux/bitmap.h> +#include <linux/container_of.h> +#include <linux/delay.h> +#include <linux/device.h> +#include <linux/err.h> +#include <linux/gpio/driver.h>
This...
drivers/iio/adc/ad7173.c line 21
Quoted 8 lines
drivers/iio/adc/ad7173.c new file +7
-0+#include <linux/idr.h> +#include <linux/interrupt.h> +#include <linux/module.h> +#include <linux/mod_devicetable.h> +#include <linux/property.h> +#include <linux/regmap.h> +#include <linux/gpio/regmap.h>
...and this are too far from each other. I believe you should count on G order.
Quoted 5 lines
drivers/iio/adc/ad7173.c new file +5
-0+#include <linux/regulator/consumer.h> +#include <linux/slab.h> +#include <linux/spi/spi.h> +#include <linux/types.h> +#include <linux/units.h>
...
Quoted 1 line
+#define
AD7173_GPO12_DATA(x)BIT(x)
x + 0 ?
Quoted 2 lines
drivers/iio/adc/ad7173.c new file +2
-0+#define AD7173_GPO23_DATA (x) BIT(x + 4) +#define AD7173_GPO_DATA (x) (x < 2 ? AD7173_GPO12_DATA(x) : AD7173_GPO23_DATA(x))
...
Quoted 1 line
+ dev_warn(&st->sd.spi->dev,
Here...
drivers/iio/adc/ad7173.c line 518
Quoted 8 lines
drivers/iio/adc/ad7173.c new file +8
-0+"Unexpected device id: 0x%04X, expected: 0x%04X\n" , + id, st->info->id); + + st->adc_mode |=AD7173_ADC_MODE_SING_CYC ; + st->interface_mode =0x0 ; + + st->config_usage_counter =0 ; + st->config_cnts = devm_kcalloc(indio_dev->dev.parent,
...and here are different pointers in use, can you unify to use the physical device pointer (as per above) here as well?
Quoted 4 lines
drivers/iio/adc/ad7173.c new file +4
-0+ st->info->num_configs,sizeof (u64), + GFP_KERNEL); +if (!st->config_cnts) +return -ENOMEM ;
...
drivers/iio/adc/ad7173.c line 583
Quoted 3 lines
drivers/iio/adc/ad7173.c new file +3
-0+case IIO_CHAN_INFO_SCALE : +if (chan->type ==IIO_TEMP ) { + *val =250000000 ;
MEGA?
Quoted 1 line
+ *val2 = 800273203; /* (2^24 * 477) / 10 */
Why not write it as is:
*val2 = (BIT(24) * 477) / 10;
?
It will be more robust as we don't expect compiler to give different results here
Quoted 6 lines
drivers/iio/adc/ad7173.c new file +6
-0+return IIO_VAL_FRACTIONAL ; + }else { + *val =ad7173_get_ref_voltage_milli (st, ch->cfg.ref_sel); + *val2 = chan->scan_type.realbits - !!(ch->cfg.bipolar); +return IIO_VAL_FRACTIONAL_LOG2 ; + }
...
drivers/iio/adc/ad7173.c line 757
Quoted 5 lines
drivers/iio/adc/ad7173.c new file +5
-0+/* If a regulator is not available, it will be set to a dummy regulator. +* Each channel reference is checked with regulator_get_voltage() before +* setting attributes so if any channel uses a dummy supply the driver +* probe will fail. +*/
/*
* Multi-line comments should follow this style. Find the
* difference.
*/
...
drivers/iio/adc/ad7173.c line 833
Quoted 7 lines
drivers/iio/adc/ad7173.c new file +7
-0+ ref_label = ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_INT_REF ]; + +fwnode_property_read_string (child,"adi,reference-select" , + &ref_label); + ref_sel =match_string (ad7173_ref_sel_str, +ARRAY_SIZE (ad7173_ref_sel_str), ref_label); +if (ref_sel <0 ) {
Can we use fwnode_property_match_property_string()?
Quoted 5 lines
drivers/iio/adc/ad7173.c new file +5
-0+fwnode_handle_put (child); +return dev_err_probe (dev, -EINVAL , +"Invalid channel reference name %s\n" , + ref_label); + }
Signature · 2 lines
With Best Regards, Andy Shevchenko
Andy Shevchenko
reviewerRe: [PATCH v7 2/2] iio: adc: ad7173: add AD7173 driver
Quoted 1 line · Andy Shevchenko
On Tue, Dec 5, 2023 at 3:46 PM Dumitru Ceclan <[email protected]> wrote:
...
Quoted 5 lines
drivers/iio/adc/ad7173.c line 583
Quoted 3 lines
drivers/iio/adc/ad7173.c new file +3
-0+case IIO_CHAN_INFO_SCALE : +if (chan->type ==IIO_TEMP ) { + *val =250000000 ;MEGA?
Or MICRO?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v7 2/2] iio: adc: ad7173: add AD7173 driver
In reply to Andy ShevchenkoQuoted 8 lines · Andy Shevchenko
drivers/iio/adc/ad7173.c line 833
Quoted 7 lines
drivers/iio/adc/ad7173.c new file +7
-0+ ref_label = ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_INT_REF ]; + +fwnode_property_read_string (child,"adi,reference-select" , + &ref_label); + ref_sel =match_string (ad7173_ref_sel_str, +ARRAY_SIZE (ad7173_ref_sel_str), ref_label); +if (ref_sel <0 ) {Can we use
fwnode_property_match_property_string()?
fwnode_property_match_string() searches a given string in a device-tree string array and returns the index. I do not think that this function fits here as the DT attribute is a single string.
Re: [PATCH v7 2/2] iio: adc: ad7173: add AD7173 driver
Quoted 8 lines · Ceclan Dumitru
Quoted 7 lines · Andy Shevchenko
Quoted 7 lines
drivers/iio/adc/ad7173.c new file +7
-0+ ref_label = ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_INT_REF ]; + +fwnode_property_read_string (child,"adi,reference-select" , + &ref_label); + ref_sel =match_string (ad7173_ref_sel_str, +ARRAY_SIZE (ad7173_ref_sel_str), ref_label); +if (ref_sel <0 ) {
Quoted 5 lines
Quoted 1 line
Can we use
fwnode_property_match_property_string()?
fwnode_property_match_string()searches a given string in a device-tree string array and returns the index. I do not think that this function fits here as the DT attribute is a single string.
I'm not talking about that. I mentioned different API call.
/**
* fwnode_property_match_property_string - find a property string value in an array and return index
* @fwnode: Firmware node to get the property of
* @propname: Name of the property holding the string value
* @array: String array to search in
* @n: Size of the @array
*
* Find a property string value in a given @array and if it is found return
* the index back.
*
* Return: index, starting from %0, if the string value was found in the @array (success),
* %-ENOENT when the string value was not found in the @array, * %-EINVAL if given arguments are not valid, * %-ENODATA if the property does not have a value, * %-EPROTO or %-EILSEQ if the property is not a string, * %-ENXIO if no suitable firmware interface is present.
*/
Signature · 2 lines
With Best Regards, Andy Shevchenko
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH v7 2/2] iio: adc: ad7173: add AD7173 driver
Quoted 34 lines · Andy Shevchenko
Quoted 9 lines · Ceclan Dumitru
Quoted 8 lines · Andy Shevchenko
Quoted 8 lines
drivers/iio/adc/ad7173.c new file +8
-0+ ref_label = + ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_INT_REF ]; + +fwnode_property_read_string (child,"adi,reference-select" , + &ref_label); + ref_sel =match_string (ad7173_ref_sel_str, +ARRAY_SIZE (ad7173_ref_sel_str), ref_label); +if (ref_sel <0 ) {Quoted 5 lines
Quoted 1 line
Can we use
fwnode_property_match_property_string()?
fwnode_property_match_string()searches a given string in a device-tree string array and returns the index. I do not think that this function fits here as the DT attribute is a single string.I'm not talking about that. I mentioned different API call.
/**
*fwnode_property_match_property_string- find a property string value in an array and return index
* @fwnode: Firmware node to get the property of
* @propname: Name of the property holding the string value
* @array: String array to search in
* @n: Size of the @array
*
* Find a property string value in a given @array and if it is found return
* the index back.
*
* Return: index, starting from %0, if the string value was found in the @array (success),* %-ENOENT when the string value was not found in the @array, * %-EINVAL if given arguments are not valid, * %-ENODATA if the property does not have a value, * %-EPROTO or %-EILSEQ if the property is not a string, * %-ENXIO if no suitable firmware interface is present.
Quoted 7 lines
*/
--
With Best Regards,
Andy Shevchenko
Yep, it can be used. I cannot seem to find it upstream but found the thread, when the patch containing that function will be applied I'll change to that.
Jonathan Cameron
maintainerRe: [PATCH v7 2/2] iio: adc: ad7173: add AD7173 driver
In reply to Andy ShevchenkoQuoted 28 lines · On Tue, 5 Dec 2023 19:18:12 +0200 Andy Shevchenko <[email protected]>…
Quoted 8 lines · Ceclan Dumitru
Quoted 7 lines · Andy Shevchenko
Quoted 7 lines
drivers/iio/adc/ad7173.c new file +7
-0+ ref_label = ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_INT_REF ]; + +fwnode_property_read_string (child,"adi,reference-select" , + &ref_label); + ref_sel =match_string (ad7173_ref_sel_str, +ARRAY_SIZE (ad7173_ref_sel_str), ref_label); +if (ref_sel <0 ) {Quoted 5 lines
Quoted 1 line
Can we use
fwnode_property_match_property_string()?
fwnode_property_match_string()searches a given string in a device-tree string array and returns the index. I do not think that this function fits here as the DT attribute is a single string.I'm not talking about that. I mentioned different API call.
/**
*fwnode_property_match_property_string- find a property string value in an array and return index
* @fwnode: Firmware node to get the property of
* @propname: Name of the property holding the string value
* @array: String array to search in
* @n: Size of the @array
*
* Find a property string value in a given @array and if it is found return
* the index back.
*
* Return: index, starting from %0, if the string value was found in the @array (success),
Quoted 7 lines
* %-ENOENT when the string value was not found in the @array, * %-EINVAL if given arguments are not valid, * %-ENODATA if the property does not have a value, * %-EPROTO or %-EILSEQ if the property is not a string, * %-ENXIO if no suitable firmware interface is present.*/
Which is in the togreg branch of iio.git (was a patch from Andy that I've queued up)
Jonathan
kernel test robot
build botRe: [PATCH v7 2/2] iio: adc: ad7173: add AD7173 driver
In reply to Dumitru Ceclankernel test robot noticed the following build warnings:
Hi Dumitru,
kernel test robot noticed the following build warnings:
[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v6.7-rc4 next-20231206] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Dumitru-Ceclan/iio-adc-ad7173-add-AD7173-driver/20231205-214833 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg patch link: https://lore.kernel.org/r/20231205134223.17335-2-mitrutzceclan%40gmail.com patch subject: [PATCH v7 2/2] iio: adc: ad7173: add AD7173 driver config: m68k-randconfig-r071-20231207 (https://download.01.org/0day-ci/archive/20231207/[email protected]/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20231207/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
smatch warnings:drivers/iio/adc/ad7173.c:833 ad7173_fw_parse_channel_config() warn: unsigned 'ref_sel' is never less than zero.
vim +/ref_sel +833 drivers/iio/adc/ad7173.c
735
736 static int ad7173_fw_parse_channel_config(struct iio_dev *indio_dev)
737 {
738 struct ad7173_channel *channels_st_priv_arr, *chan_st_priv;
739 struct ad7173_state *st = iio_priv(indio_dev);
740 struct device *dev = indio_dev->dev.parent;
741 struct iio_chan_spec *chan_arr, *chan;
742 struct fwnode_handle *child;
743 unsigned int ain[2], chan_index = 0;
744 unsigned int num_channels;
745 const char *ref_label;
746 u32 ref_sel;
747 int ret;
748
749 st->regulators[0].supply = ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_EXT_REF];
750 st->regulators[1].supply = ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_EXT_REF2];
751 st->regulators[2].supply = ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_AVDD1_AVSS];
752
753 /* If a regulator is not available, it will be set to a dummy regulator.
754 * Each channel reference is checked with regulator_get_voltage() before
755 * setting attributes so if any channel uses a dummy supply the driver
756 * probe will fail.
757 */
758 ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(st->regulators),
759 st->regulators);
760 if (ret)
761 return dev_err_probe(dev, ret, "Failed to get regulators\n");
762
763 ret = regulator_bulk_enable(ARRAY_SIZE(st->regulators), st->regulators);
764 if (ret)
765 return dev_err_probe(dev, ret, "Failed to enable regulators\n");
766
767 ret = devm_add_action_or_reset(dev, ad7173_disable_regulators, st);
768 if (ret)
769 return dev_err_probe(dev, ret,
770 "Failed to add regulators disable action\n");
771
772 num_channels = device_get_child_node_count(dev);
773
774 if (st->info->has_temp)
775 num_channels++;
776
777 if (num_channels == 0)
778 return dev_err_probe(dev, -EINVAL, "No channels specified\n");
779 st->num_channels = num_channels;
780
781 chan_arr = devm_kcalloc(dev, sizeof(*chan_arr), num_channels, GFP_KERNEL);
782 if (!chan_arr)
783 return -ENOMEM;
784
785 channels_st_priv_arr = devm_kcalloc(dev, num_channels,
786 sizeof(*channels_st_priv_arr),
787 GFP_KERNEL);
788 if (!channels_st_priv_arr)
789 return -ENOMEM;
790
791 indio_dev->channels = chan_arr;
792 indio_dev->num_channels = num_channels;
793 st->channels = channels_st_priv_arr;
794
795 if (st->info->has_temp) {
796 chan_arr[chan_index] = ad7173_temp_iio_channel_template;
797 chan_st_priv = &channels_st_priv_arr[chan_index];
798 chan_st_priv->ain =
799 AD7173_CH_ADDRESS(chan_arr[chan_index].channel, chan_arr[chan_index].channel2);
800 chan_st_priv->cfg.bipolar = false;
801 chan_st_priv->cfg.input_buf = true;
802 chan_st_priv->cfg.ref_sel = AD7173_SETUP_REF_SEL_INT_REF;
803 st->adc_mode |= AD7173_ADC_MODE_REF_EN;
804
805 chan_index++;
806 }
807
808 device_for_each_child_node(dev, child) {
809 chan = &chan_arr[chan_index];
810 chan_st_priv = &channels_st_priv_arr[chan_index];
811 ret = fwnode_property_read_u32_array(child, "diff-channels",
812 ain, ARRAY_SIZE(ain));
813 if (ret) {
814 fwnode_handle_put(child);
815 return ret;
816 }
817
818 if (ain[0] >= st->info->num_inputs ||
819 ain[1] >= st->info->num_inputs) {
820 fwnode_handle_put(child);
821 return dev_err_probe(dev, -EINVAL,
822 "Input pin number out of range for pair (%d %d).\n",
823 ain[0], ain[1]);
824 }
825
826 ref_sel = AD7173_SETUP_REF_SEL_INT_REF;
827 ref_label = ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_INT_REF];
828
829 fwnode_property_read_string(child, "adi,reference-select",
830 &ref_label);
831 ref_sel = match_string(ad7173_ref_sel_str,
832 ARRAY_SIZE(ad7173_ref_sel_str), ref_label);
> 833 if (ref_sel < 0) { 834 fwnode_handle_put(child);
835 return dev_err_probe(dev, -EINVAL,
836 "Invalid channel reference name %s\n",
837 ref_label);
838 }
839
840 if (ref_sel == AD7173_SETUP_REF_SEL_EXT_REF2 &&
841 st->info->id != AD7173_ID) {
842 fwnode_handle_put(child);
843 return dev_err_probe(dev, -EINVAL, "External reference 2 is only available on ad7173-8\n");
844 }
845
846 ret = ad7173_get_ref_voltage_milli(st, ref_sel);
847 if (ret < 0) {
848 fwnode_handle_put(child);
849 return dev_err_probe(dev, ret,
850 "Cannot use reference %u\n", ref_sel);
851 }
852 if (ref_sel == AD7173_SETUP_REF_SEL_INT_REF)
853 st->adc_mode |= AD7173_ADC_MODE_REF_EN;
854 chan_st_priv->cfg.ref_sel = ref_sel;
855
856 *chan = ad7173_channel_template;
857 chan->address = chan_index;
858 chan->scan_index = chan_index;
859 chan->channel = ain[0];
860 chan->channel2 = ain[1];
861 chan->differential = true;
862
863 chan_st_priv->ain = AD7173_CH_ADDRESS(ain[0], ain[1]);
864 chan_st_priv->chan_reg = chan_index;
865 chan_st_priv->cfg.input_buf = true;
866 chan_st_priv->cfg.odr = 0;
867
868 chan_st_priv->cfg.bipolar = fwnode_property_read_bool(child, "bipolar");
869 if (chan_st_priv->cfg.bipolar)
870 chan->info_mask_separate |= BIT(IIO_CHAN_INFO_OFFSET);
871
872 chan_index++;
873 }
874
875 return 0;
876 }
877
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Quoted 6 lines · Dumitru Ceclan
The AD7173 family offer a complete integrated Sigma-Delta ADC solution which can be used in high precision, low noise single channel applications or higher speed multiplexed applications. The Sigma-Delta ADC is intended primarily for measurement of signals close to DC but also delivers outstanding performance with input bandwidths out to ~10kHz.
Bindings V6 -> V7
- remove redundant bipolar attribute
- add reference-select example
Rob Herring
maintainerQuoted 6 lines · Dumitru Ceclan
The AD7173 family offer a complete integrated Sigma-Delta ADC solution which can be used in high precision, low noise single channel applications or higher speed multiplexed applications. The Sigma-Delta ADC is intended primarily for measurement of signals close to DC but also delivers outstanding performance with input bandwidths out to ~10kHz.
Quoted 6 lines
Signed-off-by Dumitru Ceclan <[email protected]>--- .../bindings/iio/adc/adi,ad7173.yaml | 170 ++++++++++++++++++ 1 file changed, 170 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml: properties:required: ['compatible', 'reg', 'interrupts'] is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml: properties: 'required' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'}
hint: A json-schema keyword was found instead of a DT property name.
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml: properties:required: ['compatible', 'reg', 'interrupts'] is not of type 'object', 'boolean'
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Quoted 64 lines · Dumitru Ceclan
The AD7173 family offer a complete integrated Sigma-Delta ADC solution which can be used in high precision, low noise single channel applications or higher speed multiplexed applications. The Sigma-Delta ADC is intended primarily for measurement of signals close to DC but also delivers outstanding performance with input bandwidths out to ~10kHz.
Signed-off-by Dumitru Ceclan <[email protected]>--- .../bindings/iio/adc/adi,ad7173.yaml | 170 ++++++++++++++++++ 1 file changed, 170 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7173.yamlDocumentation/devicetree/bindings/iio/adc/adi,ad7173.yaml new file +46
-0@@ -0,0 +1,170 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2023 Analog Devices Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/adi,ad7173.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AD7173 ADC + +maintainers: + - Ceclan Dumitru <[email protected]> + +description: | + Bindings for the Analog Devices AD717X ADC's. Datasheets for supported chips: + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7172-2.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7173-8.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7175-2.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7176-2.pdf + +properties: + compatible: + enum: + - adi,ad7172-2 + - adi,ad7173-8 + - adi,ad7175-2 + - adi,ad7176-2 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + spi-max-frequency: + maximum: 20000000 + + refin-supply: + description: external reference supply, can be used as reference for conversion. + + refin2-supply:
Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml line 55
Quoted 10 lines
Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml new file +9
-0+ description: external reference supply, can be used as reference for conversion. + + avdd-supply: + description: avdd supply, can be used as reference for conversion. + + required: + - compatible + - reg + - interrupts
This is at the wrong level of indent (as Rob's bot pointed out) and should come after patternProperties too.
Otherwise, this looks okay to me.
Thanks,
Conor.
Quoted 7 lines · Conor Dooley
Quoted 6 lines · Dumitru Ceclan
The AD7173 family offer a complete integrated Sigma-Delta ADC solution which can be used in high precision, low noise single channel applications or higher speed multiplexed applications. The Sigma-Delta ADC is intended primarily for measurement of signals close to DC but also delivers outstanding performance with input bandwidths out to ~10kHz.
...
Quoted 8 lines
Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml line 55
Quoted 4 lines
Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml new file +4
-0+ required: + - compatible + - reg + - interruptsThis is at the wrong level of indent (as Rob's bot pointed out) and should come after patternProperties too.
Yep, it was fixed in V6, forgot to include it