cxl: Remove always true condition for cxlctl_validate_hw_command()
Dave Jiang
maintainerPATCH 1/1 cxl: Remove always true condition for cxlctl_validate_hw_command()
smatch warnings:drivers/cxl/core/features.c:441 cxlctl_validate_hw_command() warn: always true condition '(scope >= 0) => (0-u32max >= 0)'
Remove the check entirely as it has no effect. Expectation is both of these operations should be allowed for all check levels. They are read only and have no change effects.
--- drivers/cxl/core/features.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/cxl/core/features.c +1 -5
@@ -614,11 +614,7 @@ static bool cxlctl_validate_hw_command(struct cxl_features_state *cxlfs,switch (opcode) {case CXL_MBOX_OP_GET_SUPPORTED_FEATURES :case CXL_MBOX_OP_GET_FEATURE : -if (cxl_mbox->feat_cap <CXL_FEATURES_RO ) -return false; -if (scope >=FWCTL_RPC_CONFIGURATION ) -return true; -return false; +return cxl_mbox->feat_cap >=CXL_FEATURES_RO ;case CXL_MBOX_OP_SET_FEATURE :if (cxl_mbox->feat_cap <CXL_FEATURES_RW )return false;
Signature · 1 line
2.49.0
Quoted 10 lines · On Fri, 4 Apr 2025 09:54:18 -0700 Dave Jiang <[email protected]> wrote:
smatch warnings:
drivers/cxl/core/features.c:441cxlctl_validate_hw_command()warn: always true condition '(scope >= 0) => (0-u32max >= 0)'Remove the check entirely as it has no effect. Expectation is both of these operations should be allowed for all check levels. They are read only and have no change effects.
Reported-by kernel test robot <[email protected]>Signed-off-by Dave Jiang <[email protected]>
Quoted 21 lines
--- drivers/cxl/core/features.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)drivers/cxl/core/features.c +1
-5@@ -614,11 +614,7 @@ static bool cxlctl_validate_hw_command(struct cxl_features_state *cxlfs,switch (opcode) {case CXL_MBOX_OP_GET_SUPPORTED_FEATURES :case CXL_MBOX_OP_GET_FEATURE : -if (cxl_mbox->feat_cap <CXL_FEATURES_RO ) -return false; -if (scope >=FWCTL_RPC_CONFIGURATION ) -return true; -return false; +return cxl_mbox->feat_cap >=CXL_FEATURES_RO ;case CXL_MBOX_OP_SET_FEATURE :if (cxl_mbox->feat_cap <CXL_FEATURES_RW )return false;
Quoted 10 lines · Dave Jiang
smatch warnings:
drivers/cxl/core/features.c:441cxlctl_validate_hw_command()warn: always true condition '(scope >= 0) => (0-u32max >= 0)'Remove the check entirely as it has no effect. Expectation is both of these operations should be allowed for all check levels. They are read only and have no change effects.
Reported-by kernel test robot <[email protected]>Signed-off-by Dave Jiang <[email protected]>
[snip]
Quoted 10 lines · Dave Jiang
smatch warnings:
drivers/cxl/core/features.c:441cxlctl_validate_hw_command()warn: always true condition '(scope >= 0) => (0-u32max >= 0)'Remove the check entirely as it has no effect. Expectation is both of these operations should be allowed for all check levels. They are read only and have no change effects.
Reported-by kernel test robot <[email protected]>Signed-off-by Dave Jiang <[email protected]>
Quoted 10 lines · Dave Jiang
smatch warnings:
drivers/cxl/core/features.c:441cxlctl_validate_hw_command()warn: always true condition '(scope >= 0) => (0-u32max >= 0)'Remove the check entirely as it has no effect. Expectation is both of these operations should be allowed for all check levels. They are read only and have no change effects.
Reported-by kernel test robot <[email protected]>Signed-off-by Dave Jiang <[email protected]>
Applied to cxl/next
Quoted 21 lines
--- drivers/cxl/core/features.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)drivers/cxl/core/features.c +1
-5@@ -614,11 +614,7 @@ static bool cxlctl_validate_hw_command(struct cxl_features_state *cxlfs,switch (opcode) {case CXL_MBOX_OP_GET_SUPPORTED_FEATURES :case CXL_MBOX_OP_GET_FEATURE : -if (cxl_mbox->feat_cap <CXL_FEATURES_RO ) -return false; -if (scope >=FWCTL_RPC_CONFIGURATION ) -return true; -return false; +return cxl_mbox->feat_cap >=CXL_FEATURES_RO ;case CXL_MBOX_OP_SET_FEATURE :if (cxl_mbox->feat_cap <CXL_FEATURES_RW )return false;