Skip to contentSkip to conversation

ColdFire: Bypass pciauto skip probing Host Bridge

PATCH New TsiChung Liew 2 participants 2 messages Jan 12, 2008 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ColdFire: Bypass pciauto skip probing Host Bridge

ColdFire: Bypass pciauto skip probing Host Bridge

---
 drivers/pci/pci_auto.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/pci/pci_auto.c +0 -0
index acfda83..3f67191 100644
@@ -389,6 +389,12 @@ int pciauto_config_device(struct pci_controller

*hose, pci_dev_t dev)
PCI_DEV(dev));
break;
#endif
+#ifdef CONFIG_SKIPPCI_HOSTBRIDGE
+ case PCI_CLASS_BRIDGE_OTHER:
+ DEBUGF("PCI Autoconfig: Skipping bridge device %d\n",
+ PCI_DEV(dev));
+ break;
+#endif
#ifdef CONFIG_MPC834X
case PCI_CLASS_BRIDGE_OTHER:
/*

Signature · 1 line
1.5.2
#1 lore raw

PATCH 1/1 ColdFire: Bypass pciauto skip probing Host Bridge

Hello,

Quoted 1 line · in message <1200105779.22596.7.camel@Goku> you wrote:

ColdFire: Bypass pciauto skip probing Host Bridge

...

Review

Quoted 6 lines
(quoted diff) +6 -0
+#ifdef CONFIG_SKIPPCI_HOSTBRIDGE
+	case PCI_CLASS_BRIDGE_OTHER:
+		DEBUGF("PCI Autoconfig: Skipping bridge device %d\n",
+		       PCI_DEV(dev));
+		break;
+#endif

We already have identical code which is currently #ifdef'ed depnding on CONFIG_MPC5200; instead of duplicating the code, please make it usable for all architectures (i. e. MPC5200), too.

Thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
One of the advantages of being a captain is being able to ask for ad-
vice without necessarily having to take it.
	-- Kirk, "Dagger of the Mind", stardate 2715.2