Skip to contentSkip to conversation

mpc82xx: Embedded Planet EP8248E support

PATCH Applied Scott Wood 3 participants 5 messages Jan 17, 2008 – Jan 21, 2008

Subsystems (2)
Device tree bindings PowerPC
lore
Share & tools
lore

Scott Wood

author
#0 lore raw

PATCH 2/2 mpc82xx: Embedded Planet EP8248E support

This board is also resold by Freescale under the names "QUICCStart MPC8248 Evaluation System" and "CWH-PPC-8248N-VE".

Signed-off-by Scott Wood <[email protected]>

---
Removed const/initdata combo, and used simple-bus for probing.

Please apply for 2.6.25.

 arch/powerpc/boot/Makefile             |    3 +-
 arch/powerpc/boot/dts/ep8248e.dts      |  207 ++++++++
 arch/powerpc/boot/ep8248e.c            |   55 +++
 arch/powerpc/boot/wrapper              |    2 +-
 arch/powerpc/configs/ep8248e_defconfig |  821 ++++++++++++++++++++++++++++++++
 arch/powerpc/platforms/82xx/Kconfig    |   13 +
 arch/powerpc/platforms/82xx/Makefile   |    1 +
 arch/powerpc/platforms/82xx/ep8248e.c  |  324 +++++++++++++
 include/asm-powerpc/mpc8260.h          |    1 +
 9 files changed, 1425 insertions(+), 2 deletions(-)
 create mode 100644 arch/powerpc/boot/dts/ep8248e.dts
 create mode 100644 arch/powerpc/boot/ep8248e.c
 create mode 100644 arch/powerpc/configs/ep8248e_defconfig
 create mode 100644 arch/powerpc/platforms/82xx/ep8248e.c
arch/powerpc/boot/Makefile +2 -1
index 08bf7aa..fcca455 100644
@@ -62,7 +62,7 @@ src-plat := of.c cuboot-52xx.c cuboot-83xx.c cuboot-85xx.c holly.c \
 		ps3-head.S ps3-hvcall.S ps3.c treeboot-bamboo.c cuboot-8xx.c \
 		cuboot-pq2.c cuboot-sequoia.c treeboot-walnut.c cuboot-bamboo.c \
 		fixed-head.S ep88xc.c cuboot-hpc2.c ep405.c cuboot-taishan.c \
-		cuboot-katmai.c cuboot-rainier.c redboot-8xx.c
+		cuboot-katmai.c cuboot-rainier.c redboot-8xx.c ep8248e.c
 src-boot := $(src-wlib) $(src-plat) empty.c
 
 src-boot := $(addprefix $(obj)/, $(src-boot))

@@ -195,6 +195,7 @@ image-$(CONFIG_PPC_8xx)			+= cuImage.8xx
 image-$(CONFIG_PPC_EP88XC)		+= zImage.ep88xc
 image-$(CONFIG_EP405)			+= zImage.ep405
 image-$(CONFIG_8260)			+= cuImage.pq2
+image-$(CONFIG_EP8248E)			+= zImage.ep8248e
 image-$(CONFIG_PPC_MPC52xx)		+= cuImage.52xx
 image-$(CONFIG_PPC_83xx)		+= cuImage.83xx
 image-$(CONFIG_PPC_85xx)		+= cuImage.85xx
arch/powerpc/boot/dts/ep8248e.dts new file +207 -0

207 lines not on this page · raw message

arch/powerpc/boot/ep8248e.c new file +55 -0

55 lines not on this page · raw message

arch/powerpc/boot/wrapper +1 -1
index a7c4671..763a0c4 100755
@@ -168,7 +168,7 @@ ps3)
     ksection=.kernel:vmlinux.bin
     isection=.kernel:initrd
     ;;
-ep88xc|ep405|redboot*)
+ep88xc|ep405|redboot*|ep8248e)
     platformo="$object/fixed-head.o $object/$platform.o"
     binary=y
     ;;
arch/powerpc/configs/ep8248e_defconfig new file +821 -0

821 lines not on this page · raw message

arch/powerpc/platforms/82xx/Kconfig +13 -0
index 541fbb8..4fad6c7 100644
@@ -26,6 +26,19 @@ config PQ2FADS
 	help
 	  This option enables support for the PQ2FADS board
 
+config EP8248E
+	bool "Embedded Planet EP8248E (a.k.a. CWH-PPC-8248N-VE)"
+	select 8272
+	select 8260
+	select FSL_SOC
+	select PPC_CPM_NEW_BINDING
+	select MDIO_BITBANG
+	help
+	  This enables support for the Embedded Planet EP8248E board.
+
+	  This board is also resold by Freescale as the QUICCStart
+	  MPC8248 Evaluation System and/or the CWH-PPC-8248N-VE.
+
 endchoice
 
 config PQ2ADS
arch/powerpc/platforms/82xx/Makefile +1 -0
index 68c8b0c..6cd5cd5 100644
@@ -5,3 +5,4 @@ obj-$(CONFIG_MPC8272_ADS) += mpc8272_ads.o
 obj-$(CONFIG_CPM2) += pq2.o
 obj-$(CONFIG_PQ2_ADS_PCI_PIC) += pq2ads-pci-pic.o
 obj-$(CONFIG_PQ2FADS) += pq2fads.o
+obj-$(CONFIG_EP8248E) += ep8248e.o
arch/powerpc/platforms/82xx/ep8248e.c new file +324 -0

324 lines not on this page · raw message

include/asm-powerpc/mpc8260.h +1 -0
index e0d4807..03317e1 100644
@@ -8,6 +8,7 @@
 #ifndef __ASM_POWERPC_MPC8260_H__
 #define __ASM_POWERPC_MPC8260_H__
 
+#define MPC82XX_BCR_PLDP 0x00800000 /* Pipeline Maximum Depth */
 
 #ifdef CONFIG_8260
Signature · 1 line
1.5.3.8
#1 lore raw

Review

Quoted 8 lines
(quoted diff) +7 -0
+			/* "Serial" port/SCC1 */
+			scc1: serial@11a00 {
+				device_type =3D "serial";
+				compatible =3D "fsl,mpc8248-scc-uart",
+				             "fsl,cpm2-scc-uart";
+				reg =3D <0x11a00 0x20 0x8000 0x100>;
+				interrupts =3D <40 8>;

are you sure with 40 as interrupt? has not it be "28"(hex) here?

Review

Quoted 5 lines
(quoted diff) +5 -0
+				interrupt-parent =3D <&PIC>;
+				fsl,cpm-brg =3D <1>;
+				fsl,cpm-command =3D <0x00800000>;
+				linux,planetcore-label =3D "SCC1";
+			};

--=20
Dipl.-Ing. Sergej Stepanov=20
Software-Entwicklung

IDS GmbH=20
E-PA (Entwicklung - Prozess Automatisierung)
Nobelstr. 18,=20
D-76275 Ettlingen=20
T. (0) 72 43/2 18-615=20
F. (0) 72 43/2 18-100=20
E. [email protected]

<http://www.ids.de>
Gesch=C3=A4ftsf=C3=BChrer: Norbert Wagner, Friedrich Abri=C3=9F=20 Sitz der Gesellschaft: Ettlingen=20
Amtsgericht Mannheim HRB 362503=20

author
#2 lore raw
Quoted 9 lines · Sergej Stepanov

arch/powerpc/boot/dts/ep8248e.dts line 155

Quoted 8 lines
arch/powerpc/boot/dts/ep8248e.dts new file +7 -0
+			/* "Serial" port/SCC1 */
+			scc1: serial@11a00 {
+				device_type = "serial";
+				compatible = "fsl,mpc8248-scc-uart",
+				             "fsl,cpm2-scc-uart";
+				reg = <0x11a00 0x20 0x8000 0x100>;
+				interrupts = <40 8>;

are you sure with 40 as interrupt? has not it be "28"(hex) here?

This is a version 1 dts file -- the default base is decimal.

-Scott

#3 lore raw

Am Freitag, den 18.01.2008, 10:03 -0600 schrieb Scott Wood:

Quoted 11 lines · Sergej Stepanov
Quoted 9 lines

arch/powerpc/boot/dts/ep8248e.dts line 155

Quoted 8 lines
arch/powerpc/boot/dts/ep8248e.dts new file +7 -0
+			/* "Serial" port/SCC1 */
+			scc1: serial@11a00 {
+				device_type = "serial";
+				compatible = "fsl,mpc8248-scc-uart",
+				             "fsl,cpm2-scc-uart";
+				reg = <0x11a00 0x20 0x8000 0x100>;
+				interrupts = <40 8>;

are you sure with 40 as interrupt? has not it be "28"(hex) here?

Quoted 3 lines

This is a version 1 dts file -- the default base is decimal.

-Scott

yes, you are right, sorry.

Applied
#4 lore raw
In reply to Scott Wood
Quoted 9 lines · Scott Wood

This board is also resold by Freescale under the names "QUICCStart MPC8248 Evaluation System" and "CWH-PPC-8248N-VE".

Signed-off-by Scott Wood <[email protected]>

---
Removed const/initdata combo, and used simple-bus for probing.

Please apply for 2.6.25.

Quoted 15 lines
 arch/powerpc/boot/Makefile             |    3 +-
 arch/powerpc/boot/dts/ep8248e.dts      |  207 ++++++++
 arch/powerpc/boot/ep8248e.c            |   55 +++
 arch/powerpc/boot/wrapper              |    2 +-
 arch/powerpc/configs/ep8248e_defconfig |  821 ++++++++++++++++++++++++++++++++
 arch/powerpc/platforms/82xx/Kconfig    |   13 +
 arch/powerpc/platforms/82xx/Makefile   |    1 +
 arch/powerpc/platforms/82xx/ep8248e.c  |  324 +++++++++++++
 include/asm-powerpc/mpc8260.h          |    1 +
 9 files changed, 1425 insertions(+), 2 deletions(-)
 create mode 100644 arch/powerpc/boot/dts/ep8248e.dts
 create mode 100644 arch/powerpc/boot/ep8248e.c
 create mode 100644 arch/powerpc/configs/ep8248e_defconfig
 create mode 100644 arch/powerpc/platforms/82xx/ep8248e.c

applied.

- k