: Fix minor bug in bnx2_has_work().

PATCH Applied Michael Chan 2 participants 2 messages Jan 22, 2008

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Michael Chan

author

2008-01-22 00:26 UTC #0 lore raw

PATCH 2/4 : Fix minor bug in bnx2_has_work().

[BNX2]: Fix minor bug in bnx2_has_work().

It is more correct to get the status block from the bnx2_napi struct instead of the bnx2 struct. It happens that they are the same in this case because we are using the first MSIX vector.

Signed-off-by Michael Chan <[email protected]>

drivers/net/bnx2.c +1 -2

index 8348af2..7ee7746 100644
@@ -2903,8 +2903,7 @@ bnx2_tx_msix(int irq, void *dev_instance)
 static inline int
 bnx2_has_work(struct bnx2_napi *bnapi)
 {
-	struct bnx2 *bp = bnapi->bp;
-	struct status_block *sblk = bp->status_blk;
+	struct status_block *sblk = bnapi->status_blk;
 
 	if ((bnx2_get_hw_rx_cons(bnapi) != bnapi->rx_cons) ||
 	    (bnx2_get_hw_tx_cons(bnapi) != bnapi->hw_tx_cons))

David Miller

maintainer Applied

2008-01-22 01:06 UTC #1 lore raw

From: "Michael Chan" <[email protected]>
Date: Mon, 21 Jan 2008 17:08:01 -0800

Quoted 7 lines

[BNX2]: Fix minor bug in bnx2_has_work().
It is more correct to get the status block from the bnx2_napi struct instead of the bnx2 struct. It happens that they are the same in this case because we are using the first MSIX vector.
Signed-off-by Michael Chan <[email protected]>

Applied.