Skip to contentSkip to conversation

Only wake the reclaim daemon if we need to

PATCH New Bob Peterson 2 participants 2 messages Jan 28, 2008 – Jan 29, 2008 GFS2 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Only wake the reclaim daemon if we need to

Hi,

This patch only wakes up the glock reclaim daemon if there is actually something to be reclaimed.

Regards,

Bob Peterson
Red Hat GFS

--

 fs/gfs2/glock.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
fs/gfs2/glock.c +4 -4
index 80e09c5..894c70e 100644
@@ -1586,10 +1586,10 @@ void gfs2_glock_schedule_for_reclaim(struct gfs2_glock *gl)
 		gfs2_glock_hold(gl);
 		list_add(&gl->gl_reclaim, &sdp->sd_reclaim_list);
 		atomic_inc(&sdp->sd_reclaim_count);
-	}
-	spin_unlock(&sdp->sd_reclaim_lock);
-
-	wake_up(&sdp->sd_reclaim_wq);
+		spin_unlock(&sdp->sd_reclaim_lock);
+		wake_up(&sdp->sd_reclaim_wq);
+	} else
+		spin_unlock(&sdp->sd_reclaim_lock);
 }
 
 /**
#1 lore raw

PATCH 1/1 Only wake the reclaim daemon if we need to

Hi,

Now in the -nmw git tree. Thanks,

Steve.

Quoted 36 lines · Bob Peterson

Hi,

This patch only wakes up the glock reclaim daemon if there is actually something to be reclaimed.

Regards,

Bob Peterson
Red Hat GFS

--

 fs/gfs2/glock.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
fs/gfs2/glock.c +4 -4
index 80e09c5..894c70e 100644
@@ -1586,10 +1586,10 @@ void gfs2_glock_schedule_for_reclaim(struct gfs2_glock *gl)
 		gfs2_glock_hold(gl);
 		list_add(&gl->gl_reclaim, &sdp->sd_reclaim_list);
 		atomic_inc(&sdp->sd_reclaim_count);
-	}
-	spin_unlock(&sdp->sd_reclaim_lock);
-
-	wake_up(&sdp->sd_reclaim_wq);
+		spin_unlock(&sdp->sd_reclaim_lock);
+		wake_up(&sdp->sd_reclaim_wq);
+	} else
+		spin_unlock(&sdp->sd_reclaim_lock);
 }
 
 /**