Skip to contentSkip to conversation

Plug an unlikely leak

PATCH New Bob Peterson 2 participants 2 messages Jan 28, 2008 – Jan 29, 2008 GFS2 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Plug an unlikely leak

--

 fs/gfs2/lops.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
fs/gfs2/lops.c +3 -1
index 7138737..4390f6f 100644
@@ -404,8 +404,10 @@ static int revoke_lo_scan_elements(struct gfs2_jdesc *jd, unsigned int start,
 			blkno = be64_to_cpu(*(__be64 *)(bh->b_data + offset));
 
 			error = gfs2_revoke_add(sdp, blkno, start);
-			if (error < 0)
+			if (error < 0) {
+				brelse(bh);
 				return error;
+			}
 			else if (error)
 				sdp->sd_found_revokes++;
 
#1 lore raw

PATCH 1/1 Plug an unlikely leak

Hi,

Now in the -nme git tree. Thanks,

Steve.

Quoted 22 lines · Bob Peterson

--

 fs/gfs2/lops.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
fs/gfs2/lops.c +3 -1
index 7138737..4390f6f 100644
@@ -404,8 +404,10 @@ static int revoke_lo_scan_elements(struct gfs2_jdesc *jd, unsigned int start,
 			blkno = be64_to_cpu(*(__be64 *)(bh->b_data + offset));
 
 			error = gfs2_revoke_add(sdp, blkno, start);
-			if (error < 0)
+			if (error < 0) {
+				brelse(bh);
 				return error;
+			}
 			else if (error)
 				sdp->sd_found_revokes++;