hide kernel only code in asm-powerpc/elf.h
PATCH 1/1 hide kernel only code in asm-powerpc/elf.h
stuff inside CONFIG_* should not be exported via make headers-install
Signed-off-by Olaf Hering <[email protected]>
--- include/asm-powerpc/elf.h | 2 ++ 1 file changed, 2 insertions(+)
include/asm-powerpc/elf.h +2 -0
@@ -420,6 +420,7 @@ do { \/* Keep this the last entry. */ #define R_PPC64_NUM 107 +#ifdef __KERNEL__#ifdef CONFIG_SPU_BASE /* Notes used in ET_CORE. Note name is "SPU/<fd>/<filename>". */ #define NT_SPU 1
@@ -427,5 +428,6 @@ do { \#define ARCH_HAVE_EXTRA_ELF_NOTES #endif /* CONFIG_SPU_BASE */ +#endif /* __KERNEL__ */ #endif /* _ASM_POWERPC_ELF_H */
Quoted 4 lines · Olaf Hering
stuff inside CONFIG_* should not be exported via make headers-install
Signed-off-by Olaf Hering <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
I think at some point I even had a script to automatically check for this kind of bug. Using any #ifdef CONFIG_* in an exported header is guaranteed to be a bug, because we don't export config.h.
Arnd <><
Quoted 7 lines · Olaf Hering
stuff inside CONFIG_* should not be exported via make headers-install
Signed-off-by Olaf Hering <[email protected]>--- include/asm-powerpc/elf.h | 2 ++ 1 file changed, 2 insertions(+)
Thanks Olaf, I noticed that once but forgot to fix it.
cheers
Signature · 8 lines
Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person