Skip to contentSkip to conversation

fs/char_dev.c: chrdev_open marked static and removed from fs.h

PATCH New Denis Cheng 1 participant 1 message Jan 31, 2008 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/char_dev.c: chrdev_open marked static and removed from fs.h

there is an outdated comment in serial_core.c also fixed.

---
 drivers/serial/serial_core.c |    4 ++--
 fs/char_dev.c                |    2 +-
 include/linux/fs.h           |    1 -
 3 files changed, 3 insertions(+), 4 deletions(-)
drivers/serial/serial_core.c +2 -2
index 3bb5d24..2f0b61c 100644
@@ -1550,8 +1550,8 @@ static struct uart_state *uart_get(struct uart_driver *drv, int line)
 }
 
 /*
- * In 2.4.5, calls to uart_open are serialised by the BKL in
- *   linux/fs/devices.c:chrdev_open()
+ * calls to uart_open are serialised by the BKL in
+ *   fs/char_dev.c:chrdev_open()
  * Note that if this fails, then uart_close() _will_ be called.
  *
  * In time, we want to scrap the "opening nonpresent ports"
fs/char_dev.c +1 -1
index 2c7a8b5..038674a 100644
@@ -357,7 +357,7 @@ void cdev_put(struct cdev *p)
 /*
  * Called every time a character special file is opened
  */
-int chrdev_open(struct inode * inode, struct file * filp)
+static int chrdev_open(struct inode *inode, struct file *filp)
 {
 	struct cdev *p;
 	struct cdev *new = NULL;
include/linux/fs.h +0 -1
index a516b67..a5fb302 100644
@@ -1620,7 +1620,6 @@ extern int register_chrdev(unsigned int, const char *,
 			   const struct file_operations *);
 extern void unregister_chrdev(unsigned int, const char *);
 extern void unregister_chrdev_region(dev_t, unsigned);
-extern int chrdev_open(struct inode *, struct file *);
 extern void chrdev_show(struct seq_file *,off_t);
 
 /* fs/block_dev.c */
Signature · 1 line
1.5.3.8