x86: fix sparse warnings in cpu/common.c
PATCH 1/1 x86: fix sparse warnings in cpu/common.c
The casts will always be needed, may as well make them the right signedness. The ebx variables can easily be unsigned, may as well.
arch/x86/kernel/cpu/common.c:261:21: warning: incorrect type in argument 2 (different signedness)arch/x86/kernel/cpu/common.c:261:21: expected unsigned int *eaxarch/x86/kernel/cpu/common.c:261:21: got int *<noident>arch/x86/kernel/cpu/common.c:262:9: warning: incorrect type in argument 3 (different signedness)arch/x86/kernel/cpu/common.c:262:9: expected unsigned int *ebxarch/x86/kernel/cpu/common.c:262:9: got int *<noident>arch/x86/kernel/cpu/common.c:263:9: warning: incorrect type in argument 4 (different signedness)arch/x86/kernel/cpu/common.c:263:9: expected unsigned int *ecxarch/x86/kernel/cpu/common.c:263:9: got int *<noident>arch/x86/kernel/cpu/common.c:264:9: warning: incorrect type in argument 5 (different signedness)arch/x86/kernel/cpu/common.c:264:9: expected unsigned int *edxarch/x86/kernel/cpu/common.c:264:9: got int *<noident>arch/x86/kernel/cpu/common.c:293:30: warning: incorrect type in argument 3 (different signedness)arch/x86/kernel/cpu/common.c:293:30: expected unsigned int *ebxarch/x86/kernel/cpu/common.c:293:30: got int *<noident>arch/x86/kernel/cpu/common.c:350:22: warning: incorrect type in argument 2 (different signedness)arch/x86/kernel/cpu/common.c:350:22: expected unsigned int *eaxarch/x86/kernel/cpu/common.c:350:22: got int *<noident>arch/x86/kernel/cpu/common.c:351:10: warning: incorrect type in argument 3 (different signedness)arch/x86/kernel/cpu/common.c:351:10: expected unsigned int *ebxarch/x86/kernel/cpu/common.c:351:10: got int *<noident>arch/x86/kernel/cpu/common.c:352:10: warning: incorrect type in argument 4 (different signedness)arch/x86/kernel/cpu/common.c:352:10: expected unsigned int *ecxarch/x86/kernel/cpu/common.c:352:10: got int *<noident>arch/x86/kernel/cpu/common.c:353:10: warning: incorrect type in argument 5 (different signedness)arch/x86/kernel/cpu/common.c:353:10: expected unsigned int *edxarch/x86/kernel/cpu/common.c:353:10: got int *<noident>arch/x86/kernel/cpu/common.c:362:30: warning: incorrect type in argument 3 (different signedness)arch/x86/kernel/cpu/common.c:362:30: expected unsigned int *ebxarch/x86/kernel/cpu/common.c:362:30: got int *<noident>
--- arch/x86/kernel/cpu/common.c | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-)
arch/x86/kernel/cpu/common.c +10 -10
@@ -258,10 +258,10 @@ static int __cpuinit have_cpuid_p(void)void __init cpu_detect (struct cpuinfo_x86 *c) {/* Get vendor name */ -cpuid (0x00000000 , &c->cpuid_level, - (int *)&c->x86_vendor_id[0 ], - (int *)&c->x86_vendor_id[8 ], - (int *)&c->x86_vendor_id[4 ]); +cpuid (0x00000000 , (unsigned int *)&c->cpuid_level, + (unsigned int *)&c->x86_vendor_id[0 ], + (unsigned int *)&c->x86_vendor_id[8 ], + (unsigned int *)&c->x86_vendor_id[4 ]); c->x86 =4 ;if (c->cpuid_level >=0x00000001 ) {
@@ -283,7 +283,7 @@ void __init cpu_detect(struct cpuinfo_x86 *c)static void __cpuinit early_get_cap (struct cpuinfo_x86 *c) {u32 tfms, xlvl; -int ebx; +unsigned int ebx;memset (&c->x86_capability,0 ,sizeof c->x86_capability);if (have_cpuid_p ()) {
@@ -343,14 +343,14 @@ static void __init early_cpu_detect(void)static void __cpuinit generic_identify (struct cpuinfo_x86 * c) {u32 tfms, xlvl; -int ebx; +unsigned int ebx;if (have_cpuid_p ()) {/* Get vendor name */ -cpuid (0x00000000 , &c->cpuid_level, - (int *)&c->x86_vendor_id[0 ], - (int *)&c->x86_vendor_id[8 ], - (int *)&c->x86_vendor_id[4 ]); +cpuid (0x00000000 , (unsigned int *)&c->cpuid_level, + (unsigned int *)&c->x86_vendor_id[0 ], + (unsigned int *)&c->x86_vendor_id[8 ], + (unsigned int *)&c->x86_vendor_id[4 ]);get_cpu_vendor (c,0 );/* Initialize the standard set of capabilities */
Signature · 1 line
1.5.4.rc4.1142.gf5a97