Build error on PowerPC
Hi,
I get the following build error on PowerPC:
CC [M] sound/ppc/awacs.o
In file included from sound/ppc/awacs.c:25:include/asm/nvram.h:62: error: field ‘partition’ has incomplete type make[2]: *** [sound/ppc/awacs.o] Error 1
make[1]: *** [sound/ppc] Error 2
make: *** [sound] Error 2
Regards
Marcel
Hi,
Please define what kernel version and what config you're trying to build.
Also, please cc [email protected] for powerpc issues.
Thanks,
Olof
Quoted 21 lines · Marcel Holtmann
Hi,
I get the following build error on PowerPC:
CC [M]
sound/ppc/awacs.o
In file included fromsound/ppc/awacs.c:25:include/asm/nvram.h:62: error: field ???partition??? has incomplete type make[2]: *** [sound/ppc/awacs.o] Error 1
make[1]: *** [sound/ppc] Error 2
make: *** [sound] Error 2Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Olof,
Quoted 2 lines
Please define what kernel version and what config you're trying to build.
it is the latest kernel for Linus' git and the config is kinda obviously enabling the awacs.c driver. Anyway, the driver didn't make use of the NVRAM call and thus removing that include is perfectly fine. Attached patch fixes that issue.
Quoted 1 line
Also, please cc [email protected] for powerpc issues.
To be quite honest, it is highly likely that I forget the next time. Good that you read LKML :)
Regards
Marcel
[PATCH] Fix compilation of sound/ppc/awacs.c
Including of asm/nvram.h in the awacs.c driver is not needed and it fixes the following compilation error:
CC [M] sound/ppc/awacs.o
In file included from sound/ppc/awacs.c:25:include/asm/nvram.h:62: error: field ‘partition’ has incomplete type make[2]: *** [sound/ppc/awacs.o] Error 1
make[1]: *** [sound/ppc] Error 2
make: *** [sound] Error 2
---
commit 5613f9f9aa321cf59915137cc611aea9fd95ed75
tree 3c55137ccc3d16e49b757a0e6135f32fb2086ae3
parent aa6299926950c8dfe2fea638276cad6def092bc9
author Marcel Holtmann <[email protected]> Sat, 02 Feb 2008 03:52:23 +0100 committer Marcel Holtmann <[email protected]> Sat, 02 Feb 2008 03:52:23 +0100
sound/ppc/awacs.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
sound/ppc/awacs.c +0 -1
@@ -21,7 +21,6 @@#include <asm/io.h> -#include <asm/nvram.h> #include <linux/init.h> #include <linux/delay.h> #include <linux/slab.h>
Quoted 9 lines · Marcel Holtmann
Hi Olof,
Quoted 2 lines
Please define what kernel version and what config you're trying to build.
it is the latest kernel for Linus' git and the config is kinda obviously enabling the
awacs.cdriver. Anyway, the driver didn't make use of the NVRAM call and thus removing that include is perfectly fine. Attached patch fixes that issue.
Sure, but it could have been dependent on other options around it (i.e. nvram-related ones). It's just good habit to include the info, that's all.
Quoted 4 lines
Quoted 1 line
Also, please cc [email protected] for powerpc issues.
To be quite honest, it is highly likely that I forget the next time. Good that you read LKML :)
Well, sometimes I do, sometimes others do. It just might take longer for someone to stuble over it. :-)
-Olof