Release of bluez-libs-3.25 and bluez-utils-3.25

Bluez-devel Bastien Nocera 2 participants 4 messages Feb 2, 2008 1 message not in the archive Bluetooth drivers

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): 1201926335.15090.32.camel@violet

Bastien Nocera

author

2008-02-02 13:03 UTC #1 lore raw

Quoted 6 lines · Marcel Holtmann

Hi Folks,
this is an update release of the new stable versions of the Bluetooth library and the utilities. This release updates the audio service with experimental MPEG12/MP3 support. It also updates the GStreamer plugins to make use of it.

I got a build problem with the 3.25 release of bluez-libs:
sdp.c: In function 'sdp_data_alloc_with_length':
sdp.c:450: error: 'USHRT_MAX' undeclared (first use in this function) sdp.c:450: error: (Each undeclared identifier is reported only once sdp.c:450: error: for each function it appears in.)
sdp.c: In function 'sdp_append_to_buf':
sdp.c:2393: error: 'UCHAR_MAX' undeclared (first use in this function) make[2]: *** [sdp.lo] Error 1

The attached patch fixes it for me, although I don't see the problem on my older system (Fedora 8 vs. Rawhide).

Index: sdp.c
===================================================================
RCS file: /cvsroot/bluez/libs/src/sdp.c,v
retrieving revision 1.79

sdp.c +1 -0

diff -u -p -r1.79 src/sdp.c
@@ -35,6 +35,7 @@
 #include <stdlib.h>
 #include <malloc.h>
 #include <syslog.h>
+#include <limits.h>
 #include <sys/un.h>
 #include <sys/socket.h>
 #include <sys/time.h>

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Marcel Holtmann

maintainer

2008-02-02 13:18 UTC #2 lore raw

Hi Bastien,

Quoted 14 lines

Quoted 4 lines
this is an update release of the new stable versions of the Bluetooth library and the utilities. This release updates the audio service with experimental MPEG12/MP3 support. It also updates the GStreamer plugins to make use of it.
I got a build problem with the 3.25 release of bluez-libs:
sdp.c: In function 'sdp_data_alloc_with_length':
sdp.c:450: error: 'USHRT_MAX' undeclared (first use in this function) sdp.c:450: error: (Each undeclared identifier is reported only once sdp.c:450: error: for each function it appears in.)
sdp.c: In function 'sdp_append_to_buf':
sdp.c:2393: error: 'UCHAR_MAX' undeclared (first use in this function) make[2]: *** [sdp.lo] Error 1

Quoted 2 lines

The attached patch fixes it for me, although I don't see the problem on my older system (Fedora 8 vs. Rawhide).

I hate when glibc changes its behavior. This code hasn't been touched for over 3 years ;)

Anyway. Patch has been applied. Thanks.

Regards

Marcel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Bastien Nocera

author

2008-02-02 14:19 UTC #3 lore raw

Quoted 16 lines · Marcel Holtmann

Hi Bastien,
Quoted 14 lines
Quoted 4 lines
this is an update release of the new stable versions of the Bluetooth library and the utilities. This release updates the audio service with experimental MPEG12/MP3 support. It also updates the GStreamer plugins to make use of it.
I got a build problem with the 3.25 release of bluez-libs:
sdp.c: In function 'sdp_data_alloc_with_length':
sdp.c:450: error: 'USHRT_MAX' undeclared (first use in this function) sdp.c:450: error: (Each undeclared identifier is reported only once sdp.c:450: error: for each function it appears in.)
sdp.c: In function 'sdp_append_to_buf':
sdp.c:2393: error: 'UCHAR_MAX' undeclared (first use in this function) make[2]: *** [sdp.lo] Error 1

Quoted 7 lines

Quoted 2 lines
The attached patch fixes it for me, although I don't see the problem on my older system (Fedora 8 vs. Rawhide).
I hate when glibc changes its behavior. This code hasn't been touched for over 3 years ;)
Anyway. Patch has been applied. Thanks.

I have no idea why they changed that. Same problem with a few defines in bluez-utils (missing UCHAR_MAX, USHRT_MAX and UINT_MAX).

Patch attached

Index: common/sdp-dummy.c
===================================================================
RCS file: /cvsroot/bluez/utils/common/sdp-dummy.c,v retrieving revision 1.6

sdp-dummy.c +1 -0

diff -u -p -r1.6 sdp-dummy.c
@@ -27,6 +27,7 @@
 
 #include <stdio.h>
 #include <errno.h>
+#include <limits.h>
 
 #include "logging.h"
 #include "sdp-xml.h"

Index: common/sdp-expat.c
===================================================================
RCS file: /cvsroot/bluez/utils/common/sdp-expat.c,v retrieving revision 1.11

sdp-expat.c +1 -0

diff -u -p -r1.11 sdp-expat.c
@@ -26,6 +26,7 @@
 #endif
 
 #include <stdlib.h>
+#include <limits.h>
 
 #include <bluetooth/sdp.h>
 #include <bluetooth/sdp_lib.h>

Index: common/sdp-glib.c
===================================================================
RCS file: /cvsroot/bluez/utils/common/sdp-glib.c,v retrieving revision 1.6

sdp-glib.c +1 -0

diff -u -p -r1.6 sdp-glib.c
@@ -26,6 +26,7 @@
 #endif
 
 #include <stdlib.h>
+#include <limits.h>
 
 #include <bluetooth/sdp.h>
 #include <bluetooth/sdp_lib.h>

Index: sdpd/request.c
===================================================================
RCS file: /cvsroot/bluez/utils/sdpd/request.c,v
retrieving revision 1.20

request.c +1 -0

diff -u -p -r1.20 request.c
@@ -32,6 +32,7 @@
 #include <errno.h>
 #include <stdlib.h>
 #include <malloc.h>
+#include <limits.h>
 #include <sys/socket.h>
 
 #include <bluetooth/bluetooth.h>

Index: audio/pcm_bluetooth.c
===================================================================
RCS file: /cvsroot/bluez/utils/audio/pcm_bluetooth.c,v retrieving revision 1.98

pcm_bluetooth.c +1 -0

diff -u -p -r1.98 pcm_bluetooth.c
@@ -33,6 +33,7 @@
 #include <sys/time.h>
 #include <pthread.h>
 #include <signal.h>
+#include <limits.h>
 
 #include <netinet/in.h>

_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Marcel Holtmann

maintainer

2008-02-02 15:07 UTC #4 lore raw

Hi Bastien,

Quoted 17 lines

Quoted 17 lines
Quoted 16 lines
Quoted 4 lines
this is an update release of the new stable versions of the Bluetooth library and the utilities. This release updates the audio service with experimental MPEG12/MP3 support. It also updates the GStreamer plugins to make use of it.
I got a build problem with the 3.25 release of bluez-libs:
sdp.c: In function 'sdp_data_alloc_with_length':
sdp.c:450: error: 'USHRT_MAX' undeclared (first use in this function) sdp.c:450: error: (Each undeclared identifier is reported only once sdp.c:450: error: for each function it appears in.)
sdp.c: In function 'sdp_append_to_buf':
sdp.c:2393: error: 'UCHAR_MAX' undeclared (first use in this function) make[2]: *** [sdp.lo] Error 1
The attached patch fixes it for me, although I don't see the problem on my older system (Fedora 8 vs. Rawhide).

Quoted 7 lines

Quoted 4 lines
I hate when glibc changes its behavior. This code hasn't been touched for over 3 years ;)
Anyway. Patch has been applied. Thanks.
I have no idea why they changed that. Same problem with a few defines in bluez-utils (missing UCHAR_MAX, USHRT_MAX and UINT_MAX).

patch has been committed to the CVS. Thanks.

Regards

Marcel