Skip to contentSkip to conversation

ehea: add memory remove hotplug support

PATCH In review Jan-Bernd Themann 2 participants 4 messages Feb 4, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 ehea: add memory remove hotplug support

Add memory remove hotplug support

---
Comment: This patch depends on the following patch that exports the symbols
register_memory_notifier() unregister_memory_notifier()

http://lkml.org/lkml/2008/2/1/293

 drivers/net/ehea/ehea_main.c |   25 +++++++++++++++++++++++++
 1 files changed, 25 insertions(+), 0 deletions(-)
drivers/net/ehea/ehea_main.c +25 -0
index 21af674..b75afcc 100644
@@ -35,6 +35,7 @@
 #include <linux/if_ether.h>
 #include <linux/notifier.h>
 #include <linux/reboot.h>
+#include <linux/memory.h>
 #include <asm/kexec.h>
 
 #include <net/ip.h>
@@ -3480,6 +3481,24 @@ void ehea_crash_handler(void)
 					      0, H_DEREG_BCMC);
 }
 
+static int ehea_mem_notifier(struct notifier_block *nb,
+                             unsigned long action, void *data)
+{
+	switch (action) {
+	case MEM_OFFLINE:
+		ehea_info("memory has been removed");
+		ehea_rereg_mrs(NULL);
+		break;
+	default:
+		break;
+	}
+	return NOTIFY_OK;
+}
+
+static struct notifier_block ehea_mem_nb = {
+	.notifier_call = ehea_mem_notifier,
+};
+
 static int ehea_reboot_notifier(struct notifier_block *nb,
 				unsigned long action, void *unused)
 {
@@ -3559,6 +3578,10 @@ int __init ehea_module_init(void)
 	if (ret)
 		ehea_info("failed registering reboot notifier");
 
+	ret = register_memory_notifier(&ehea_mem_nb);
+	if (ret)
+		ehea_info("failed registering memory remove notifier");
+
 	ret = crash_shutdown_register(&ehea_crash_handler);
 	if (ret)
 		ehea_info("failed registering crash handler");
@@ -3582,6 +3605,7 @@ int __init ehea_module_init(void)
 out3:
 	ibmebus_unregister_driver(&ehea_driver);
 out2:
+	unregister_memory_notifier(&ehea_mem_nb);
 	unregister_reboot_notifier(&ehea_reboot_nb);
 	crash_shutdown_unregister(&ehea_crash_handler);
 out:
@@ -3599,6 +3623,7 @@ static void __exit ehea_module_exit(void)
 	ret = crash_shutdown_unregister(&ehea_crash_handler);
 	if (ret)
 		ehea_info("failed unregistering crash handler");
+	unregister_memory_notifier(&ehea_mem_nb);
 	kfree(ehea_fw_handles.arr);
 	kfree(ehea_bcmc_regs.arr);
 	ehea_destroy_busmap();
Signature · 1 line
1.5.2
#1 lore raw
Quoted 22 lines · Jan-Bernd Themann

Add memory remove hotplug support

---
Comment: This patch depends on the following patch that exports the symbols
register_memory_notifier() unregister_memory_notifier()

http://lkml.org/lkml/2008/2/1/293

 drivers/net/ehea/ehea_main.c |   25 +++++++++++++++++++++++++
 1 files changed, 25 insertions(+), 0 deletions(-)
drivers/net/ehea/ehea_main.c +0 -0
index 21af674..b75afcc 100644

drivers/net/ehea/ehea_main.c int __init ehea_module_init(void) · line 3587

Quoted 10 lines
drivers/net/ehea/ehea_main.c +3 -0
@@ -3559,6 +3578,10 @@ int __init ehea_module_init(void)
 	if (ret)
 		ehea_info("failed registering reboot notifier");
 
+	ret = register_memory_notifier(&ehea_mem_nb);
+	if (ret)
+		ehea_info("failed registering memory remove notifier");
 
 	ret = crash_shutdown_register(&ehea_crash_handler);
 	if (ret)
 		ehea_info("failed registering crash handler");

You don't do anything except print a message if the registration fails. What happens when someone tries to remove memory but the memory notifier wasn't registered properly? Bang?

cheers

Signature · 8 lines
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
#2 lore raw
Quoted 11 lines · Michael Ellerman
Quoted 10 lines · Jan-Bernd Themann

Add memory remove hotplug support

drivers/net/ehea/ehea_main.c +3 -0
@@ -3559,6 +3578,10 @@ int __init ehea_module_init(void)
 	if (ret)
 		ehea_info("failed registering reboot notifier");
 
+	ret = register_memory_notifier(&ehea_mem_nb);
+	if (ret)
+		ehea_info("failed registering memory remove notifier");
 
Quoted 7 lines

drivers/net/ehea/ehea_main.c int __init ehea_module_init(void) · line 3587

Quoted 3 lines
drivers/net/ehea/ehea_main.c +0 -0
 	ret = crash_shutdown_register(&ehea_crash_handler);
 	if (ret)
 		ehea_info("failed registering crash handler");

You don't do anything except print a message if the registration fails. What happens when someone tries to remove memory but the memory notifier wasn't registered properly? Bang?

In case the registration fails and somebody tries to free memory:
- Driver will not remove the affected memory from the eHEA memory region --> Firmware (phyp) can not free that memory (as marked as used) --> Therefore the removed memory could not be used in an other partition

It makes sense to allow the driver to work anyway. Having no ethernet would not really be a good alternative.

Regards,
Jan-Bernd

#3 lore raw
Quoted 20 lines · Jan-Bernd Themann
Quoted 11 lines · Michael Ellerman
Quoted 10 lines · Jan-Bernd Themann

Add memory remove hotplug support

drivers/net/ehea/ehea_main.c +3 -0
@@ -3559,6 +3578,10 @@ int __init ehea_module_init(void)
 	if (ret)
 		ehea_info("failed registering reboot notifier");
 
+	ret = register_memory_notifier(&ehea_mem_nb);
+	if (ret)
+		ehea_info("failed registering memory remove notifier");
 
Quoted 7 lines

drivers/net/ehea/ehea_main.c int __init ehea_module_init(void) · line 3587

Quoted 3 lines
drivers/net/ehea/ehea_main.c +0 -0
 	ret = crash_shutdown_register(&ehea_crash_handler);
 	if (ret)
 		ehea_info("failed registering crash handler");

You don't do anything except print a message if the registration fails. What happens when someone tries to remove memory but the memory notifier wasn't registered properly? Bang?

Quoted 7 lines

In case the registration fails and somebody tries to free memory:
- Driver will not remove the affected memory from the eHEA memory region --> Firmware (phyp) can not free that memory (as marked as used) --> Therefore the removed memory could not be used in an other partition

It makes sense to allow the driver to work anyway. Having no ethernet would not really be a good alternative.

Yeah I agree. I wasn't clear from the patch that no notifier -> no memory removed. Rather than, no notifier -> memory removed and ehea isn't told about it.

cheers

Signature · 8 lines
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person