Skip to contentSkip to conversation

b43: fix build with CONFIG_SSB_PCIHOST=n

PATCH In review [email protected] 2 participants 2 messages Feb 5, 2008 Sonics silicon backplane driver (ssb)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b43: fix build with CONFIG_SSB_PCIHOST=n

From: Andrew Morton <[email protected]>

m68k allmodconfig gives

drivers/net/wireless/b43/main.c:251: error: implicit declaration of function 'mmiowb'

because CONFIG_B43=m, CONFIG_SSB_PCIHOST=n.

Might be Kconfig bustage, but this works...

Cc Michael Buesch <[email protected]>
Cc "John W. Linville" <[email protected]>

---

 include/linux/ssb/ssb.h |    9 +++++++++
 1 file changed, 9 insertions(+)
include/linux/ssb/ssb.h renamed from include/linux/ssb/ssb.h~b43-fix-build-with-config_ssb_pcihost=n +9 -0
diff -puN include/linux/ssb/ssb.h~b43-fix-build-with-config_ssb_pcihost=n include/linux/ssb/ssb.h
@@ -373,6 +373,15 @@ void ssb_pcihost_set_power_state(struct 
 	if (sdev->bus->bustype == SSB_BUSTYPE_PCI)
 		pci_set_power_state(sdev->bus->host_pci, state);
 }
+#else
+static inline void ssb_pcihost_unregister(struct pci_driver *driver)
+{
+}
+
+static inline
+void ssb_pcihost_set_power_state(struct ssb_device *sdev, pci_power_t state)
+{
+}
 #endif /* CONFIG_SSB_PCIHOST */
 
 

_

#1 lore raw
Quoted 9 lines · On Mon, 2008-02-04 at 23:58 -0800, [email protected] wrote:

From: Andrew Morton <[email protected]>

m68k allmodconfig gives

drivers/net/wireless/b43/main.c:251: error: implicit declaration of function 'mmiowb'

because CONFIG_B43=m, CONFIG_SSB_PCIHOST=n.

Might be Kconfig bustage, but this works...

It's not Kcconfig bustage and I agree with this patch more than the one posted on netdev recently fixing it specifically in b44 (rather than like this patch that fixes them both at once).

johannes