Skip to contentSkip to conversation

Remove unused counters

PATCH New Bob Peterson 2 participants 2 messages Feb 5, 2008 – Feb 6, 2008 GFS2 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove unused counters

Hi,

This is kind of trivial in the greater scheme of things, but this removes three counters that AFAICT are never used.

Regards,

Bob Peterson
Red Hat GFS

--

 fs/gfs2/incore.h |    3 ---
 fs/gfs2/sys.c    |    6 ------
 2 files changed, 0 insertions(+), 9 deletions(-)
fs/gfs2/incore.h +0 -3
index 4c921ec..891b730 100644
@@ -636,9 +636,6 @@ struct gfs2_sbd {
 
 	/* Counters */
 
-	atomic_t sd_glock_count;
-	atomic_t sd_glock_held_count;
-	atomic_t sd_inode_count;
 	atomic_t sd_reclaimed;
 
 	char sd_fsname[GFS2_FSNAME_LEN];
fs/gfs2/sys.c +0 -6
index cc35ec8..9ab9fc8 100644
@@ -327,15 +327,9 @@ static ssize_t name##_show(struct gfs2_sbd *sdp, char *buf)                 \
 }                                                                           \
 static struct counters_attr counters_attr_##name = __ATTR_RO(name)
 
-COUNTERS_ATTR(glock_count,      "%u\n");
-COUNTERS_ATTR(glock_held_count, "%u\n");
-COUNTERS_ATTR(inode_count,      "%u\n");
 COUNTERS_ATTR(reclaimed,        "%u\n");
 
 static struct attribute *counters_attrs[] = {
-	&counters_attr_glock_count.attr,
-	&counters_attr_glock_held_count.attr,
-	&counters_attr_inode_count.attr,
 	&counters_attr_reclaimed.attr,
 	NULL,
 };
#1 lore raw

PATCH 1/1 Remove unused counters

Hi,

Now in the -nmw git tree. Thanks,

Steve.

Quoted 52 lines · Bob Peterson

Hi,

This is kind of trivial in the greater scheme of things, but this removes three counters that AFAICT are never used.

Regards,

Bob Peterson
Red Hat GFS

--

 fs/gfs2/incore.h |    3 ---
 fs/gfs2/sys.c    |    6 ------
 2 files changed, 0 insertions(+), 9 deletions(-)
fs/gfs2/incore.h +0 -3
index 4c921ec..891b730 100644
@@ -636,9 +636,6 @@ struct gfs2_sbd {
 
 	/* Counters */
 
-	atomic_t sd_glock_count;
-	atomic_t sd_glock_held_count;
-	atomic_t sd_inode_count;
 	atomic_t sd_reclaimed;
 
 	char sd_fsname[GFS2_FSNAME_LEN];
fs/gfs2/sys.c +0 -6
index cc35ec8..9ab9fc8 100644
@@ -327,15 +327,9 @@ static ssize_t name##_show(struct gfs2_sbd *sdp, char *buf)                 \
 }                                                                           \
 static struct counters_attr counters_attr_##name = __ATTR_RO(name)
 
-COUNTERS_ATTR(glock_count,      "%u\n");
-COUNTERS_ATTR(glock_held_count, "%u\n");
-COUNTERS_ATTR(inode_count,      "%u\n");
 COUNTERS_ATTR(reclaimed,        "%u\n");
 
 static struct attribute *counters_attrs[] = {
-	&counters_attr_glock_count.attr,
-	&counters_attr_glock_held_count.attr,
-	&counters_attr_inode_count.attr,
 	&counters_attr_reclaimed.attr,
 	NULL,
 };