Skip to contentSkip to conversation

Launch browser / email client when clicking on link in about dialogs

PATCH In review Jaap A. Haitsma 2 participants 4 messages Feb 10, 2008 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Launch browser / email client when clicking on link in about dialogs

Hi Marcel

Another patch
http://bugzilla.gnome.org/show_bug.cgi?id=515581

Jaap

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

maintainer
#1 lore raw

Hi Jaap,

Quoted 2 lines

Another patch
http://bugzilla.gnome.org/show_bug.cgi?id=515581

can you fix the coding style please. There are white spaces that shouldn't be there.

Regards

Marcel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

maintainer
#2 lore raw

Hi Jaap,

Quoted 5 lines
Quoted 2 lines

Another patch
http://bugzilla.gnome.org/show_bug.cgi?id=515581

can you fix the coding style please. There are white spaces that shouldn't be there.

never mind. Did it by myself. Just two minor things.

First, I am picky about the coding style. Always have been and always will be. The code must look sane and not as some hackish crap. Also having the coding style in place in the first place makes my life easier and patching is a lot simpler.

Second, please don't put patches into Bugzilla. I stated before that I don't care about the GNOME Bugzilla. If you wanna do that, fine, but then send a copy to the mailing list (not some link). This is the place where I pick them up. Otherwise the will go unseen and end up in nirvana.

Regards

Marcel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

#3 lore raw
Quoted 7 lines · Marcel Holtmann

Hi Jaap,

Quoted 5 lines
Quoted 2 lines

Another patch
http://bugzilla.gnome.org/show_bug.cgi?id=515581

can you fix the coding style please. There are white spaces that shouldn't be there.

Sorry. I try not to put spaces, but it's difficult to change a habit. I'll try checking better when sending you a patch next time.

Quoted 6 lines

never mind. Did it by myself. Just two minor things.

First, I am picky about the coding style. Always have been and always will be. The code must look sane and not as some hackish crap. Also having the coding style in place in the first place makes my life easier and patching is a lot simpler.

Will do my best

Quoted 6 lines

Second, please don't put patches into Bugzilla. I stated before that I don't care about the GNOME Bugzilla. If you wanna do that, fine, but then send a copy to the mailing list (not some link). This is the place where I pick them up. Otherwise the will go unseen and end up in nirvana.

I personally feel the other way around. I tend to loose track of emails, so I prefer bugzilla.

But it's not a problem for me to also attach it, if you prefer that

Jaap

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel