irda_init() nuke useless debug printk
Subsystems (2)
PATCH 1/1 irda_init() nuke useless debug printk
irda_init()
dmesg line is not really informative, thus remove it. There are better ways to know that a module is loaded.
Seen on a debian config with IRDA_DEBUG enabled.
--- net/irda/irmod.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
net/irda/irmod.c +0 -2
@@ -90,8 +90,6 @@ static int __init irda_init(void) {int ret =0 ; -IRDA_DEBUG (0 ,"%s()\n" , __FUNCTION__); -/* Lower layer of the stack */ irlmp_init ();irlap_init ();
Signature · 1 line
1.5.4
David Miller
maintainerFrom: maximilian attems <[email protected]>
Date: Tue, 12 Feb 2008 11:30:47 +0100
Quoted 7 lines
irda_init()
dmesg line is not really informative, thus remove it. There are better ways to know that a module is loaded.Seen on a debian config with
IRDA_DEBUGenabled.Signed-off-by maximilian attems <[email protected]>
Well if you look at how IRDA_DEBUG is predominantly used, it's a function tracer, and that's exactly how it's being used here.
Either we decide that this is OK and leave it there, or we start moving the whole IRDA tree over to not do this. Not something in between.
Quoted 11 lines · David Miller
From: maximilian attems <[email protected]>
Date: Tue, 12 Feb 2008 11:30:47 +0100Quoted 7 lines
irda_init()
dmesg line is not really informative, thus remove it. There are better ways to know that a module is loaded.Seen on a debian config with
IRDA_DEBUGenabled.Signed-off-by maximilian attems <[email protected]>
Quoted 7 lines
Well if you look at how
IRDA_DEBUGis predominantly used, it's a function tracer, and that's exactly how it's being used here.Either we decide that this is OK and leave it there, or we start moving the whole IRDA tree over to not do this. Not something in between.
ack, happy with both.
i could also lower the visibility of that one.
it simply struck out on my sfuzz test runs, had this
dmesg line instead of usual stuff:
-- snipp
NET: Registered protocol family 9
X.25 for Linux Version 0.2
Bridge firewalling registered
PPP generic driver version 2.4.2
NET: Registered protocol family 24
Sangoma WANPIPE Router v1.1 (c) 1995-2000 Sangoma Technologies Inc.
NET: Registered protocol family 4
NET4: DECnet for Linux: V.2.5.68s (C) 1995-2003 Linux DECnet Project Team
DECnet: Routing cache hash table of 1024 buckets, 16Kbytes
NET: Registered protocol family 12
Bluetooth: Core ver 2.11
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
NET: Registered protocol family 15
NET: Registered protocol family 5irda_init()
NET: Registered protocol family 23
--