Skip to contentSkip to conversation

radeonfb: Speed up the I2C buses

PATCH In review Jean Delvare 2 participants 2 messages Feb 12, 2008 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 radeonfb: Speed up the I2C buses

There is no reason to drive the radeon I2C buses at such a low speed, so bump it from 12.5 kbps to 50 kbps. The Intel (i810) and Matrox framebuffer drivers already run their I2C bus at this speed.

---
This patch was already sent on:
* 2007-03-08
* 2007-09-09

 drivers/video/aty/radeon_i2c.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/aty/radeon_i2c.c +1 -1
@@ -77,7 +77,7 @@ static int radeon_setup_i2c_bus(struct r
 	chan->algo.setscl		= radeon_gpio_setscl;
 	chan->algo.getsda		= radeon_gpio_getsda;
 	chan->algo.getscl		= radeon_gpio_getscl;
-	chan->algo.udelay		= 40;
+	chan->algo.udelay		= 10;
 	chan->algo.timeout		= 20;
 	chan->algo.data 		= chan;	
 	
Signature · 6 lines
Jean Delvare

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
#1 lore raw
Quoted 5 lines · Jean Delvare

There is no reason to drive the radeon I2C buses at such a low speed, so bump it from 12.5 kbps to 50 kbps. The Intel (i810) and Matrox framebuffer drivers already run their I2C bus at this speed.

Ack.

Quoted 13 lines

---
This patch was already sent on:
* 2007-03-08
* 2007-09-09

 drivers/video/aty/radeon_i2c.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/video/aty/radeon_i2c.c static int radeon_setup_i2c_bus(struct r · line 83

Quoted 8 lines
drivers/video/aty/radeon_i2c.c +1 -1
@@ -77,7 +77,7 @@ static int radeon_setup_i2c_bus(struct r
 	chan->algo.setscl		= radeon_gpio_setscl;
 	chan->algo.getsda		= radeon_gpio_getsda;
 	chan->algo.getscl		= radeon_gpio_getscl;
-	chan->algo.udelay		= 40;
+	chan->algo.udelay		= 10;
 	chan->algo.timeout		= 20;
 	chan->algo.data 		= chan;	
 

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/