Skip to contentSkip to conversation

add support for Toradex Colibri module

PATCH New Daniel Mack 3 participants 9 messages Nov 30, 2007 – Apr 13, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add support for Toradex Colibri module

Hi,

this patch adds basic support for Toradex PXA27x based Colibri module. It cleanly applies on u-boot-1.1.6.

However, I didn't manage to get the flash to work at all, at boot time, I always get the message "Flash: 0 kB". I'm new to the U-Boot environment, so maybe I missed same essentials here.

Also, the DM9000 driver does not seem to be able to correctly read its MAC address on this platform. I've read some mails about similar behaviour. Is there any patch going upstream soon? For now, I helped myself by hacking a fake MAC to bd->bi_enetaddr right before initialization but that's of course not a solution.

Thanks and best regards,
Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: uboot-116-colibri.diff
Type: text/x-diff
Size: 33709 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20071130/7dcca347/attachment.diff

#1 lore raw

PATCH 1/1 add support for Toradex Colibri module

Quoted 9 lines · Daniel Mack

Hi,

this patch adds basic support for Toradex PXA27x based Colibri module. It cleanly applies on u-boot-1.1.6.

However, I didn't manage to get the flash to work at all, at boot time, I always get the message "Flash: 0 kB". I'm new to the U-Boot environment, so maybe I missed same essentials here.

Quoted 9 lines

Also, the DM9000 driver does not seem to be able to correctly read its MAC address on this platform. I've read some mails about similar behaviour. Is there any patch going upstream soon? For now, I helped myself by hacking a fake MAC to bd->bi_enetaddr right before initialization but that's of course not a solution.

Thanks and best regards,
Daniel

Please rebase your code on the last u-boot 1.3.0

Best regards,
J.

#2 lore raw

PATCH 1/1 add support for Toradex Colibri module

Quoted 1 line · Jean-Christophe PLAGNIOL-VILLARD

Please rebase your code on the last u-boot 1.3.0

Oops, I was trapped by the sourceforge cemetery, sorry. Patch against 1.3.0 is attached.

Best regards,
Daniel

 MAKEALL                       |    1 
 Makefile                      |    3 
 board/colibri/Makefile        |   51 ++++
 board/colibri/colibri.c       |   61 +++++
 board/colibri/config.mk       |    1 
 board/colibri/lowlevel_init.S |  465 ++++++++++++++++++++++++++++++++++++++++++
 board/colibri/pxavoltage.S    |  178 ++++++++++++++++
 board/colibri/u-boot.lds      |   56 +++++
 include/asm-arm/mach-types.h  |   13 +
 include/configs/colibri.h     |  261 +++++++++++++++++++++++
 10 files changed, 1090 insertions(+)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: uboot-130-colibri.diff
Type: text/x-diff
Size: 32945 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20071201/f34cc5d7/attachment.diff

#3 lore raw

PATCH 1/1 add support for Toradex Colibri module

Quoted 6 lines · Daniel Mack

Patch against 1.3.0 is attached.

Best regards,
Daniel

Quoted 11 lines
 MAKEALL                       |    1 
 Makefile                      |    3 
 board/colibri/Makefile        |   51 ++++
 board/colibri/colibri.c       |   61 +++++
 board/colibri/config.mk       |    1 
 board/colibri/lowlevel_init.S |  465 ++++++++++++++++++++++++++++++++++++++++++
 board/colibri/pxavoltage.S    |  178 ++++++++++++++++
 board/colibri/u-boot.lds      |   56 +++++
 include/asm-arm/mach-types.h  |   13 +
 include/configs/colibri.h     |  261 +++++++++++++++++++++++
 10 files changed, 1090 insertions(+)

Has this patch been taken?

Greets,
Daniel

#4 lore raw

PATCH 1/1 add support for Toradex Colibri module

Quoted 4 lines · Daniel Mack
Quoted 1 line · Daniel Mack

Patch against 1.3.0 is attached.

Has this patch been taken?

Is there anything the maintainers of U-Boot dislike about this patch? Or what is the reason for all my messages being ignored completely? At least some feedback would be pleasant.

Daniel

#5 lore raw

PATCH 1/1 add support for Toradex Colibri module

Dear Daniel,

Quoted 5 lines · in message <[email protected]> you wrote:
Quoted 4 lines · Daniel Mack
Quoted 1 line · Daniel Mack

Patch against 1.3.0 is attached.

Has this patch been taken?

I did not receive a pull request from the ARM custodian whichincluded this patch. In other words, no, so far not.

Quoted 3 lines

Is there anything the maintainers of U-Boot dislike about this patch? Or what is the reason for all my messages being ignored completely? At least some feedback would be pleasant.

I agree, and I apologize. I'm not satisfied with the state of ARM support myself.

Peter, could you please comment on this? Do you have any specific plans for this and a list of other ARM patches?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The whole world is about three drinks behind."     - Humphrey Bogart
#6 lore raw

PATCH 1/1 add support for Toradex Colibri module

In reply to Daniel Mack

Dear Daniel,

Quoted 7 lines · in message <[email protected]> you wrote:

Patch against 1.3.0 is attached.

Best regards,
Daniel

Quoted 11 lines
 MAKEALL                       |    1 
 Makefile                      |    3 
 board/colibri/Makefile        |   51 ++++
 board/colibri/colibri.c       |   61 +++++
 board/colibri/config.mk       |    1 
 board/colibri/lowlevel_init.S |  465 ++++++++++++++++++++++++++++++++++++++++++
 board/colibri/pxavoltage.S    |  178 ++++++++++++++++
 board/colibri/u-boot.lds      |   56 +++++
 include/asm-arm/mach-types.h  |   13 +
 include/configs/colibri.h     |  261 +++++++++++++++++++++++
 10 files changed, 1090 insertions(+)

There are coding style issues with your patch: trailing white space, C++ comments, indentation not by multiples of 8 characters.

Please clean up and resubmit.

And while you are at it - please keep lists sorted (MAKEALL, Makefile).

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He had been eight years upon a project for extracting sunbeams out of
cucumbers, which were to be put in vials hermetically sealed, and let
out to warm the air in raw inclement summers.        - Jonathan Swift
              _Gulliver's Travels_ ``A Voyage to Laputa, etc.'' ch. 5
#7 lore raw

PATCH 1/1 add support for Toradex Colibri module

Hi Wolfgang,

thanks for your response.

Quoted 7 lines · Wolfgang Denk

There are coding style issues with your patch: trailing white space, C++ comments, indentation not by multiples of 8 characters.

Please clean up and resubmit.

And while you are at it - please keep lists sorted (MAKEALL, Makefile).

Ok, done. New, refurbished patch is attached.

Thanks and best regards,
Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: uboot-131-colibri.diff
Type: text/x-patch
Size: 27093 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080213/b45e9743/attachment.bin

#8 lore raw

PATCH 1/1 add support for Toradex Colibri module

Quoted 2 lines · In message <1202906813.6976.2.camel@omuntu> you wrote:

Ok, done. New, refurbished patch is attached.

Please don't attach, but include inline. Ideally, use git-send-email to send the patch.

Signed-off-by line missing. Please rebase and resubmit.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The night sky over the planet Krikkit is the least interesting  sight
in the entire Universe.
                 - Douglas Adams _Life, the Universe, and Everything_