Skip to contentSkip to conversation

add check_legacy_ioport calls to prevent oops

PATCH In review Christian Krafft 5 participants 11 messages Feb 13, 2008 – Feb 18, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover add check_legacy_ioport calls to prevent oops

Hi,

the following two patches prevent kernel from crashing on powerpc. The surrounding ifdefs will be obsolete, if check_legacy_ioport becomes generic code.

Signature · 13 lines
Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,
Linux Kernel Development
IT Specialist


Vorsitzender des Aufsichtsrats:	Martin Jetter
Geschaeftsfuehrung:		Herbert Kircher
Sitz der Gesellschaft:		Boeblingen
Registriergericht:		Amtsgericht Stuttgart, HRB 243294
#1 lore raw

Re: [Patch 0/2] powerpc: avoid userspace poking to legacy ioports

sensors_detect crashes kernel on PowerPC, as it pokes directly to memory. This patch adds a check_legacy_ioports to read_port and write_port. It will now return ENXIO, instead of oopsing.

drivers/char/mem.c +11 -1
Index: linux.git/drivers/char/mem.c
===================================================================
@@ -566,8 +566,13 @@ static ssize_t read_port(struct file * f
 	char __user *tmp = buf;
 
 	if (!access_ok(VERIFY_WRITE, buf, count))
-		return -EFAULT; 
+		return -EFAULT;
+
 	while (count-- > 0 && i < 65536) {
+#ifdef CONFIG_PPC_MERGE
+		if (check_legacy_ioport(i))
+			return -ENXIO;
+#endif
 		if (__put_user(inb(i),tmp) < 0) 
 			return -EFAULT;  
 		i++;
@@ -585,6 +590,7 @@ static ssize_t write_port(struct file * 
 
 	if (!access_ok(VERIFY_READ,buf,count))
 		return -EFAULT;
+
 	while (count-- > 0 && i < 65536) {
 		char c;
 		if (__get_user(c, tmp)) {
@@ -592,6 +598,10 @@ static ssize_t write_port(struct file * 
 				break;
 			return -EFAULT; 
 		}
+#ifdef CONFIG_PPC_MERGE
+		if (check_legacy_ioport(i))
+			return -ENXIO;
+#endif
 		outb(c,i);
 		i++;
 		tmp++;
Signature · 13 lines
Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,
Linux Kernel Development
IT Specialist


Vorsitzender des Aufsichtsrats:	Martin Jetter
Geschaeftsfuehrung:		Herbert Kircher
Sitz der Gesellschaft:		Boeblingen
Registriergericht:		Amtsgericht Stuttgart, HRB 243294
#2 lore raw

Re: [Patch 0/2] powerpc: avoid userspace poking to legacy ioports

Quoted 5 lines · Christian Krafft

sensors_detect crashes kernel on PowerPC, as it pokes directly to memory. This patch adds a check_legacy_ioports to read_port and write_port. It will now return ENXIO, instead of oopsing.

The problem is that this prevents using /proc/ioports to access PCI IO space, which might be useful.

I hate that sensors_detect.. or for that matter any other userland code that pokes random ports like that. It should die.

Ben.

Quoted 44 lines

Index: linux.git/drivers/char/mem.c
===================================================================

drivers/char/mem.c +11 -1
@@ -566,8 +566,13 @@ static ssize_t read_port(struct file * f
 	char __user *tmp = buf;
 
 	if (!access_ok(VERIFY_WRITE, buf, count))
-		return -EFAULT; 
+		return -EFAULT;
+
 	while (count-- > 0 && i < 65536) {
+#ifdef CONFIG_PPC_MERGE
+		if (check_legacy_ioport(i))
+			return -ENXIO;
+#endif
 		if (__put_user(inb(i),tmp) < 0) 
 			return -EFAULT;  
 		i++;
@@ -585,6 +590,7 @@ static ssize_t write_port(struct file * 
 
 	if (!access_ok(VERIFY_READ,buf,count))
 		return -EFAULT;
+
 	while (count-- > 0 && i < 65536) {
 		char c;
 		if (__get_user(c, tmp)) {
@@ -592,6 +598,10 @@ static ssize_t write_port(struct file * 
 				break;
 			return -EFAULT; 
 		}
+#ifdef CONFIG_PPC_MERGE
+		if (check_legacy_ioport(i))
+			return -ENXIO;
+#endif
 		outb(c,i);
 		i++;
 		tmp++;

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

maintainer
#3 lore raw

Re: [Patch 0/2] powerpc: avoid userspace poking to legacy ioports

Quoted 5 lines · Benjamin Herrenschmidt
Quoted 4 lines · Christian Krafft

sensors_detect crashes kernel on PowerPC, as it pokes directly to memory. This patch adds a check_legacy_ioports to read_port and write_port. It will now return ENXIO, instead of oopsing.

Quoted 7 lines
Quoted 1 line

The problem is that this prevents using /proc/ioports to access PCI IO space, which might be useful.

I hate that sensors_detect.. or for that matter any other userland code that pokes random ports like that. It should die.

What kind of Oops do you get? Is it because the ioport area is not ioremapped at all or do you get a machine check? If there is no mapping, we could possibly change inb and outb do deal with that.

	Arnd <><
#4 lore raw

Re: [Patch 0/2] powerpc: avoid userspace poking to legacy ioports

In reply to Benjamin Herrenschmidt

Hi Ben,

Quoted 3 lines · Benjamin Herrenschmidt
Quoted 1 line · Christian Krafft

sensors_detect crashes kernel on PowerPC, as it pokes directly to memory.

For the records, sensors-detect accesses I/O ports, not memory.

Quoted 7 lines
Quoted 4 lines

This patch adds a check_legacy_ioports to read_port and write_port. It will now return ENXIO, instead of oopsing.

The problem is that this prevents using /proc/ioports to access PCI IO space, which might be useful.

Maybe Christian's patch can be improved to not do the check on these? As long as /dev/port exists, it seems reasonable that the kernel should behave, no matter what I/O ports are accessed from user-space.

Quoted 2 lines

I hate that sensors_detect.. or for that matter any other userland code that pokes random ports like that. It should die.

What do you propose as a replacement?

And how is userland code poking at random ports different from kernel code poking at random ports? We could move sensors-detect inside the kernel (and I have some plan to do that) but I fail to see how this would solve this particular problem.

Quoted 38 lines
Quoted 38 lines

Index: linux.git/drivers/char/mem.c
===================================================================

drivers/char/mem.c +11 -1
@@ -566,8 +566,13 @@ static ssize_t read_port(struct file * f
 	char __user *tmp = buf;
 
 	if (!access_ok(VERIFY_WRITE, buf, count))
-		return -EFAULT; 
+		return -EFAULT;
+
 	while (count-- > 0 && i < 65536) {
+#ifdef CONFIG_PPC_MERGE
+		if (check_legacy_ioport(i))
+			return -ENXIO;
+#endif
 		if (__put_user(inb(i),tmp) < 0) 
 			return -EFAULT;  
 		i++;
@@ -585,6 +590,7 @@ static ssize_t write_port(struct file * 
 
 	if (!access_ok(VERIFY_READ,buf,count))
 		return -EFAULT;
+
 	while (count-- > 0 && i < 65536) {
 		char c;
 		if (__get_user(c, tmp)) {
@@ -592,6 +598,10 @@ static ssize_t write_port(struct file * 
 				break;
 			return -EFAULT; 
 		}
+#ifdef CONFIG_PPC_MERGE
+		if (check_legacy_ioport(i))
+			return -ENXIO;
+#endif
 		outb(c,i);
 		i++;
 		tmp++;
Signature · 1 line
Jean Delvare
#5 lore raw

Re: [Patch 0/2] powerpc: avoid userspace poking to legacy ioports

Quoted 4 lines

Maybe Christian's patch can be improved to not do the check on these? As long as /dev/port exists, it seems reasonable that the kernel should behave, no matter what I/O ports are accessed from user-space.

nonsense.

/dev/mem exists for example, but you are still not supposed to go
bang all over the place in it.

Quoted 4 lines
Quoted 2 lines

I hate that sensors_detect.. or for that matter any other userland code that pokes random ports like that. It should die.

What do you propose as a replacement?

Dunno, something less scary, like knowing where your sensors are on a given machine... honestly, it's just scary the risk you guys are taking by banging random IO ports.

At the very least, that shouldn't be done on non-x86.

Quoted 4 lines

And how is userland code poking at random ports different from kernel code poking at random ports? We could move sensors-detect inside the kernel (and I have some plan to do that) but I fail to see how this would solve this particular problem.

It wouldn't, but at least I could NAK it or make it CONFIG_X86 :-)

Ben.

#6 lore raw

Re: [Patch 0/2] powerpc: avoid userspace poking to legacy ioports

Quoted 9 lines · Benjamin Herrenschmidt
Quoted 4 lines

Maybe Christian's patch can be improved to not do the check on these? As long as /dev/port exists, it seems reasonable that the kernel should behave, no matter what I/O ports are accessed from user-space.

nonsense.

/dev/mem exists for example, but you are still not supposed to go
bang all over the place in it.

You should at least be able to read from it without crashing the machine. Of course writing is a different story.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

I hate that sensors_detect.. or for that matter any other userland code that pokes random ports like that. It should die.

What do you propose as a replacement?

Dunno, something less scary, like knowing where your sensors are on a given machine...

You mean, having a complete database for the, what, 4000 PC motherboards out there? And maintaining it day after day? _This_ sounds much scarier to me than the current situation.

Quoted 2 lines

honestly, it's just scary the risk you guys are taking by banging random IO ports.

I don't remember anyone reporting problems with this in the past 3 or 4 years, so it doesn't seem to be a big problem in practice.

Quoted 1 line

At the very least, that shouldn't be done on non-x86.

I am surprised that anyone would actually run sensors-detect on non-x86... Non-PC hardware usually doesn't have sensors driven by "hwmon" drivers anyway, or people know what they have and do not need detection. But I would be totally fine with updating sensors-detect to skip some of the probes on non-x86 hardware. There are basically 3 /dev/port probes that are done currently:

* Super-I/O chips at 0x2e/0x2f and 0x4e/0x4f.

* Legacy PC hardware monitoring chips at 0x290-0x297.

* IPMI interface at 0x0ca3 and 0x0cab (read-only).

Please tell me which ones should be skipped on PowerPC.

Christian, can you tell me which of these probes caused trouble for you?

Quoted 6 lines
Quoted 4 lines

And how is userland code poking at random ports different from kernel code poking at random ports? We could move sensors-detect inside the kernel (and I have some plan to do that) but I fail to see how this would solve this particular problem.

It wouldn't, but at least I could NAK it or make it CONFIG_X86 :-)

The same could be done for user-space (or at the /dev/port level.)

Signature · 1 line
Jean Delvare
#7 lore raw

Re: [Patch 0/2] powerpc: avoid userspace poking to legacy ioports

Quoted 7 lines · On Mon, 18 Feb 2008 21:58:42 +0100 Jean Delvare <[email protected]> wrote:
Quoted 6 lines · Benjamin Herrenschmidt
Quoted 5 lines

Maybe Christian's patch can be improved to not do the check on these? As long as /dev/port exists, it seems reasonable that the kernel should behave, no matter what I/O ports are accessed from user-space.

Quoted 7 lines
Quoted 4 lines

nonsense.

/dev/mem exists for example, but you are still not supposed to go
bang all over the place in it.

You should at least be able to read from it without crashing the machine. Of course writing is a different story.

keep dreaming. This is not how /dev/mem works today, not on x86 and very likely not on ppc either.

#8 lore raw

Re: [Patch 0/2] powerpc: avoid userspace poking to legacy ioports

In reply to Jean Delvare
Quoted 9 lines

* Super-I/O chips at 0x2e/0x2f and 0x4e/0x4f.

* Legacy PC hardware monitoring chips at 0x290-0x297.

* IPMI interface at 0x0ca3 and 0x0cab (read-only).

Please tell me which ones should be skipped on PowerPC.

Skip the whole thing. I consider that on a powerpc linux port, the platform is responsible for telling drivers where things are (via the device tree generally)

Quoted 10 lines

Christian, can you tell me which of these probes caused trouble for you?

Quoted 6 lines
Quoted 4 lines

And how is userland code poking at random ports different from kernel code poking at random ports? We could move sensors-detect inside the kernel (and I have some plan to do that) but I fail to see how this would solve this particular problem.

It wouldn't, but at least I could NAK it or make it CONFIG_X86 :-)

The same could be done for user-space (or at the /dev/port level.)

Well, there are -other- legit usages of /dev/port...

Ben.

#9 lore raw

Re: [Patch 2/2] powerpc: i2c-isa: add access check to legacy ioports

In reply to Christian Krafft

when probing i2c-pca-isa writes to legacy ioports, which crashes the kernel if there is no device at that port.
This patch adds a check_legacy_ioport call, so probe failes gracefully and thus prevents the oops.

drivers/i2c/busses/i2c-pca-isa.c +7 -0
Index: linux.git/drivers/i2c/busses/i2c-pca-isa.c
===================================================================
@@ -125,6 +125,13 @@ static int __devinit pca_isa_probe(struc
 
 	dev_info(dev, "i/o base %#08lx. irq %d\n", base, irq);
 
+#ifdef CONFIG_PPC_MERGE
+	if (check_legacy_ioport(base)) {
+		dev_err(dev, "I/O address %#08lx is not available\n", base);
+		goto out;
+	}
+#endif
+
 	if (!request_region(base, IO_SIZE, "i2c-pca-isa")) {
 		dev_err(dev, "I/O address %#08lx is in use\n", base);
 		goto out;
Signature · 13 lines
Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,
Linux Kernel Development
IT Specialist


Vorsitzender des Aufsichtsrats:	Martin Jetter
Geschaeftsfuehrung:		Herbert Kircher
Sitz der Gesellschaft:		Boeblingen
Registriergericht:		Amtsgericht Stuttgart, HRB 243294
#10 lore raw

Re: [Patch 2/2] powerpc: i2c-isa: add access check to legacy ioports

Hi Christian,

Quoted 16 lines · Christian Krafft

when probing i2c-pca-isa writes to legacy ioports, which crashes the kernel if there is no device at that port.
This patch adds a check_legacy_ioport call, so probe failes gracefully and thus prevents the oops.

Index: linux.git/drivers/i2c/busses/i2c-pca-isa.c
===================================================================

drivers/i2c/busses/i2c-pca-isa.c +0 -0
@@ -125,6 +125,13 @@ static int __devinit pca_isa_probe(struc
 
 	dev_info(dev, "i/o base %#08lx. irq %d\n", base, irq);
 

drivers/i2c/busses/i2c-pca-isa.c static int __devinit pca_isa_probe(struc · line 137

Quoted 10 lines
drivers/i2c/busses/i2c-pca-isa.c +7 -0
+#ifdef CONFIG_PPC_MERGE
+	if (check_legacy_ioport(base)) {
+		dev_err(dev, "I/O address %#08lx is not available\n", base);
+		goto out;
+	}
+#endif
+
 	if (!request_region(base, IO_SIZE, "i2c-pca-isa")) {
 		dev_err(dev, "I/O address %#08lx is in use\n", base);
 		goto out;

I can apply this, no problem. That being said, you might alternatively just exclude this driver from PPC. It's for a rare device with no known user, the driver is unmaintained and will hopefully be replaced soon by a platform driver which will not probe random ports at load time.

Signature · 1 line
Jean Delvare