Skip to contentSkip to conversation

x86: sparse error in efi_32.c

PATCH Applied Harvey Harrison 2 participants 2 messages Feb 13, 2008 – Feb 16, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 x86: sparse error in efi_32.c

include/linux/efi.h does not include asm/efi.h, efi.c and efi_64.c explicitly include both. While not really right, add the include to efi_32.c until the header gets sorted out.

arch/x86/kernel/efi_32.c:42:6: warning: symbol 'efi_call_phys_prelog' was not declared. Should it be static? arch/x86/kernel/efi_32.c:84:6: warning: symbol 'efi_call_phys_epilog' was not declared. Should it be static?

---
 arch/x86/kernel/efi_32.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/efi_32.c +1 -0
index cb91f98..5d23d85 100644
@@ -28,6 +28,7 @@
 #include <asm/page.h>
 #include <asm/pgtable.h>
 #include <asm/tlbflush.h>
+#include <asm/efi.h>
 
 /*
  * To make EFI call EFI runtime service in physical addressing mode we need
Signature · 1 line
1.5.4.1.1278.gc75be
#1 lore raw
Quoted 8 lines · Harvey Harrison

include/linux/efi.h does not include asm/efi.h, efi.c and efi_64.c explicitly include both. While not really right, add the include to efi_32.c until the header gets sorted out.

arch/x86/kernel/efi_32.c:42:6: warning: symbol 'efi_call_phys_prelog' was not declared. Should it be static? arch/x86/kernel/efi_32.c:84:6: warning: symbol 'efi_call_phys_epilog' was not declared. Should it be static?

Applied. Thanks

tglx