Skip to contentSkip to conversation

x86: don't make swapper_pg_fixmap global

PATCH Applied Adrian Bunk 3 participants 3 messages Feb 13, 2008 – Feb 16, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: don't make swapper_pg_fixmap global

It's not required for swapper_pg_fixmap to be global.

---
cdaa89e8d9f49eecc6ec9052db1d65a62f1be04b diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S index 74ef4a4..25eb985 100644

arch/x86/kernel/head_32.S +1 -1
@@ -612,7 +612,7 @@ ENTRY(swapper_pg_pmd)
 ENTRY(swapper_pg_dir)
 	.fill 1024,4,0
 #endif
-ENTRY(swapper_pg_fixmap)
+swapper_pg_fixmap:
 	.fill 1024,4,0
 ENTRY(empty_zero_page)
 	.fill 4096,1,0
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Adrian Bunk

It's not required for swapper_pg_fixmap to be global.

Quoted 16 lines

---
cdaa89e8d9f49eecc6ec9052db1d65a62f1be04b diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S index 74ef4a4..25eb985 100644

arch/x86/kernel/head_32.S +1 -1
@@ -612,7 +612,7 @@ ENTRY(swapper_pg_pmd)
 ENTRY(swapper_pg_dir)
 	.fill 1024,4,0
 #endif
-ENTRY(swapper_pg_fixmap)
+swapper_pg_fixmap:
 	.fill 1024,4,0
 ENTRY(empty_zero_page)
 	.fill 4096,1,0
Signature · 4 lines
Ian Campbell

Getting into trouble is easy.
		-- D. Winkel and F. Prosser