Skip to contentSkip to conversation

adfs: trivial sparse fix

PATCH In review Harvey Harrison 2 participants 4 messages Feb 14, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 adfs: trivial sparse fix

fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement

---
 fs/adfs/dir_f.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/adfs/dir_f.c +2 -2
index b9b2b27..ea7df21 100644
@@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
 		ptr.ptr8 = bufoff(bh, i);
 		end.ptr8 = ptr.ptr8 + last - i;
 
-		do
+		do {
 			dircheck = *ptr.ptr8++ ^ ror13(dircheck);
-		while (ptr.ptr8 < end.ptr8);
+		} while (ptr.ptr8 < end.ptr8);
 	}
 
 	/*
Signature · 1 line
1.5.4.1.1278.gc75be
#1 lore raw
Quoted 12 lines · On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <[email protected]>…

fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement

---
 fs/adfs/dir_f.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/adfs/dir_f.c +0 -0
index b9b2b27..ea7df21 100644

fs/adfs/dir_f.c adfs_dir_checkbyte(const struct adfs_dir *dir) · line 129

Quoted 10 lines
fs/adfs/dir_f.c +2 -2
@@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
 		ptr.ptr8 = bufoff(bh, i);
 		end.ptr8 = ptr.ptr8 + last - i;
 
-		do
+		do {
 			dircheck = *ptr.ptr8++ ^ ror13(dircheck);
-		while (ptr.ptr8 < end.ptr8);
+		} while (ptr.ptr8 < end.ptr8);
 	}
 

eh? It's sparse which needs fixing here, surely?

#2 lore raw
Quoted 17 lines · Andrew Morton
Quoted 15 lines · On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <[email protected]>…

fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement

---
 fs/adfs/dir_f.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/adfs/dir_f.c +0 -0
index b9b2b27..ea7df21 100644
@@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
 		ptr.ptr8 = bufoff(bh, i);
 		end.ptr8 = ptr.ptr8 + last - i;
 
Quoted 9 lines

fs/adfs/dir_f.c adfs_dir_checkbyte(const struct adfs_dir *dir) · line 129

Quoted 7 lines
fs/adfs/dir_f.c +2 -2
-		do
+		do {
 			dircheck = *ptr.ptr8++ ^ ror13(dircheck);
-		while (ptr.ptr8 < end.ptr8);
+		} while (ptr.ptr8 < end.ptr8);
 	}
 

eh? It's sparse which needs fixing here, surely?

Well, I only 'fixed' it this way to match the surrounding code. The warning is a little odd.

Harvey

#3 lore raw
Quoted 28 lines · On Wed, 13 Feb 2008 19:52:12 -0800 Harvey Harrison <[email protected]>…
Quoted 17 lines · Andrew Morton
Quoted 15 lines · On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <[email protected]>…

fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement

---
 fs/adfs/dir_f.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/adfs/dir_f.c +0 -0
index b9b2b27..ea7df21 100644
@@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
 		ptr.ptr8 = bufoff(bh, i);
 		end.ptr8 = ptr.ptr8 + last - i;
 
Quoted 9 lines

fs/adfs/dir_f.c adfs_dir_checkbyte(const struct adfs_dir *dir) · line 129

Quoted 7 lines
fs/adfs/dir_f.c +2 -2
-		do
+		do {
 			dircheck = *ptr.ptr8++ ^ ror13(dircheck);
-		while (ptr.ptr8 < end.ptr8);
+		} while (ptr.ptr8 < end.ptr8);
 	}
 

eh? It's sparse which needs fixing here, surely?

Quoted 3 lines

Well, I only 'fixed' it this way to match the surrounding code. The warning is a little odd.

Yup, well, I changed the title to something sufficiently rude to get a reaction from Linus when it crosses his desk. We'll see ;)