Skip to contentSkip to conversation

ata: simplify clock divisor logic in pata_amd.c

PATCH In review Harvey Harrison 1 participant 1 message Feb 14, 2008 libata

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 ata: simplify clock divisor logic in pata_amd.c

Current code is essentially choosing between dividing by 1 or dividing by two, make the conditions a little more obvious.

As a bonus, removes a sparse error:
drivers/ata/pata_amd.c:59:11: warning: symbol '__x' shadows an earlier one drivers/ata/pata_amd.c:59:11: originally declared here

---
 drivers/ata/pata_amd.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/ata/pata_amd.c +4 -1
index 4b8d9b5..eaadb78 100644
@@ -56,7 +56,10 @@ static void timing_setup(struct ata_port *ap, struct ata_device *adev, int offse
 	u8 t;
 
 	T = 1000000000 / amd_clock;
-	UT = T / min_t(int, max_t(int, clock, 1), 2);
+	if (clock >= 2)
+		UT = T / 2;
+	else
+		UT = t;
 
 	if (ata_timing_compute(adev, speed, &at, T, UT) < 0) {
 		dev_printk(KERN_ERR, &pdev->dev, "unknown mode %d.\n", speed);
Signature · 1 line
1.5.4.1.1278.gc75be