Skip to contentSkip to conversation

Add CONFIG_INET dependency to CONFIG_XFRM_STATISTICS

PATCH In review Johann Felix Soden 3 participants 3 messages Feb 15, 2008 – Feb 16, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add CONFIG_INET dependency to CONFIG_XFRM_STATISTICS

From: Johann Felix Soden <[email protected]>

With INET=n and XFRM_STATISTICS=y I get the following build failure:

net/built-in.o: In function `xfrm_init':
(.init.text+0xcd7): undefined reference to `snmp_mib_init'

---
 net/xfrm/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/xfrm/Kconfig +1 -1
index 8f9dbec..3bf2338 100644
@@ -38,7 +38,7 @@ config XFRM_MIGRATE
 
 config XFRM_STATISTICS
 	bool "Transformation statistics (EXPERIMENTAL)"
-	depends on XFRM && PROC_FS && EXPERIMENTAL
+	depends on XFRM && PROC_FS && INET && EXPERIMENTAL
 	---help---
 	  This statistics is not a SNMP/MIB specification but shows
 	  statistics about transformation error (or almost error) factor
Signature · 1 line
1.5.4.1
maintainer
#1 lore raw

From: Johann Felix Soden <[email protected]>
Date: Fri, 15 Feb 2008 16:08:43 +0100

Quoted 9 lines

From: Johann Felix Soden <[email protected]>

With INET=n and XFRM_STATISTICS=y I get the following build failure:

net/built-in.o: In function `xfrm_init':
(.init.text+0xcd7): undefined reference to `snmp_mib_init'

A fix for this has been in my net-2.6 tree for a few days, and Linus pulled it in this morning.

#2 lore raw
Quoted 7 lines · David Miller

From: Johann Felix Soden <[email protected]>
Date: Fri, 15 Feb 2008 16:08:43 +0100

Quoted 4 lines

From: Johann Felix Soden <[email protected]>

With INET=n and XFRM_STATISTICS=y I get the following build failure:

Quoted 8 lines
Quoted 5 lines

net/built-in.o: In function `xfrm_init':
(.init.text+0xcd7): undefined reference to `snmp_mib_init'

A fix for this has been in my net-2.6 tree for a few days, and Linus pulled it in this morning.

Thank you guys for taking care of it.

Signature · 1 line
Masahide NAKAMURA