Skip to contentSkip to conversation

8610HPCD: Don't use VIDEO/CFB_CONSOLE by default.

PATCH New Jon Loeliger 2 participants 3 messages Feb 20, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 8610HPCD: Don't use VIDEO/CFB_CONSOLE by default.

Without an actual supported video card hooked up, enabling the CONFIG_VIDEO by default just makes it look broken by
routing all console output to the video card. Don't.

---

Wolfgang,

I'll drop this in my -mpc86xx tree for a -rc2 pickup!

Thanks,
jdl

 include/configs/MPC8610HPCD.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/MPC8610HPCD.h +1 -1
index 3920147..9e70198 100644
@@ -24,7 +24,7 @@
 #define CONFIG_FSL_DIU_FB	1	/* FSL DIU */
 
 /* video */
-#define CONFIG_VIDEO
+#undef CONFIG_VIDEO
 
 #if defined(CONFIG_VIDEO)
 #define CONFIG_CFB_CONSOLE
Signature · 1 line
1.5.4.rc5.19.g0509eb
#1 lore raw

PATCH 1/1 8610HPCD: Don't use VIDEO/CFB_CONSOLE by default.

include/configs/MPC8610HPCD.h line 30

Quoted 13 lines · Jon Loeliger
include/configs/MPC8610HPCD.h +1 -1
index 3920147..9e70198 100644
@@ -24,7 +24,7 @@
 #define CONFIG_FSL_DIU_FB	1	/* FSL DIU */
 
 /* video */
-#define CONFIG_VIDEO
+#undef CONFIG_VIDEO
 
 #if defined(CONFIG_VIDEO)
 #define CONFIG_CFB_CONSOLE

Wolfgang just applied a patch that removed unnecessary "#undef DEBUG", and your patch adds an unnecessary "#undef CONFIG_VIDEO".

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#2 lore raw

PATCH 1/1 8610HPCD: Don't use VIDEO/CFB_CONSOLE by default.

Quoted 3 lines · Timur Tabi

Wolfgang just applied a patch that removed unnecessary "#undef DEBUG", and your patch adds an unnecessary "#undef CONFIG_VIDEO".

So?

jdl