char: fix sparse shadowed variable warnings in esp.c
PATCH 1/2 char: fix sparse shadowed variable warnings in esp.c
flags only use was in spin_lock_irqsave/spin_lock_irgrestore pairs, no need to redeclare for each one.
drivers/char/esp.c:1599:17: warning: symbol 'flags' shadows an earlier one drivers/char/esp.c:1517:16: originally declared here drivers/char/esp.c:1615:17: warning: symbol 'flags' shadows an earlier one drivers/char/esp.c:1517:16: originally declared here drivers/char/esp.c:1631:17: warning: symbol 'flags' shadows an earlier one drivers/char/esp.c:1517:16: originally declared here
Signed-off-by Harvey Harrison <[email protected]>
--- drivers/char/esp.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)
drivers/char/esp.c +0 -6
@@ -1596,8 +1596,6 @@ static int set_esp_config(struct esp_struct * info,if ((new_config.flow_off != info->config.flow_off) || (new_config.flow_on != info->config.flow_on)) { -unsigned long flags; - info->config.flow_off = new_config.flow_off; info->config.flow_on = new_config.flow_on;
@@ -1612,8 +1610,6 @@ static int set_esp_config(struct esp_struct * info,if ((new_config.rx_trigger != info->config.rx_trigger) || (new_config.tx_trigger != info->config.tx_trigger)) { -unsigned long flags; - info->config.rx_trigger = new_config.rx_trigger; info->config.tx_trigger = new_config.tx_trigger;spin_lock_irqsave (&info->lock, flags);
@@ -1628,8 +1624,6 @@ static int set_esp_config(struct esp_struct * info, }if (new_config.rx_timeout != info->config.rx_timeout) { -unsigned long flags; - info->config.rx_timeout = new_config.rx_timeout;spin_lock_irqsave (&info->lock, flags);
Signature · 1 line
1.5.4.2.200.g99e75