Skip to contentSkip to conversation

char: fix possible double-unlock in specialix.c

PATCH Superseded Harvey Harrison 1 participant 1 message Feb 22, 2008 Char and misc drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 char: fix possible double-unlock in specialix.c

Noticed by sparse, trivial to see:
drivers/char/specialix.c:2112:3: warning: context imbalance in 'sx_throttle' - unexpected unlock

---
And with the torrent of warnings fixed, here we find a double-unlock.

 drivers/char/specialix.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/char/specialix.c +0 -1
index 5487f37..b508e2c 100644
@@ -2109,7 +2109,6 @@ static void sx_throttle(struct tty_struct * tty)
 	sx_out(bp, CD186x_CAR, port_No(port));
 	spin_unlock_irqrestore(&bp->lock, flags);
 	if (I_IXOFF(tty)) {
-		spin_unlock_irqrestore(&bp->lock, flags);
 		sx_wait_CCR(bp);
 		spin_lock_irqsave(&bp->lock, flags);
 		sx_out(bp, CD186x_CCR, CCR_SSCH2);
Signature · 1 line
1.5.4.2.200.g99e75