ep93xx_eth: conversion to phylib framework
Subsystems (2)
RFC PATCH 1/1 ep93xx_eth: conversion to phylib framework
Currently, the ep93xx_eth driver doesn't care about the PHY state, but it should, in order to tell the MAC when full duplex operation is required; failure to do so causes degraded performance on full duplex links. This patch implements proper PHY handling via the phylib framework:
- clean up ep93xx_mdio_{read,write} to conform to ep93xx manual
- convert ep93xx_eth driver to phylib framework
- set full duplex bit in configuration of MAC when FDX link detected
- convert to use print_mac()
---
If you need me to split this patch, please let me know into what parts
drivers/net/arm/Kconfig | 1 + drivers/net/arm/ep93xx_eth.c | 354 +++++++++++++++++++++++++++++++++--------- 2 files changed, 282 insertions(+), 73 deletions(-)
drivers/net/arm/Kconfig +1 -0
@@ -44,6 +44,7 @@ config EP93XX_ETH tristate "EP93xx Ethernet support" depends on ARM && ARCH_EP93XX select MII + select PHYLIB help This is a driver for the ethernet hardware included in EP93xx CPUs. Say Y if you are building a kernel for EP93xx based devices.
drivers/net/arm/ep93xx_eth.c +281 -73
499 lines not on this page · raw message
Signature · 1 line
1.5.3.4
Quoted 9 lines · Herbert Valerio Riedel
Currently, the
ep93xx_ethdriver doesn't care about the PHY state, but it should, in order to tell the MAC when full duplex operation is required; failure to do so causes degraded performance on full duplex links. This patch implements proper PHY handling via the phylib framework:- clean up ep93xx_mdio_{read,write} to conform to ep93xx manual
- convertep93xx_ethdriver to phylib framework
- set full duplex bit in configuration of MAC when FDX link detected
- convert to useprint_mac()
Looks good to me. My only comment is that we might want to have support for checking preamble suppression support in the PHY Lib, itself.
hello *
Quoted 13 lines · Andy Fleming
Quoted 10 lines · Herbert Valerio Riedel
Currently, the
ep93xx_ethdriver doesn't care about the PHY state, but it should, in order to tell the MAC when full duplex operation is required; failure to do so causes degraded performance on full duplex links. This patch implements proper PHY handling via the phylib framework:- clean up ep93xx_mdio_{read,write} to conform to ep93xx manual
- convertep93xx_ethdriver to phylib framework
- set full duplex bit in configuration of MAC when FDX link detected
- convert to useprint_mac()
Quoted 5 lines
Looks good to me. My only comment is that we might want to have support for checking preamble suppression support in the PHY Lib, itself.
Acked-by Andy Fleming <[email protected]>
...as nothing happend for some months now just wondering, what I should do next, to get this patch merged upstream :-)
cheers,
hvr
Quoted 11 lines · Herbert Valerio Riedel
Quoted 11 lines
Quoted 10 lines
Currently, the
ep93xx_ethdriver doesn't care about the PHY state, but it should, in order to tell the MAC when full duplex operation is required; failure to do so causes degraded performance on full duplex links. This patch implements proper PHY handling via the phylib framework:- clean up ep93xx_mdio_{read,write} to conform to ep93xx manual
- convertep93xx_ethdriver to phylib framework
- set full duplex bit in configuration of MAC when FDX link detected
- convert to useprint_mac()
Quoted 8 lines
Quoted 5 lines
Looks good to me. My only comment is that we might want to have support for checking preamble suppression support in the PHY Lib, itself.
Acked-by Andy Fleming <[email protected]>...as nothing happend for some months now just wondering, what I should do next, to get this patch merged upstream :-)
ACK!