xen: make blkif_getgeo static
Subsystems (6)
A message that is not in the archive (sent off-list or not yet received): 5ce117613299590dd08d11d24d3a33d9077fe2b0.1203898924.git.harvey.harrison@gmail.com
PATCH 2/6 xen: make blkif_getgeo static
Introduced between 2.6.25-rc2 and -rc3drivers/block/xen-blkfront.c:139:5: warning: symbol 'blkif_getgeo' was not declared. Should it be static?
--- drivers/block/xen-blkfront.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/block/xen-blkfront.c +1 -1
@@ -136,7 +136,7 @@ static void blkif_restart_queue_callback(void *arg)schedule_work (&info->work); } -int blkif_getgeo (struct block_device *bd,struct hd_geometry *hg) +static int blkif_getgeo (struct block_device *bd,struct hd_geometry *hg) {/* We don't have real geometry info, but let's at least return values consistent with the size of the device */
Signature · 1 line
1.5.4.2.200.g99e75
PATCH 3/6 agp: fix shadowed variable warning in amd-k7-agp.c
In reply to a message not in the archiveIntroduced between 2.6.25-rc2 and -rc3 drivers/char/agp/amd-k7-agp.c:439:6: warning: symbol 'cap_ptr' shadows an earlier one drivers/char/agp/amd-k7-agp.c:414:5: originally declared here
cap_ptr is never used again in this function, don't bother redeclaring.
--- drivers/char/agp/amd-k7-agp.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/char/agp/amd-k7-agp.c +2 -1
@@ -436,8 +436,9 @@ static int __devinit agp_amdk7_probe(struct pci_dev *pdev,system controller may experience noise due to strong drive strengths */ if (agp_bridge->dev->device ==PCI_DEVICE_ID_AMD_FE_GATE_7006 ) { -u8 cap_ptr=0 ;struct pci_dev *gfxcard=NULL ; + + cap_ptr =0 ;while (!cap_ptr) { gfxcard =pci_get_class (PCI_CLASS_DISPLAY_VGA <<8 , gfxcard);if (!gfxcard) {
Signature · 1 line
1.5.4.2.200.g99e75
PATCH 4/6 smack: make functions static
In reply to a message not in the archiveIntroduced between 2.6.25-rc2 and -rc3security/smack/smackfs.c:374:6: warning: symbol 'smk_unlbl_ambient' was not declared. Should it be static?
While here, take care of this one too.security/smack/smackfs.c:341:6: warning: symbol 'smk_cipso_doi' was not declared. Should it be static?
--- security/smack/smackfs.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
security/smack/smackfs.c +2 -2
@@ -338,7 +338,7 @@ static const struct file_operations smk_load_ops = {/** * smk_cipso_doi - initialize the CIPSO domain */ -void smk_cipso_doi (void ) +static void smk_cipso_doi (void ) {int rc;struct cipso_v4_doi *doip;
@@ -371,7 +371,7 @@ void smk_cipso_doi(void)/** * smk_unlbl_ambient - initialize the unlabeled domain */ -void smk_unlbl_ambient (char *oldambient) +static void smk_unlbl_ambient (char *oldambient) {int rc;struct netlbl_audit audit_info;
Signature · 1 line
1.5.4.2.200.g99e75
PATCH 5/6 block: remove extern on function definition
In reply to a message not in the archiveIntoduced between 2.6.25-rc2 and -rc3block/blk-settings.c:319:12: warning: function 'blk_queue_dma_drain' with external linkage has definition
--- block/blk-settings.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
block/blk-settings.c +1 -1
@@ -316,7 +316,7 @@ EXPORT_SYMBOL(blk_queue_stack_limits);* device can support otherwise there won't be room for the drain * buffer. */ -extern int blk_queue_dma_drain (struct request_queue *q, +int blk_queue_dma_drain (struct request_queue *q,dma_drain_needed_fn *dma_drain_needed,void *buf,unsigned int size) {
Signature · 1 line
1.5.4.2.200.g99e75
PATCH 6/6 block: fix shadowed variable warning in blk-map.c
In reply to a message not in the archiveIntroduced between 2.6.25-rc2 and -rc3 block/blk-map.c:154:14: warning: symbol 'bio' shadows an earlier one block/blk-map.c:110:13: originally declared here
--- block/blk-map.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
block/blk-map.c +3 -3
@@ -151,10 +151,10 @@ int blk_rq_map_user(struct request_queue *q, struct request *rq,*/ if (len &queue_dma_alignment (q)) {unsigned int pad_len = (queue_dma_alignment (q) & ~len) +1 ; -struct bio *bio = rq->biotail; +struct bio *tail = rq->biotail; - bio->bi_io_vec[bio->bi_vcnt -1 ].bv_len += pad_len; - bio->bi_size += pad_len; + tail->bi_io_vec[tail->bi_vcnt -1 ].bv_len += pad_len; + tail->bi_size += pad_len; rq->data_len += pad_len; }
Signature · 1 line
1.5.4.2.200.g99e75