Skip to contentSkip to conversation

sound: emuproc.c fix signedness warning

PATCH In review Harvey Harrison 2 participants 2 messages Feb 28, 2008 – Feb 29, 2008 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/8 sound: emuproc.c fix signedness warning

Reading regs from the fpga into an int instead of a u32, trivial
fix.
sound/pci/emu10k1/emuproc.c:422:34: warning: incorrect type in argument 3 (different signedness)
sound/pci/emu10k1/emuproc.c:422:34: expected unsigned int [usertype] *value
sound/pci/emu10k1/emuproc.c:422:34: got int *<noident>

---
 sound/pci/emu10k1/emuproc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/pci/emu10k1/emuproc.c +1 -1
index f3caa3f..216f974 100644
@@ -412,7 +412,7 @@ static void snd_emu_proc_emu1010_reg_read(struct snd_info_entry *entry,
 				     struct snd_info_buffer *buffer)
 {
 	struct snd_emu10k1 *emu = entry->private_data;
-	int value;
+	u32 value;
 	unsigned long flags;
 	int i;
 	snd_iprintf(buffer, "EMU1010 Registers:\n\n");
Signature · 1 line
1.5.4.3.342.g99e8
#1 lore raw

At Thu, 28 Feb 2008 11:11:12 -0800,

Quoted 8 lines · Harvey Harrison

Reading regs from the fpga into an int instead of a u32, trivial
fix.
sound/pci/emu10k1/emuproc.c:422:34: warning: incorrect type in argument 3 (different signedness)
sound/pci/emu10k1/emuproc.c:422:34: expected unsigned int [usertype] *value
sound/pci/emu10k1/emuproc.c:422:34: got int *<noident>

Thanks, all applied to ALSA tree (with trivial coding-style fixes -- could you run checkpatch.pl at the next time and fix the issues together?)

Takashi