Skip to contentSkip to conversation

ci: fix build for Arm cross compilation in GHA

PATCH Applied David Marchand 4 participants 4 messages Jun 6, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ci: fix build for Arm cross compilation in GHA

We are hitting a storage limit when linking binaries statically. On the other hand, native builds are tested in other part of the CI and the chance of breaking static linking only is relatively low, so let's simply test linking against shared libraries.

---
 .github/workflows/build.yml | 1 +
 1 file changed, 1 insertion(+)
.github/workflows/build.yml +1 -0
index 7322eb59b7..3b629fcdbd 100644
@@ -53,6 +53,7 @@ jobs:
             cross: mingw
           - os: ubuntu-20.04
             compiler: gcc
+            library: shared
             cross: aarch64
           - os: ubuntu-20.04
             compiler: gcc
Signature · 1 line
2.40.1
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · David Marchand

We are hitting a storage limit when linking binaries statically. On the other hand, native builds are tested in other part of the CI and the chance of breaking static linking only is relatively low, so let's simply test linking against shared libraries.

---
 .github/workflows/build.yml | 1 +
 1 file changed, 1 insertion(+)

Yep, with the number of "test" apps now in each build, our build directories get rather massive!

Tested-by
#2 lore raw
Quoted 13 lines · Bruce Richardson
Quoted 11 lines · David Marchand

We are hitting a storage limit when linking binaries statically. On the other hand, native builds are tested in other part of the CI and the chance of breaking static linking only is relatively low, so let's simply test linking against shared libraries.

---
 .github/workflows/build.yml | 1 +
 1 file changed, 1 insertion(+)
Quoted 5 lines

Yep, with the number of "test" apps now in each build, our build directories get rather massive!

Confirmed that this solves the "running out of disk space" issue seen on 'ubuntu-20.04-gcc-aarch64',

#3 lore raw

06/06/2023 15:02, Ferruh Yigit:

Quoted 17 lines · Bruce Richardson
Quoted 16 lines · David Marchand
Quoted 11 lines

We are hitting a storage limit when linking binaries statically. On the other hand, native builds are tested in other part of the CI and the chance of breaking static linking only is relatively low, so let's simply test linking against shared libraries.

---
 .github/workflows/build.yml | 1 +
 1 file changed, 1 insertion(+)

Yep, with the number of "test" apps now in each build, our build directories get rather massive!

Quoted 7 lines
Quoted 2 lines

Confirmed that this solves the "running out of disk space" issue seen on 'ubuntu-20.04-gcc-aarch64',

Applied, thanks.