Skip to contentSkip to conversation

include/asm-arm - use angle brackets for includes

PATCH Applied Joe Perches 2 participants 4 messages Mar 5, 2008 – Mar 6, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 include/asm-arm - use angle brackets for includes

include/asm-arm/plat-s3c/uncompress.h | 4 ++--

 include/asm-arm/proc-fns.h            |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
include/asm-arm/plat-s3c/uncompress.h +2 -2
index b5e6208..19b9eda 100644
@@ -27,8 +27,8 @@ static void arch_detect_cpu(void);
 
 /* defines for UART registers */
 
-#include "asm/plat-s3c/regs-serial.h"
-#include "asm/plat-s3c/regs-watchdog.h"
+#include <asm/plat-s3c/regs-serial.h>
+#include <asm/plat-s3c/regs-watchdog.h>
 
 /* working in physical space... */
 #undef S3C2410_WDOGREG
include/asm-arm/proc-fns.h +2 -2
index a4ce457..75ec760 100644
@@ -214,9 +214,9 @@
 #ifndef __ASSEMBLY__
 
 #ifndef MULTI_CPU
-#include "asm/cpu-single.h"
+#include <asm/cpu-single.h>
 #else
-#include "asm/cpu-multi32.h"
+#include <asm/cpu-multi32.h>
 #endif
 
 #include <asm/memory.h>
#1 lore raw

To: Russell King <[email protected]>, Nicolas Pitre <[email protected]>
Cc: [email protected],
LKML <[email protected]>

No idea why you're sending this to Nicolas, yet it touches s3cXXXX stuff which is Ben Dooks, who has been omitted from the above.

Quoted 1 line · Joe Perches

This is not a proper signed off - please use both angle brackets. 8)

Quoted 38 lines

include/asm-arm/plat-s3c/uncompress.h | 4 ++--

 include/asm-arm/proc-fns.h            |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
include/asm-arm/plat-s3c/uncompress.h +2 -2
index b5e6208..19b9eda 100644
@@ -27,8 +27,8 @@ static void arch_detect_cpu(void);
 
 /* defines for UART registers */
 
-#include "asm/plat-s3c/regs-serial.h"
-#include "asm/plat-s3c/regs-watchdog.h"
+#include <asm/plat-s3c/regs-serial.h>
+#include <asm/plat-s3c/regs-watchdog.h>
 
 /* working in physical space... */
 #undef S3C2410_WDOGREG
include/asm-arm/proc-fns.h +2 -2
index a4ce457..75ec760 100644
@@ -214,9 +214,9 @@
 #ifndef __ASSEMBLY__
 
 #ifndef MULTI_CPU
-#include "asm/cpu-single.h"
+#include <asm/cpu-single.h>
 #else
-#include "asm/cpu-multi32.h"
+#include <asm/cpu-multi32.h>
 #endif
 
 #include <asm/memory.h>
Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#2 lore raw
In reply to Joe Perches

Signature too...

 include/asm-arm/plat-s3c/uncompress.h |    4 ++--
 include/asm-arm/proc-fns.h            |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
include/asm-arm/plat-s3c/uncompress.h +2 -2
index b5e6208..19b9eda 100644
@@ -27,8 +27,8 @@ static void arch_detect_cpu(void);
 
 /* defines for UART registers */
 
-#include "asm/plat-s3c/regs-serial.h"
-#include "asm/plat-s3c/regs-watchdog.h"
+#include <asm/plat-s3c/regs-serial.h>
+#include <asm/plat-s3c/regs-watchdog.h>
 
 /* working in physical space... */
 #undef S3C2410_WDOGREG
include/asm-arm/proc-fns.h +2 -2
index a4ce457..75ec760 100644
@@ -214,9 +214,9 @@
 #ifndef __ASSEMBLY__
 
 #ifndef MULTI_CPU
-#include "asm/cpu-single.h"
+#include <asm/cpu-single.h>
 #else
-#include "asm/cpu-multi32.h"
+#include <asm/cpu-multi32.h>
 #endif
 
 #include <asm/memory.h>
Applied
#3 lore raw
Quoted 3 lines · Joe Perches

Signature too...

Applied, thanks.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of: